Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp446537rwd; Tue, 16 May 2023 03:24:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4PFBTRPYTDDUW/KTMWks5fWedgTP/iW5RvOeI27qhs2vwL3BEbyErRlHsU63SMwK7SwDQQ X-Received: by 2002:a05:6a00:2d9a:b0:641:d9b:a458 with SMTP id fb26-20020a056a002d9a00b006410d9ba458mr48350727pfb.18.1684232639920; Tue, 16 May 2023 03:23:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684232639; cv=none; d=google.com; s=arc-20160816; b=nOD6K1nTpGqZ9yg0LCiy+KCV8bwGInKbE9Gx0PiGg43apfyHHvh6mccvZtOlIFrYvh N+5RimhiUJx7csqRfPQcq/Onl1LLH2FZHNWHF5WLBuTWNY+lfYDsIn0iYxGN4xwlTXVj ZEGdibTl8AlZ9wru5pxEGexE7r+I/FuB58ygiERXpCwV5KpEEWSow0d7g/b2j1j6dOga reqHhcv9jU8MuXifgHYFZCKl3vI4KMxeV0b2HJiaKtURQWKH2wh8wrQAAsBhawJnHAfD FZc0BJxSKLgcFKma4eFW2RCN2oX+Z8RGAj14VchD51Q5d5jFdHTkanHsKFp3MLrVU75x 718Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4idR4l7BR/zp86Msj8rUb9VMEP8eF7R5IxMQAPLbooA=; b=E+jQE3Axo6rtvgex0blwcCgrGro510R2T6lb3SeJ3Mp2Q2PVRssVDIw2dvMwq2PpiV CL0VIQP7ginTAqjdndG141NKXFBLlMGNvZvASIFZgxOPrYkbfF4Ya3zJZEE771RBoqPl BzpVUIjcAkl10CaC48kK4l0aiXGlzmTlGraQeP2CWb56M/8iM+R239IREAzYefiN7/Vt EMQQkuOiVksXG7MpjBg7mblIYxOBk1wDwjOvp4OMxG65rD4bffV3MorB2uS/piFcC9tZ PcdmfMU5JwmtHVAHa4NTTO/mbf1zLgyPzWtWHy4fvjcaK6PsAhNPT+HadEvhLWLXAwH8 hh3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="fmNhx/lc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x7-20020aa79407000000b0064672de37cesi19276138pfo.192.2023.05.16.03.23.45; Tue, 16 May 2023 03:23:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="fmNhx/lc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232007AbjEPKIc (ORCPT + 99 others); Tue, 16 May 2023 06:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232135AbjEPKII (ORCPT ); Tue, 16 May 2023 06:08:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 613F8E7A; Tue, 16 May 2023 03:08:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E955462347; Tue, 16 May 2023 10:08:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B29DC433EF; Tue, 16 May 2023 10:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684231685; bh=9rwHmSwT7dbAEIPo156SJSK+Xaa+4zJir8iTQqqilwQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fmNhx/lcnsROh7wR1TaHGtfMENiJUolfSpwCka1PRPcWcef52D+RUVjt1lMQpdij2 VMqSbc0lkDTLfjZqsnLvzHUusDw6BhIsaw8DxfGe9GZ0fl/dc9DL8jt5Mp2uAuuUxx gFtZDuqvlToE8f5ILadJUrkBfPRwaScOdRN8DyfYfKQlr4QjX2UNZvA3zK9Ns07Q4D 7Mf2t8aCfgtrmIDv6rN1SL8igBkeaELZLp+p5H5McQhlemZk/5ae2Rh3jwov9pxeta JG1pqdX6EMlNIJkT4N9TFyjp7N+MbmYDYkqt197TAEclYWC6N2C6qyCoxAjCXofzyx uERUFIEq1Kc9w== Date: Tue, 16 May 2023 11:07:58 +0100 From: Lee Jones To: Charles Keepax Cc: Mark Brown , Marc Zyngier , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, tglx@linutronix.de, linus.walleij@linaro.org, vkoul@kernel.org, lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] irqchip/cs42l43: Add support for the cs42l43 IRQs Message-ID: <20230516100758.GE10825@google.com> References: <20230512122838.243002-1-ckeepax@opensource.cirrus.com> <20230512122838.243002-8-ckeepax@opensource.cirrus.com> <86o7mpmvqq.wl-maz@kernel.org> <20230512153933.GH68926@ediswmail.ad.cirrus.com> <86mt29mt2m.wl-maz@kernel.org> <20230512164233.GN68926@ediswmail.ad.cirrus.com> <20230515095752.GQ68926@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230515095752.GQ68926@ediswmail.ad.cirrus.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 May 2023, Charles Keepax wrote: > On Mon, May 15, 2023 at 10:08:41AM +0900, Mark Brown wrote: > > On Fri, May 12, 2023 at 04:42:33PM +0000, Charles Keepax wrote: > > > > > I guess if Mark doesn't mind I think the only internal bit of the > > > device that uses the IRQs is the CODEC driver so I could move the > > > IRQ handling in there, it does seem a little odd to me, but I > > > guess I don't have any problems with it. > > > > The obvious (and previously standard) place for it would be the MFD. > > Alright I certainly have no objection to moving it there, although > would be good to get Lee's thoughts, make sure he is happy with > that too. Submit a patch and we'll take it from there. -- Lee Jones [李琼斯]