Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 12:19:25 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] iavf: Replace one-element array with
 flexible-array member
Message-ID: <ZGNYrUeFHC7wR/1A@corigine.com>
References: <ZGLR3H1OTgJfOdFP@work>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZGLR3H1OTgJfOdFP@work>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ApVVqwYfM88l0MtGNcF1cM6SP/RTeV9DjRP86WyQnV8gtJakE8z9jy2cPj5l?=
 =?us-ascii?Q?qW+32j2ytjVA/zfrRgEVBUMfMoU0PEbYudSafjM01TZzQ9J/gIW3gO6aWGhe?=
 =?us-ascii?Q?uFXPBAk5Sqq2c/G7VFiRgwIMvKJcYvoGfm9b6Q5xsrJZjS6P6j7WcLHEcCdR?=
 =?us-ascii?Q?7WwdkUeuanNtR+INcRcoz7kA73DaXjkf+mClst0qlpjpF5se2z5HHsM4LQVt?=
 =?us-ascii?Q?Z0GebUKB9BoTEVcnyGkz5bWCtPxvw2t69ZTlLlvzhiXbK8s1HJi3o0xt4M/e?=
 =?us-ascii?Q?hmUR2noOItbDBM6QtY0HWa0Ds3287aM0RO5Xd8ef5vNkA8ZjWOMxOeYN415u?=
 =?us-ascii?Q?+LhqkoSP/do21gwDMW2MODcb165nYloe4lAAzGkMUBfJmQwX5Hriku76S2Fj?=
 =?us-ascii?Q?9Ct/njUrLqUrgnVCi/Smfo3c+ZmDUQY8UMEqR3H1jCUj6z1oEnOdb41Wzd2Z?=
 =?us-ascii?Q?p9uOttX+tVOfOjMo68yW99Ofl3yC0YksyCQtGB2QsqAcIx5eYNgP6szoYALz?=
 =?us-ascii?Q?bu6LZUrh8CpSa3gMItykzRsBqdvJJmR2MUGr2J+sl9XnSMMJMtUQUOxvugHp?=
 =?us-ascii?Q?02ic4232eZ+Lzpy+OeomG46GOM7MxYT6dUHVF9mNumYJuRToxjHv+kHlHFpb?=
 =?us-ascii?Q?yGyWHtoKxL8tA7/zFY/+UnA2VmoiOL6lOzRKrtamQAz16l63Wx8tfvLrIF8O?=
 =?us-ascii?Q?eEHGp2TLT/nZyVyhF6XCTr2mAYlFV4+IfD4jMSnwszQobsZryyZ6tU6k/k8P?=
 =?us-ascii?Q?ULsBiFcOCfbRzxwEaAwlmewsIzG1OTwHh+dXO8r/RQ55LA6aWk3JqCLS8l7G?=
 =?us-ascii?Q?9/3rqT0/pw5Lj4nMQzxXva2A+1zrApZ01+jnonBAB84fgS2bUVodcjme8t7w?=
 =?us-ascii?Q?8UxiQZP3XxLNMfsFI1NqkSJk8Zc7Po7EAaSG2Pl1t5iZ0U/uOfcMLMHiKdHB?=
 =?us-ascii?Q?2Wf1cEF+tLKtV0kywZbgSvTaosWRi5r5JCW+Li+TRR/HQNHwku48KRB/K4QS?=
 =?us-ascii?Q?UNrPU7zLgHcn8PH6VyZoZqS+OBjTH2f01nN3wZa0M1XQD1uxFRU2Ncxxdwmg?=
 =?us-ascii?Q?kKou9GEg3krDqGMF8Qbj6nrUPEfM8VFqZgjCX+wHoMluvZuzhN/PDu7xzMSz?=
 =?us-ascii?Q?lqDk+ppr2WhI6iUcTUNfwNIqeXAFtO+IIKuhhR++do7mlZyzsoRkuhgaoXf+?=
 =?us-ascii?Q?8cCVhwKRzty5SAIcJSeHO8S4Xt4BQypbr7VbetVplCBsniQIZTQyx2FFWZIc?=
 =?us-ascii?Q?stB2GKMV1yJpdyXVstZGRX1dYAcneJz6wy+cJPBZK2lSk3bxElleWuAP42ri?=
 =?us-ascii?Q?7yyYhgT3PB5wnWcG7vU3HQx7h5x1gyowrTtPWUtj58mMFkyXJ4GNns8ioVzW?=
 =?us-ascii?Q?qJIThQl/TjapoGIjoLIOcP0mLMPSRxF1iJRPDuHlziHb3IIq83Dm6RwZt3zR?=
 =?us-ascii?Q?RVAvaK9rBrWQYBi0HhmUrQUe74CkeFbUBxIj5ahaWxCBVioX3Hte1jpLJjEx?=
 =?us-ascii?Q?tCjNq5iSoqrT89rvwizeaGpOKukNWgNH0UCTwMEiTMUvkmMJpJS/BKVrbPgw?=
 =?us-ascii?Q?SY7GCHeN6xskgF7m4DKmN2p9mDWFYyFFdsN6SYUVSg1RKopNenm8Eq28cepy?=
 =?us-ascii?Q?teBvu02Rf09spU6jDayDX0k5VJkPdBPbCNVZfWCNYI5BgoKcKd2SrES90H0P?=
 =?us-ascii?Q?OT+8GA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0509c69-c26e-4789-d29d-08db55f711c7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 10:19:44.9383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F6ekm636j7/j42tPzIcmGuE1kPL+0e3h4+ojpuIz0sUKRaocnjiTyH5z8cbly4lQdElMzYPl7tcE8V7scakbcQ2hDFkU4XMkyEq+1tLnHds=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4081
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 15, 2023 at 06:44:12PM -0600, Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct iavf_qvlist_info, and refactor the rest of the code,
> accordingly.
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [1].
> 
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/289
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>