Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE:(2) [PATCH v2 02/14] block: bio-integrity: modify
 bio_integrity_add_page()
Reply-To: j-young.choi@samsung.com
Sender: Jinyoung CHOI <j-young.choi@samsung.com>
From:   Jinyoung CHOI <j-young.choi@samsung.com>
To:     "hch@lst.de" <hch@lst.de>
CC:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "kbusch@kernel.org" <kbusch@kernel.org>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
        "kch@nvidia.com" <kch@nvidia.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20230512134323.GA32242@lst.de>
Message-ID: <20230516125407epcms2p82f3323c8b869b8517408adb451413e6c@epcms2p8>
Date:   Tue, 16 May 2023 21:54:07 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20230512134323.GA32242@lst.de>
        <20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p1>
        <20230510084854epcms2p756a3e1055399ead6bf539d3419c74c3e@epcms2p7>
        <CGME20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p8>
Precedence: bulk

>Hi Jinyoung,
>
>can you work a bit on the commit log and especially the subject line?
>
>I'd word this as something like:
>
>=22Subject: bio-integrity: create multi-page bvecs in bio_integrity_add_pa=
ge()
>
>Allow bio_integrity_add_page to create multi-page bvecs, just like
>the bio payloads. =C2=A0This=20simplifies=20adding=20larger=20payloads,=20=
and=20fixes=0D=0A>support=20for=20non-tiny=20workloads=20with=20nvme,=20whi=
ch=20stopped=20using=20scatterlist=0D=0A>for=20metadata=20a=20while=20ago=
=22=0D=0A>=0D=0A=0D=0AHi.=20Christoph.=20I=20checked=20late.=0D=0A=0D=0AOK.=
=20I=20will=20revise=20it=20like=20that.=0D=0A=0D=0A>It=20should=20probably=
=20also=20mentioned=20somewhere=20that=20you=20did=20an=20audit=20to=0D=0A>=
ensure=20all=20drivers=20and=20the=20core=20code=20is=20fine=20with=20these=
=20multi-page=0D=0A>segments.=20=C2=A0If=20it's=20not,=20this=20patch=20sho=
uld=20only=20be=20added=20after=20that=0D=0A>has=20been=20made=20the=20case=
.=0D=0A=0D=0ARegardless=20of=20a=20single-page=20or=20a=20multi-page=20conf=
iguration,=0D=0Ablock_rq_count_integrity_sg()=20and=20block_rq_map_integry_=
sg()=20check=0D=0Athe=20pages=20included=20in=20the=20bip=20to=20create=20a=
=20segment=20for=20sg.=0D=0ASo...=20there=20doesn't=20seem=20to=20be=20a=20=
problem=20yet.=0D=0A=0D=0AFirst,=20the=20nvme=20device=20that=20supports=20=
fips=20was=20tested=20using=20the=20above=0D=0Afunctions,=20and=20it=20was=
=20also=20checked=20with=20the=20dix=20of=20scsi_debug=20turned=20on.=0D=0A=
I=20am=20also=20trying=20to=20test=20the=20sas=20device=20that=20supports=
=20sed.=20It=20seems=20that=0D=0Aa=20problem=20occurs=20while=20going=20thr=
ough=20the=20laid=20controller=20(mpt3sas=20driver).=0D=0AIt=20works=20norm=
ally=20in=20DIF=20mode,=20but=20protection=20error=20occurs=20when=20DIX=20=
mode=0D=0Ais=20forcibly=20activated.=20Of=20course,=20the=20same=20is=20hap=
pening=20in=20the=20original=20code.=0D=0AI=20will=20check=20additionally=
=20and=20be=20careful=20not=20to=20cause=20any=20problems.=0D=0A=0D=0A>=0D=
=0A>I=20think=20the=20extra=20arguments=20struct=20is=20a=20bit=20overcompl=
iated,=20and=20mostly=0D=0A>due=20to=20me=20making=20the=20existing=20code=
=20to=20weird=20things=20in=20the=20low-level=0D=0A>helpers.=20=C2=A0With=
=20the=20=22rationalize=20the=20flow=20in=20bio_add_page=20and=20friends=22=
=0D=0A>series=20I=20just=20sent=20out,=20I=20think=20we=20can=20drop=20the=
=20previous=20patch=20and=0D=0A>simplify=20this=20one=20down=20to:=0D=0A=0D=
=0AI=20tried=20not=20to=20make=20a=20big=20change=20from=20the=20existing=
=20logic.=20So=20I=20added=0D=0Astruct=20unnecessarily.=20I=20thought=20it=
=20would=20be=20a=20problem=20if=20I=20added=20=0D=0Aconditions=20to=20the=
=20callers=20and=20made=20them=20call=20the=20common=20code.=0D=0AThank=20y=
ou=20for=20solving=20this=20part.=0D=0AIf=20your=20code=20merges,=20I=20wil=
l=20modify=20it=20accordingly=20and=20proceed.=0D=0A=0D=0ABest=20Regards,=
=0D=0AJinyoung.=0D=0A