Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE:(2) [PATCH v2 05/14] block: blk-merge: fix to add the number of
 integrity segments to the request twice
Reply-To: j-young.choi@samsung.com
Sender: Jinyoung CHOI <j-young.choi@samsung.com>
From:   Jinyoung CHOI <j-young.choi@samsung.com>
To:     "hch@lst.de" <hch@lst.de>
CC:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "kbusch@kernel.org" <kbusch@kernel.org>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
        "kch@nvidia.com" <kch@nvidia.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20230512135136.GD32242@lst.de>
Message-ID: <20230516132412epcms2p2549c58f92db9919002c7e05ed044bcc8@epcms2p2>
Date:   Tue, 16 May 2023 22:24:12 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20230512135136.GD32242@lst.de>
        <20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p1>
        <20230510085208epcms2p52a6dec8da80152ec2101f11ce2ea5321@epcms2p5>
        <CGME20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p2>
Precedence: bulk

>The subject looks a bit odd, I think you're trying to say:
>
>=22do not add the number of integrity segments to the request twice=22
>
>based on the actual patch, is this correct?
>

Yes. I will fix it.

>> +static inline bool blk_integrity_bypass_check(struct request *req,
>> + =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20bio=20=
*bio)=0D=0A>>=20+=7B=0D=0A>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0return=
=20blk_integrity_rq(req)=20=3D=3D=200=20&&=20bio_integrity(bio)=20=3D=3D=20=
NULL;=0D=0A>>=20+=7D=0D=0A>=0D=0A>No=20need=20for=20the=20explicit=20compar=
isms,=20this=20could=20just=20be:=0D=0A>=0D=0A>=20=C2=A0=20=C2=A0=20=C2=A0=
=20=C2=A0return=20=21blk_integrity_rq(req)=20&&=20=21bio_integrity(bio);=0D=
=0A>=0D=0A>and=20given=20that=20it=20just=20has=20two=20callers=20I'm=20not=
=20sure=20the=20helper=20is=0D=0A>all=20that=20useful=20to=20start=20with.=
=0D=0A=0D=0AThere=20are=20many=20conditional=20sentences=20like=20that,=20s=
o=20I=20left=20them=20for=20unity,=0D=0AIf=20it's=20okay=20to=20change,=20I=
'll=20do=20so.=0D=0A=0D=0A>>=20+static=20bool=20__blk_integrity_mergeable(s=
truct=20request_queue=20*q,=0D=0A>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20reques=
t=20*req,=20struct=20bio=20*bio)=0D=0A>>=20+=7B=0D=0A>>=20+=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0if=20(blk_integrity_rq(req)=20=3D=3D=200=20=7C=7C=20bi=
o_integrity(bio)=20=3D=3D=20NULL)=0D=0A>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0return=20false;=0D=0A>>=20+=0D=0A=
>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0if=20(bio_integrity(req->bio)->bi=
p_flags=20=21=3D=20bio_integrity(bio)->bip_flags)=0D=0A>>=20+=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0return=20false;=
=0D=0A>>=20+=0D=0A>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0return=20true;=
=0D=0A>>=20+=7D=0D=0A>>=20+=0D=0A>>=20+bool=20blk_integrity_mergeable(struc=
t=20request_queue=20*q,=20struct=20request=20*req,=0D=0A>>=20+=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20struct=20bio=20*bio)=0D=0A>>=20+=
=7B=0D=0A>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0if=20(blk_integrity_bypa=
ss_check(req,=20bio))=0D=0A>>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0return=20true;=0D=0A>>=20+=0D=0A>>=20+=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0return=20__blk_integrity_mergeable(q,=20req,=
=20bio);=0D=0A>>=20+=7D=0D=0A>=0D=0A>Similarly=20here,=20I'm=20not=20even=
=20sure=20we=20need=20all=20these=20helpers.=20=C2=A0I=20supect=0D=0A>the=
=20code=20would=20become=20more=20readable=20by=20dropping=20these=20helper=
s=20and=20just=0D=0A>making=20the=20checks=20explicitl=E1=BA=8F=0D=0A=0D=0A=
OK.=20I=20will=20drop=20this.=0D=0A=0D=0ABest=20Regards,=0D=0AJinyoung.