Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d034b9e-e4e6-5d72-8b37-78e25918aa59@amd.com>
Date:   Tue, 16 May 2023 15:30:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Content-Language: en-US
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     linux-kernel@vger.kernel.org, monstr@monstr.eu,
        michal.simek@xilinx.com, git@xilinx.com,
        Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>,
        Andrew Davis <afd@ti.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Parth Gajjar <parth.gajjar@amd.com>,
        Piyush Mehta <piyush.mehta@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>,
        Vishal Sagar <vishal.sagar@amd.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <cover.1683034376.git.michal.simek@amd.com>
 <1b2914e5e6010b174c14603f92626ac3b11a2263.1683034376.git.michal.simek@amd.com>
 <20230510065421.GB11711@pendragon.ideasonboard.com>
From:   Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH 02/23] arm64: zynqmp: Fix usb node drive strength and slew
 rate
In-Reply-To: <20230510065421.GB11711@pendragon.ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlpLRUNHcUZrVEgyMHdGQ09aNVUxMkp0cm94V2JLTEdrSkNmT3p5ZUlvdDZi?=
 =?utf-8?B?dzZvVUVOeVlzMTZNanFVZW9KSkhNZWwyUVVPS3pkckM5NEMzRlRpUk80Tmxr?=
 =?utf-8?B?RU42UWtobjY4TjJsTVoxTm1IOGZBTmwwS0hIUm5nK2VzWVRzSmRFZnJhN0w5?=
 =?utf-8?B?TVJvc3ZDcCs4MElFYi96cEZzZ1JIYUlDV0hlR0NESUdhUjZhUG9ZNTE3WlZa?=
 =?utf-8?B?aUlsQVJyZzF3WDg1UkdIejhjUU1JR1dDUVNwRGhrNk5lcWpmbUwrcUR0bitr?=
 =?utf-8?B?ekhRU1lhQzZwaDdsYW5rTzJCcko5TndTTllqQ1RGZEN2Ui8vTEErMEdFeU1E?=
 =?utf-8?B?ZDdxbEpXNGRsdlh1K2ozY3Ftd1FPS1RONU03U2hiay9WT0FheWVoYjNGQWdy?=
 =?utf-8?B?VEF1TERXU3h6RkYxMzdtNGNDMkFqOU0wTlVKdi9QNTZXeS9QSk43RUhVMzZw?=
 =?utf-8?B?NHlQaDNUbTdJSDNUZjBXSEpqWGJiUEphQ0xqM2haVDdjbHJ6V25ENEZlZmhU?=
 =?utf-8?B?T0lJVjFvOXBRVlVCUFdZUnVGNTR4UXZXWUpWVTVXdlByY05tWFBzT3ZrcmJa?=
 =?utf-8?B?Z0NkVE5lQ2hjSXdrY3RheGdyeDVvT0FHQWNTanJnWmtiSDRKeVIweDVQVVQv?=
 =?utf-8?B?a2JTczJvN3Z2dUZLUmZQNUdtOXJzWGE0YVArN3JqcWhHWEg3NEJ2Y1EvNk9s?=
 =?utf-8?B?L093UWNCaW8wRkFUNldUMmJ2d3lUZkQxa08xam5PQUludStMM3J6QTJCV1N1?=
 =?utf-8?B?NjIwSUFrMW9kMTh5WjVselNmM2kxY1JCRjNDOFgwSGM3Zk43Q3g0NzJBYWZR?=
 =?utf-8?B?elQ3UVk1ZHIwSGdWZnZxN1MwOFR1b3dMbUpGbEdXdklRcGxFT0Q4Szc5bnM0?=
 =?utf-8?B?UDhSREh3WUNQMFVNWUs5RW85dUcrSXgzc3lZRFhXMDhKTHIrTDNSNVU5b2VZ?=
 =?utf-8?B?S3RzVG1FQWZDUXd4SHFiWkszditoOFEzME9IcUhza25EVzZCbHR3ZXloaGhm?=
 =?utf-8?B?STdybEFTQitzTEJtbmFQUWsrdEl4L2hXelZBUVV5TVgwWmNMNlJ1MUVGS2Uw?=
 =?utf-8?B?QWpENzA0dHVwTTR0K0oweXpEYVV6SllLaW9ZQXdGbmhPWGpwVm5kOFlsNndv?=
 =?utf-8?B?QitoL1Y3bFB6Rk9wbi9zZ1pHMFpyMVdDWXNlN2ZDU0N1Z2prRXhiM0Y1QnBV?=
 =?utf-8?B?cEk5NGhwdElCaVdrQk0xdnZXcXplUGNaVWRtSVZqMVFlQWtQeWJqblRVbXV5?=
 =?utf-8?B?Rnh0ZHhweXJjNXp1RVhNaWM2b3lOb0pmVVNldFcrYXI3R3N1QllpV3R0Titu?=
 =?utf-8?B?ZmJsUzlWbXVZZThjZmRjS0ZxSTYrTWpLd1RXcXBtNXN1Wk9qWGxBZGIzTG1l?=
 =?utf-8?B?bVNVMlNoWmlHQjl6WWlXOENTeTQ1enQ1R3V0bjhuUFVQelI5RytmT3ljSUhI?=
 =?utf-8?B?UmZ3QnZqNVpFWTlhY05JRkc5aGFIcUNvZHlnMzBLc3hKYVhTVnRzM2VoSlZt?=
 =?utf-8?B?Q2FKY3JqUjRVK2xZMlpzcGcxMkpwUnhTZjVpMFdFZ1VKWVB2T2Z1QytFRlRk?=
 =?utf-8?B?YjB5UnZiZHl4K1lHelRzdGI1OVpsSFZQTElZYld1RzkrRTlkS05hVld0YWJl?=
 =?utf-8?B?b0Y5aVYrZ0p1RWtOVHlRdXAxejNwczZZOVpzQXZUY0Y4bUNGMWRFWWl0R2Z0?=
 =?utf-8?B?QzV2eGt3NGFSb0F1RmZrRytkNXg1NktyNU0vMExqMG0xaVYzdlVXR001b0FU?=
 =?utf-8?B?MVZNeDNEbTU2WlJrOHFUOUlnalowbHN0aTI1Q3JnK0FlNnhBMklvVVFGWUdR?=
 =?utf-8?B?RlhGL21ENXR0Zk01Q2N1ZjlBUlcyckovSVR6TVpEU1RITllGYks1dXVvM09W?=
 =?utf-8?B?bXF5OUI3TGhuMWZUNjhJV2NDMHNESVp0TlZ0S0k3cWlCZVlmREJKdlBhOEU0?=
 =?utf-8?B?bzB5aHZKWTBCWmlvTjg1dHBNNGVZZk9LZmhSYWRrU0swTXNZMWpRYWVlL283?=
 =?utf-8?B?aWdBVVhLMnVNS04vQ1AyYmZpTzR3bnVVUUt6L3A3cW9FeDFGZmRkcWJDNVA3?=
 =?utf-8?B?WGJwSHdKemVRSUpGazhJUWJHQ29QV3Y1VWw5SHZYSjZvTmpIMVEzdGVnQU9o?=
 =?utf-8?Q?1hDDj0qDijhrYryz8VW1wY711?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2dba3ec-3dbc-4214-d9f9-08db5611bf18
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 13:30:42.7181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w2hL/DKx3ooEW33TNFuus2JEcZpoiySL4t5qTguy5rwR+FCx7UvPGT0B7UV5HraH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6317
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent

On 5/10/23 08:54, Laurent Pinchart wrote:
> Hi Michal,
> 
> Thank you for the patch.
> 
> On Tue, May 02, 2023 at 03:35:30PM +0200, Michal Simek wrote:
>> From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>>
>> As per design, all input/rx pins should have fast slew rate and 12mA
>> drive strength.
> 
> Why does the slow rate and drive strength matter for input pins ?

In design tools all inputs pins are setup like described by default.
That's why it could suggest that there is no need to describe default 
configuration in DT.
But all MIOs can be used as GPIOs where pinctrl can change their default values 
to something else. That's why setting up default values is to be safe even for 
input pins. I don't know HW details to that extend but that values can also 
change input behavior that's why having default is not a bad idea.

Maybe make sense to extend commit message to describe it better.

Thanks,
Michal