Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 08:51:37 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Andrew Davis <afd@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Robert Nelson <robertcnelson@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] arm64: dts: ti: k3-j721e-beagleboneai64: Fix mailbox
 node status
Message-ID: <20230516135137.y2akvgeghe6xg446@earful>
References: <20230515172137.474626-1-afd@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230515172137.474626-1-afd@ti.com>
Precedence: bulk

On 12:21-20230515, Andrew Davis wrote:
> Mailbox nodes are now disabled by default. The BeagleBoard AI64 DT
> addition went in at around the same time and must have missed that
> change so the mailboxes are not re-enabled. Do that here.

Uggh. thanks.

> 
> Fixes: fae14a1cb8dd ("arm64: dts: ti: Add k3-j721e-beagleboneai64")
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index 37c24b077b6a..8a62ac263b89 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -936,6 +936,7 @@ &ufs_wrapper {
>  };
>  
>  &mailbox0_cluster0 {
> +	status = "okay";
>  	interrupts = <436>;
>  
>  	mbox_mcu_r5fss0_core0: mbox-mcu-r5fss0-core0 {
> @@ -950,6 +951,7 @@ mbox_mcu_r5fss0_core1: mbox-mcu-r5fss0-core1 {
>  };
>  
>  &mailbox0_cluster1 {
> +	status = "okay";
>  	interrupts = <432>;
>  
>  	mbox_main_r5fss0_core0: mbox-main-r5fss0-core0 {
> @@ -964,6 +966,7 @@ mbox_main_r5fss0_core1: mbox-main-r5fss0-core1 {
>  };
>  
>  &mailbox0_cluster2 {
> +	status = "okay";
>  	interrupts = <428>;
>  
>  	mbox_main_r5fss1_core0: mbox-main-r5fss1-core0 {
> @@ -978,6 +981,7 @@ mbox_main_r5fss1_core1: mbox-main-r5fss1-core1 {
>  };
>  
>  &mailbox0_cluster3 {
> +	status = "okay";
>  	interrupts = <424>;
>  
>  	mbox_c66_0: mbox-c66-0 {
> @@ -992,6 +996,7 @@ mbox_c66_1: mbox-c66-1 {
>  };
>  
>  &mailbox0_cluster4 {
> +	status = "okay";
>  	interrupts = <420>;
>  
>  	mbox_c71_0: mbox-c71-0 {
> -- 
> 2.39.2
> 
Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D