Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 21:14:59 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>, bhelgaas@google.com
Cc:     Mario Limonciello <mario.limonciello@amd.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Keith Busch <kbusch@kernel.org>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>,
        Stefan Roese <sr@denx.de>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, Pengyu Ma <mapengyu@gmail.com>
Subject: Re: [PATCH] PCI/portdrv: Avoid enabling AER on Thunderbolt devices
Message-ID: <ZGOP4wd3ZFkGb31e@debian.me>
References: <20221226153048.1208359-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="swGwUbbeTl4fTlQh"
Content-Disposition: inline
In-Reply-To: <20221226153048.1208359-1-kai.heng.feng@canonical.com>
Precedence: bulk


--swGwUbbeTl4fTlQh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 26, 2022 at 11:30:31PM +0800, Kai-Heng Feng wrote:
> We are seeing igc ethernet device on Thunderbolt dock stops working
> after S3 resume because of AER error, or even make S3 resume freeze:
> pcieport 0000:00:1d.0: AER: Multiple Corrected error received: 0000:00:1d=
=2E0
> pcieport 0000:00:1d.0: PCIe Bus Error: severity=3DCorrected, type=3DTrans=
action Layer, (Receiver ID)
> pcieport 0000:00:1d.0:   device [8086:7ab0] error status/mask=3D00008000/=
00002000
> pcieport 0000:00:1d.0:    [15] HeaderOF
> pcieport 0000:00:1d.0: AER: Multiple Uncorrected (Non-Fatal) error receiv=
ed: 0000:00:1d.0
> pcieport 0000:00:1d.0: PCIe Bus Error: severity=3DUncorrected (Non-Fatal)=
, type=3DTransaction Layer, (Requester ID)
> pcieport 0000:00:1d.0:   device [8086:7ab0] error status/mask=3D00100000/=
00004000
> pcieport 0000:00:1d.0:    [20] UnsupReq               (First)
> pcieport 0000:00:1d.0: AER:   TLP Header: 34000000 0a000052 00000000 0000=
0000
> pcieport 0000:00:1d.0: AER:   Error of this Agent is reported first
> pcieport 0000:04:01.0: PCIe Bus Error: severity=3DUncorrected (Non-Fatal)=
, type=3DTransaction Layer, (Requester ID)
> pcieport 0000:04:01.0:   device [8086:1136] error status/mask=3D00300000/=
00000000
> pcieport 0000:04:01.0:    [20] UnsupReq               (First)
> pcieport 0000:04:01.0:    [21] ACSViol
> pcieport 0000:04:01.0: AER:   TLP Header: 34000000 04000052 00000000 0000=
0000
> thunderbolt 0000:05:00.0: AER: can't recover (no error_detected callback)
>=20
> This supposedly should be fixed by commit c01163dbd1b8 ("PCI/PM: Always d=
isable
> PTM for all devices during suspend"), but somehow it doesn't work for
> this case.
>=20
> By dumping the PCI_PTM_CTRL register on resume, it turns out PTM is
> already flipped on by either the Thunderbolt dock firmware or the host
> BIOS. Writing 0 to PCI_PTM_CTRL yields the same result.
>=20
> Windows is however not affected by this issue, by using WinDbg's !pci
> command, it shows that AER is not enabled for devices connected via
> Thunderbolt port, and that's the reason why Windows doesn't exhibit the
> issue.
>=20
> So turn a blind eye on external Thunderbolt devices like Windows does by
> disabling AER.
>=20
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D216850
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Hi,

I noticed a similar regression on bugzilla [1] where I asked the
reporter to test your patch, and his regression still occured. For
full details, see bugzilla.

Thanks.

Reported-by: Pengyu Ma <mapengyu@gmail.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D217446 [1]

--=20
An old man doll... just what I always wanted! - Clara

--swGwUbbeTl4fTlQh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZGOP3AAKCRD2uYlJVVFO
o55WAQDiz4AxHaMzxpfSq/YrLOTQ/UbRNX9S9CPp4N3fJWDYewD/bJqyDv6mWPX/
qgKDqtaJs5+6j6Frsnkqel2RqU6dbg4=
=IdSW
-----END PGP SIGNATURE-----

--swGwUbbeTl4fTlQh--