Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 16:06:40 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Iurii Zaikin <yzaikin@google.com>,
        Kees Cook <keescook@chromium.org>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/6] sysctl: Remove register_sysctl_table from parport
Message-ID: <20230516140640.il6w54hpbj3zq7lo@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="z4i2cvxpia5dzh6m"
Content-Disposition: inline
In-Reply-To: <ZGKU5vP8Anmfeen0@bombadil.infradead.org>
CMS-TYPE: 201P
References: <CGME20230515071448eucas1p111c55b7078f1541f487c9dfb1a9f9c15@eucas1p1.samsung.com>
        <20230515071446.2277292-1-j.granados@samsung.com>
        <ZGKU5vP8Anmfeen0@bombadil.infradead.org>
Precedence: bulk

--z4i2cvxpia5dzh6m
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 15, 2023 at 01:24:06PM -0700, Luis Chamberlain wrote:
> On Mon, May 15, 2023 at 09:14:40AM +0200, Joel Granados wrote:
> > This is part of the general push to deprecate register_sysctl_paths and
> > register_sysctl_table. Parport driver uses the "CHILD" pointer
> > in the ctl_table structure to create its directory structure. We move to
> > the newer register_sysctl call and remove the pointer madness.
>=20
> Nice! Thanks for doing this and unwinding the sysctl use case which
> takes the cake for the obfuscation use case of sysctls.
Indeed. They were being very creative :)

>=20
> > I have separated the parport into 5 patches to clarify the different
> > changes needed for the 3 calls to register_sysctl_paths. I can squash
> > them together if need be.
>=20
> I think it makes sense to keep them that way.
Fine by me :).

>=20
> > We no longer export the register_sysctl_table call as parport was the
> > last user from outside proc_sysctl.c. Also modified documentation sligh=
tly
> > so register_sysctl_table is no longer mentioned.
>=20
> We can go further, but I'll explain in patch review on the patches.
ok

>=20
> > I'm waiting on the 0-day tests results.
>=20
> Nice!
>=20
>   Luis

--=20

Joel Granados

--z4i2cvxpia5dzh6m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmRjjfAACgkQupfNUreW
QU/apwwAg1fuMok7nkAiCaY++GdY6b9U/1rpdFHO4ttj+YPS26tqAzR/1s52LbD8
UwuxPXQJN4EHdKb+mleFu4KJpx/LKynzwDcggTEFHvPI3m6+1XFB9rLE76B4lIEl
Qaxj6RgZjl5V8/Bz3ibw1ITe+zFrIhjfa04G8cwMMry7l08cwnun2lYXt3I7Vj9+
yR+TqISb8aIwdDxLlQqXFWjDnxXsiQv49lmc6vrSa1T65cI2GM7gI02m7nP77ZFo
uYt+5yar4PrMWimQB1NjcnG6Kzc0e6HhdAbfATSerkZdqDMK0dIKCEJ00MvTGPIo
EkrF7lP0Og4Piv+FE6g77l53eKyV6Jtcjzu97IOZc9B1S89b1UagTYW3TZJNIjOa
gTSlmOdYuPmMjEYndvhYEp9+ZeGJleUnb4LuFfV5xs4vY5ECuFOVKcmseGXvUg8A
mbV+58JsFiDaovPVcqPdpjoaPrC+/gn8Of0Zg6hUIBrTlkEdmZonH+k5d55AtZrf
CmojlNeQ
=RUEv
-----END PGP SIGNATURE-----

--z4i2cvxpia5dzh6m--