Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230515175042.495377-1-afd@ti.com>
In-Reply-To: <20230515175042.495377-1-afd@ti.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Tue, 16 May 2023 16:46:38 +0200
Message-ID: <CAMRc=MfqJSYbrbS9cuQFdOB4EW-RaYt0qGN_HZEL17hbvWAK_A@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] i2c: davinci: Use platform table macro over module_alias
To:     Andrew Davis <afd@ti.com>
Cc:     Wolfram Sang <wsa@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 15, 2023 at 7:50=E2=80=AFPM Andrew Davis <afd@ti.com> wrote:
>
> Generates the same platform module alias. More standard usage.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  drivers/i2c/busses/i2c-davinci.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-da=
vinci.c
> index 9750310f2c96..c55bd937def7 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -940,12 +940,16 @@ static const struct dev_pm_ops davinci_i2c_pm =3D {
>  #define davinci_i2c_pm_ops NULL
>  #endif
>
> -/* work with hotplug and coldplug */
> -MODULE_ALIAS("platform:i2c_davinci");
> +static const struct platform_device_id davinci_i2c_driver_ids[] =3D {
> +       { .name =3D "i2c_davinci", },
> +       { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(platform, davinci_i2c_driver_ids);
>
>  static struct platform_driver davinci_i2c_driver =3D {
>         .probe          =3D davinci_i2c_probe,
>         .remove         =3D davinci_i2c_remove,
> +       .id_table       =3D davinci_i2c_driver_ids,
>         .driver         =3D {
>                 .name   =3D "i2c_davinci",
>                 .pm     =3D davinci_i2c_pm_ops,
> --
> 2.39.2
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>