Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <44a19ea6-a7e3-51bb-6631-b7514ef88219@ti.com>
Date:   Tue, 16 May 2023 10:24:11 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to simplify
 remove path
Content-Language: en-US
To:     <andy.shevchenko@gmail.com>
CC:     Peter Tyser <ptyser@xes-inc.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230515174321.494714-1-afd@ti.com>
 <ZGJ7POc8Qm9pE_WZ@surfacebook>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <ZGJ7POc8Qm9pE_WZ@surfacebook>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/15/23 1:34 PM, andy.shevchenko@gmail.com wrote:
> Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti:
>> Use devm version of gpiochip add function to handle removal for us.
>>
>> While here update copyright and module author.
> 
> ...
> 
>> +static void pisosr_mutex_destroy(void *data)
>> +{
>> +	struct mutex *lock = data;
>> +
>> +	mutex_destroy(lock);
>> +}
> 
> No need to cast void * explicitly.
> 

No need sure, but I really think it looks cleaner to be
explicit with the types here. If you feel strongly I
can change it though.

Andrew

> static void pisosr_mutex_destroy(void *lock)
> {
> 	mutex_destroy(lock);
> }
>