Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764083AbXJEVW1 (ORCPT ); Fri, 5 Oct 2007 17:22:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755890AbXJEVWR (ORCPT ); Fri, 5 Oct 2007 17:22:17 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:35013 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbXJEVWQ (ORCPT ); Fri, 5 Oct 2007 17:22:16 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Kok, Auke" Cc: maximilian attems , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH Subject: Re: e1000e oops, sysfs related? References: <20071005131115.GA31453@stro.at> <47066838.7030209@intel.com> Date: Fri, 05 Oct 2007 15:21:41 -0600 In-Reply-To: <47066838.7030209@intel.com> (Auke Kok's message of "Fri, 05 Oct 2007 09:37:12 -0700") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2577 Lines: 66 "Kok, Auke" writes: > maximilian attems wrote: >> Linux tau 2.6.23-rc8-mm2-686 #1 SMP Wed Oct 3 23:56:32 CEST 2007 i686 >> GNU/Linux >> >> eth0 renamed to eth1 >> sysfs: duplicate filename 'eth1' can not be created >> WARNING: at fs/sysfs/dir.c:433 sysfs_add_one() >> [] dump_trace+0x68/0x1d5 >> [] show_trace_log_lvl+0x18/0x2c >> [] show_trace+0xf/0x11 >> [] dump_stack+0x12/0x14 >> [] sysfs_add_one+0x54/0xb8 >> [] sysfs_create_link+0xb3/0x125 >> [] device_rename+0x13d/0x196 >> [] dev_change_name+0x137/0x205 >> [] dev_ioctl+0x357/0x44f >> [] do_ioctl+0x1f/0x62 >> [] vfs_ioctl+0x237/0x249 >> [] sys_ioctl+0x45/0x5d >> [] syscall_call+0x7/0xb >> [] 0xb7edbde4 >> ======================= >> net eth1: device_rename: sysfs_create_symlink failed (-17) >> > I'm seeing the same when removing/inserting network drivers frequently, ixgbe > does > the same thing: (git://davem/net-2.6.24) > > ixgbe 0000:01:00.0: (PCI Express:2.5Gb/s:Width x8) 00:1a:64:3b:81:c3 > ixgbe 0000:01:00.0: MAC: 0, PHY: 0, PBA No: d95854-003 > ixgbe 0000:01:00.0: Intel(R) 10 Gigabit Network Connection > net eth2: device_rename: sysfs_create_symlink failed (-17) > > but I can't make it throw a stack trace. > > perhaps one of the sysfs knowledgeable people can take a look at this. We might > be > doing something wrong in e1000e / ixgbe at setup time, but I have no idea what. To reach this path you need to run the equivalent of: ip link set eth0 name eth1 I have seen this a bit and my memory is that the error is generally harmless. It is trying to create a symlink with the same name as the directory or something like that. Which makes with one setting of CONFIG_SYSFS_DEPRECATED but not the other. So I don't believe this is a driver bug, and I suspect the renames come from using something like /etc/mactab which forces ethernet devices with specific mac addresses to specific ethernet device names. With whatever is sitting in my development tree I'm pretty certain this error isn't present. I don't recall if I did anything specific to fix this though. In particular I don't recall if this still happens with gregkh's queued sysfs patches applied. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/