Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e544dc5d-1117-ef72-91ed-4a98b00dca13@amd.com>
Date:   Tue, 16 May 2023 11:50:22 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 3/9] ASoC: amd: ps: add soundwire dma driver
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        --to=broonie@kernel.org
Cc:     alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Mastan.Katragadda@amd.com,
        Arungopal.kondaveeti@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20230516103543.2515097-1-Vijendar.Mukunda@amd.com>
 <20230516103543.2515097-4-Vijendar.Mukunda@amd.com>
 <b8ad1f03-686a-7f2f-baea-b63b12c19df9@linux.intel.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mlimonci@amd.com>
In-Reply-To: <b8ad1f03-686a-7f2f-baea-b63b12c19df9@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUJSSXNuSzJWRWU5ZFNnZEVvaC9WblVUK3RkM0VLbjFyUVZSWWtzek91eG5C?=
 =?utf-8?B?N3NJZDd4ZDVVOFE4V0xONHBXaWVpRkh2NzI2V1YydHVTMUJJbVcxYis1SkVm?=
 =?utf-8?B?dms3TDdCbEZpRGxaQzRyYUtSZmhTcTlBb3BjREdsUVBKMHRXcHY1aVNjVDhN?=
 =?utf-8?B?Sm9IZWpJR3VSVkcxWG5LZzJFM05UYXhPM1ZZMkRGRXFFMkRwV3h5cVRWdkJr?=
 =?utf-8?B?N2JGdVpoMzJlbVNjbFdYRlplc040NWY3QlA5RGo1Z05WQTc0bG4zUkcrcTIv?=
 =?utf-8?B?TGlEeW9Fd2VYUHE3OXNmNVJDTG5FdWVJSlAxVFdUZ3JPQ2IrUzBQWHNUek5H?=
 =?utf-8?B?YXREenRWTjZlREtNblF5ZHJuUEQ1MS84blRTZG1MWFk2dGdNek9lOGhNVU5h?=
 =?utf-8?B?YWJRQzBRMTdFZkVydEFXZHo4bmhBWVNadm5oVCtJYXZVZEpTdHc4ZFdZZ0kv?=
 =?utf-8?B?aWJqMGZ1MTFma2JhdkNnYlYxU3M1bFNKSFRlOGxrQU9tLzY0a3k5R1RaRFU4?=
 =?utf-8?B?Sk52bVhpZmNLb0V4VVk3QVcrZ0k3ckxlUTZid2ZmcE01RWhLNXl0MTEyU1pl?=
 =?utf-8?B?TWFwY1MyVGkvK28rZnpWbW9HSURvekpuRlI4UFJiamw5VWtpV2wxb3BRSlRw?=
 =?utf-8?B?K0hjZU5zTWdmRXNSbTdpSG9xbTZqK3o0WFFZYVRPM1o5eUE1cmpBYmRvdXlo?=
 =?utf-8?B?RWlxdDhMTFBTT0RYWkE0bFc4RGRMeGdBYi9GdjFueGxSd0ZYNjBHclVVRFRl?=
 =?utf-8?B?clZjZjNNaUh4TkJhZDJWbWpUVHJQNEFBb3JpYlp1bWRkWmoycmRiTGd5UFBE?=
 =?utf-8?B?VWNnU0o2V1A3QksybHZENjBlNDhSRGljaWh1UkZpdDAzTWR4MTRqbHI5UUtO?=
 =?utf-8?B?UmdCV0N6ZkgrcnZsa0pORXM3aHpIenVKUEh1RFB3TzZ5K25RV09EYWtobGRz?=
 =?utf-8?B?UlVnMXhBR3kyRkhZQ2lnbTV4ZncwL2ZIRDA3TG5oMytaOURIc1NvUWQ0bC9Y?=
 =?utf-8?B?ZG10YjZTRUo4VWFTdytGMDYvT1Z6NnVCL0w4N0hiUWs1eEZhZGc3K2lGb0Zi?=
 =?utf-8?B?TGJvUnMrZHBnbXhQSXFYKzlLNDhHZXFscS9vdDJacjhSbFZxY1Blb3M2bGV4?=
 =?utf-8?B?eUZYUUJsSlJINS9WRjlpbFZEckx5U2c1eGh1eFRjbjJhRW14NWNYSzRzNzR4?=
 =?utf-8?B?bzR2S01KQWkzR0hoMGs5Q2JXTHROb3JCcmxLSmdhUzJ6RitBdnd2enRUVGJh?=
 =?utf-8?B?SzZCcThlQUFPZnE0QjVqWHN2MzVteWZIcDE4TmlQUHNLMUdHdnZLRWVqTTZ4?=
 =?utf-8?B?SGdDSWdNKzROek9ycU1EemkxNElCVmhLZjVHR2FWZUpNeWpBWnZ4LzlyMGZR?=
 =?utf-8?B?L1dkZzdZb3dTcERmUm42RDhKUHBBNzJsSzJXNDJnRkFCRkhKU0J6MFBsOFlz?=
 =?utf-8?B?ajZPV2NUTHF2a0FKU1FoY21INnc5cTU0Z05sTkNyRFNGZzVrUUUvVW1ZZmQ0?=
 =?utf-8?B?eXl5cVVjSG9OdXlrdnQvY0RDNkR6eXRodjgyckY4dVRTVEZldWk4T0Nlc1RI?=
 =?utf-8?B?ZnhQMW42TmtFL0lqTlNPY2NqMEVtUEc2clFNU2Z4L1Y5aEp4U3NnajdkY09V?=
 =?utf-8?B?Y1lqd09uQS8xQThVOE9oL2ljdkljYkJVMU9GYlNPemRSaHRiOE1nZWVQVjYz?=
 =?utf-8?B?NWRHanQ0dDYyS2xzdDdITzZVaXlhRDhNTW9pdVlmMHFyK1Ivd2F6bnIvb1NV?=
 =?utf-8?B?QzV4WWJVVXJoNFBpS3l4WmhoaVoyMGFHeExmQVllUHJudGZTVnUzejdJaExL?=
 =?utf-8?B?cDFwbk1JL0ZUNGQwbTE4a0Q1Z2IxS0RFS2lITEUzSVdsN1VwOHNjMmVoNjFN?=
 =?utf-8?B?QkcrR0xleUJGaUlBazZCa1IwME4zRkF2b084RnBFN3pDRXU3bTc4Z2RkbEdW?=
 =?utf-8?B?SWozZDNJSUl6NmR3MG5pTFo4SlBzbDMrOWxUQzM4ZmdOTmxmWXVFRk5iKzhE?=
 =?utf-8?B?OGpzTnJDd2NVWFJkNUdBa0s3d3pjKzEwd0ZpNFE3eUVkeWllSStHMkh5Sy9s?=
 =?utf-8?B?T1czcE9uQzB1bHdhdWM5eERNLzZNY05rOGtMZVVWUGZCbkFDTkZHQ1I3Nkdj?=
 =?utf-8?Q?hjtoCwdTHc/WWhbdx46ropFc3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 127d3bf6-99ce-4652-2ff6-08db562da58e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 16:50:25.6255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pbPqcj+aFe82HLjab2olNAcguF1+Om8LJ/7HpE5SByCPLl438UA0XKRDJRKAqvBLslDD52xGbatFvK+X0TQPXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9222
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/16/2023 9:40 AM, Pierre-Louis Bossart wrote:
>
> On 5/16/23 05:35, Vijendar Mukunda wrote:
>> Soundwire DMA platform driver binds to the platform device created by
>> ACP PCI device. Soundwire DMA driver registers ALSA DMA component
>> with ASoC framework.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>>   sound/soc/amd/ps/acp63.h      |  5 +++
>>   sound/soc/amd/ps/ps-sdw-dma.c | 71 +++++++++++++++++++++++++++++++++++
>>   2 files changed, 76 insertions(+)
>>   create mode 100644 sound/soc/amd/ps/ps-sdw-dma.c
>>
>> diff --git a/sound/soc/amd/ps/acp63.h b/sound/soc/amd/ps/acp63.h
>> index faf7be4d77c2..f86c60cd1565 100644
>> --- a/sound/soc/amd/ps/acp63.h
>> +++ b/sound/soc/amd/ps/acp63.h
>> @@ -111,6 +111,11 @@ struct pdm_dev_data {
>>   	struct snd_pcm_substream *capture_stream;
>>   };
>>   
>> +struct sdw_dma_dev_data {
>> +	void __iomem *acp_base;
>> +	struct mutex *acp_lock; /* used to protect acp common register access */
>> +};
>> +
>>   /**
>>    * struct acp63_dev_data - acp pci driver context
>>    * @acp63_base: acp mmio base
>> diff --git a/sound/soc/amd/ps/ps-sdw-dma.c b/sound/soc/amd/ps/ps-sdw-dma.c
>> new file mode 100644
>> index 000000000000..0d0889842413
>> --- /dev/null
>> +++ b/sound/soc/amd/ps/ps-sdw-dma.c
>> @@ -0,0 +1,71 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * AMD ALSA SoC Pink Sardine Soundwire DMA Driver
>> + *
>> + * Copyright 2023 Advanced Micro Devices, Inc.
>> + */
>> +
>> +#include <linux/err.h>
>> +#include <linux/io.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <sound/pcm_params.h>
>> +#include <sound/soc.h>
>> +#include <sound/soc-dai.h>
>> +#include "acp63.h"
>> +
>> +#define DRV_NAME "amd_ps_sdw_dma"
>> +
>> +static const struct snd_soc_component_driver acp63_sdw_component = {
>> +	.name		= DRV_NAME,
>> +};
>> +
>> +static int acp63_sdw_platform_probe(struct platform_device *pdev)
>> +{
>> +	struct resource *res;
>> +	struct sdw_dma_dev_data *sdw_data;
>> +	int status;
>> +
>> +	if (!pdev->dev.platform_data) {
>> +		dev_err(&pdev->dev, "platform_data not retrieved\n");
>> +		return -ENODEV;
>> +	}
>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +	if (!res) {
>> +		dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
>> +		return -ENODEV;
>> +	}
>> +
>> +	sdw_data = devm_kzalloc(&pdev->dev, sizeof(*sdw_data), GFP_KERNEL);
>> +	if (!sdw_data)
>> +		return -ENOMEM;
>> +
>> +	sdw_data->acp_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
>> +	if (!sdw_data->acp_base)
>> +		return -ENOMEM;
>> +
>> +	sdw_data->acp_lock = pdev->dev.platform_data;
>> +	dev_set_drvdata(&pdev->dev, sdw_data);
>> +	status = devm_snd_soc_register_component(&pdev->dev,
>> +						 &acp63_sdw_component,
>> +						 NULL, 0);
>> +	if (status) {
>> +		dev_err(&pdev->dev, "Fail to register sdw dma component\n");
>> +		return -ENODEV;
> return status;

Remove the other return 0 too.

IE:

if (status)

     dev_err(...)

return status;

>
>> +	}
>> +	return 0;
>> +}
>> +
>> +static struct platform_driver acp63_sdw_dma_driver = {
>> +	.probe = acp63_sdw_platform_probe,
>> +	.driver = {
>> +		.name = "amd_ps_sdw_dma",
>> +	},
>> +};
>> +
>> +module_platform_driver(acp63_sdw_dma_driver);
>> +
>> +MODULE_AUTHOR("Vijendar.Mukunda@amd.com");
>> +MODULE_DESCRIPTION("AMD ACP6.3 PS SDW DMA Driver");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:" DRV_NAME);