Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 12:57:54 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     Jeff Xu <jeffxu@chromium.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        linux-hardening@vger.kernel.org,
        Jorge Lucangeli Obes <jorgelo@chromium.org>,
        lstoakes@gmail.com, zhangpeng.00@bytedance.com
Subject: Re: mprotect outbound check.
Message-ID: <20230516165754.pocx4kaagn3yyw3r@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peter Xu <peterx@redhat.com>, Jeff Xu <jeffxu@chromium.org>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, linux-hardening@vger.kernel.org,
        Jorge Lucangeli Obes <jorgelo@chromium.org>, lstoakes@gmail.com,
        zhangpeng.00@bytedance.com
References: <CABi2SkXjN+5iFoBhxk71t3cmunTk-s=rB4T7qo0UQRh17s49PQ@mail.gmail.com>
 <CABi2SkUfsOWKGdFqgXZg=0AcnUj=AOFb9JmYfp=RwDp_5AcH0Q@mail.gmail.com>
 <ZGOworXBstm+jmw3@x1n>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ZGOworXBstm+jmw3@x1n>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S094UTR1SnE0OXM3NFZBaUpVYlJXZlF2dUV5NjRsbjBTUkdHdmg1VEUwcG1I?=
 =?utf-8?B?RFRRVFlUU2dnTFlHanY5WjFXOEZSNWJZRHJoWFpaWmlZd0pGdTE5eDE3MWla?=
 =?utf-8?B?SEJQTmljQzNFbmlUaEhyZ0ppWURESXZyWjhWOHZFZnJYQmUzbnh3aHBjcm1n?=
 =?utf-8?B?ZWJaL3VQZ3QxRW9Ba3V4WHM3OHlZaklVQXZJQ01vRzFwSjRpRm1CUGJ3ZURS?=
 =?utf-8?B?RHFqUXg1L2ZHNlV0Z3Q2RFRjS2dSN09RbmFBZ05wTXB0TG1KV0VLdnp0U1lW?=
 =?utf-8?B?S2VLaEZXRHlOYXRKY0xqZy9qajJWb0lVNko4RlhEMGg0N1VhbkxUQUlBbDNn?=
 =?utf-8?B?YTA3SDhXYU5IdE5uTjJFNXh4M095VGJIUzZ0UTB6VVhZSi9aTEZzREJlUEt6?=
 =?utf-8?B?by8zOUZLL3JQdm01NFhEUGFRdzZXaEl6SndqZURqakFaaE12TWNDM3BaZHoz?=
 =?utf-8?B?SnRrdmQra0pIS0p3ZndGQjRUdityck9XbTFNd2lhSFlTMEJDVGZWZ016UUsy?=
 =?utf-8?B?NDBXeUF3WmFRN3FPeVVZRWtQT3JGWjFqVUhScXc3Uk02cWxQRDhkWG1WUjU4?=
 =?utf-8?B?VENScVpxWVNiZFpseEc4cWZwMXBZaGlRVjE4aHd6YnBFd21kTS8vQjgvNjNY?=
 =?utf-8?B?YTFaNjRXbkJjRkNKVlFnV1pDenkrMTB1WktudDlzanB0TTdMR25qV3doNWd2?=
 =?utf-8?B?T1dKVmxSTlk5cUJkVjlUTHBKMVNBcmRPQURMdGt3a21BNTJySkpadUpkbWJR?=
 =?utf-8?B?U0hUUkg2VTFKNFhSZG9QNzZqS2h2c0pUa1lGOU1xVDJNQUtvcnBnVzFKbUxE?=
 =?utf-8?B?eExGbFJTNytQL2RrU3BUR2IzNmFjdUxlcDBQQ29pZWluMlRQYnFjTUQ5RzV0?=
 =?utf-8?B?YUFqSGtYMHVaVCtTQ21ZRVQ1ZFZhMnJQSEhCcTFSdHZBaGdJbzhsb013aTln?=
 =?utf-8?B?TmF3VmdEbU5FK1VhcEEvQ0lpYXRNYWU1Q2dQRXdXd3VSaG0xY0R5ZXF3dzdt?=
 =?utf-8?B?RFNyTnhGaTgwZVdVaHFjZ2MxNVVjNWl6OGtLQVV5SkkrQWE1cllZajhaN1Zt?=
 =?utf-8?B?UGZjWVlZZGRRNkZlVEdZQncyL0pSSW5xd3B6YUIyU29DeGxORWFIOHhKRERM?=
 =?utf-8?B?aGlqVnR4RGszQXNKZWxtNm1RWUlsZnBrU0twdEpNSVdwSVJNaTJBbFVLb1d5?=
 =?utf-8?B?anhmR2NGOFdGcWlSYmU5N3lPUWdlQzdvazhTNElwNXF6Y1RRR1Z4eGlYbkgx?=
 =?utf-8?B?SHRkRVdXK3UwSzluMjJtL25JNmlsaFJPeXFnbHhnTXZIdDc3Q0cyVnpSS28w?=
 =?utf-8?B?STZBd241VDlacTZsaTdWcmc3QTcyTTBidDlsckcvcXlXRllpS2Z6TUdqb0pZ?=
 =?utf-8?B?ZEhyR1RZTUxYV2lHam5qWGlDeDIyc01HRks1dDhlTHgzbEx6OFhSUFp3bkhY?=
 =?utf-8?B?bjVNVzZZbDRaM0Yxc3I4TmpoWjUwc2Q0VzdyWktlWmVrNi9VTE1TWnpxQngx?=
 =?utf-8?B?Ulg2U0Z0NjZacjZEeWVLbWJKZm42TU5xTS9MWTIxQmdxbVptTHFMa3g3aEpT?=
 =?utf-8?B?cFRTK005MUZ6Tm5mc3BhV2gxT29Benl2a2crZWxIMm1OcmVIYlE3WFJxaEpx?=
 =?utf-8?B?bXZ5aFFoVGR3UzYveHVOcGs4cHZnbWF4RGpWVmhkZ3p3RjAyRjJZSHN3cVln?=
 =?utf-8?B?U3RHVHIyUHZ5amtwcmpzWkhtWnlQR20xOEQrL05FQk9vUVpEQmZBTHB2MzVn?=
 =?utf-8?B?ZDk1Z1RYZlRNNUhLSi84Y3VBUGpyWGxzNmM3TEJrdnZSUnBhdFROZndyUjhv?=
 =?utf-8?B?ZXFaVjgrbzNUbFJMb3dDcjBiRjEvSWNjUFVVazhLUGhhclhwU0RtVXJXODFl?=
 =?utf-8?B?U1JJME0rNmw1VFZhaDMyV3h2Yis1RUw0RnpHTm5zblRhVXFrak9seGdXc2JN?=
 =?utf-8?B?UWNSeE9nRzhDY1dLcmhxZkl1c3hMS1hNZWdiaDRvR1JFeVhtVFRHN1pZNVJi?=
 =?utf-8?B?cURwL21jTUJjYWZ4cFgrQ3ROd1ZVS1Iwc2ZPWjdvNlNoQkJORmhvSmVSelh5?=
 =?utf-8?B?NjlGV09VOWJ1RTJUYm4ydmFaMTBwTlNWa0w0ZVFPV2xnUFlEYk42MUtkTith?=
 =?utf-8?B?YklVUVBlVmZ6MDJJd1QyY0Y1eU1QdXlXVGZKOXV4dnA3WVFMTG91OHFrcGlS?=
 =?utf-8?B?YVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MUIvQWE2bE1xOTNSRjU3SjJmb21SQWFEMXN0a29zVHZFaWxwTE5xbERESDVO?=
 =?utf-8?B?bmQ2alYzVW1TNXgvYThnWVExUjdRY0hxZTlHd2drdVB4aFYzWVJwRWVOU24w?=
 =?utf-8?B?WnRuTDBHUW5KUlc5UFVxclNyS3RDM3hUZ1pyZVFZbytrV3FrcTE5NVFzc1Jn?=
 =?utf-8?B?L2N5WmdmY2ovZTgyNDdDaDd3Q2dNWEVHK2ZMSHhUV0YwTk1ZcS9sSGQzNEsx?=
 =?utf-8?B?ZGswc1JuSENmbEtOUjlHVTNrRGtVSGhtL1NqbFNLWStkQllvUitIRW5FR0VZ?=
 =?utf-8?B?Q3pQUTBCYkRGV3ZZVW8weTlQb1ROODVSVzNKQXF4amFzNjFJSXBTOWhKaFlK?=
 =?utf-8?B?SmhiNHFCTUhOTjBlcTRNTjRMcjNjdXp0MnNlV2JGd0JjT1Mzc1UzY0xaeUdV?=
 =?utf-8?B?MVNhVW5DWmtjc1h4bWdzL2JSQnQwR1dRWDcyVEhNdmZSQnk1L3g5NXhGZWE3?=
 =?utf-8?B?UkdUSnhoU0lHVDdQbFRUaG5WWUEyWmU3RWo3RUp6bkJRQW0zNy80QWNYaDAv?=
 =?utf-8?B?c2VYR2EvWG11cVdGMHpsL3VNQkx4NFgzZGV2TkRHc0x4K05ZdENNQ2dnSzdG?=
 =?utf-8?B?QzlYeDBOVXlQSEFhMStpQ1Z2cmZySXg5VWs0cTJSUjU5UTJYVm9RKzl0cGs0?=
 =?utf-8?B?YnBGRnQzdDJzT2ExNzhEazBNZXNRYlFaYkExS0lYVjZ3QzE3OGtFTjh1Uy91?=
 =?utf-8?B?WlJIMk1taWFMRkpiOGp1akluNVdKOVd4MDk2SGYrN1oxeUxLaGh3NDB4YXkx?=
 =?utf-8?B?TG8yZGFVOGhPdGJ0bGVOcmNrT3V5SWN5a2xRVXVEYXBRa0NiYTJTQmUxOVRs?=
 =?utf-8?B?OE9Id2VkNEsvR0tBdG9YVWh0QU1MRHNBQmtDU3hYK00wbjdmcXEveDlTNXZE?=
 =?utf-8?B?b2FoeTJlYUdub25oRmZva1RaWDBYeXd6YlhDTDFuQ3RTdGdYaEdyaHBaZDR3?=
 =?utf-8?B?RlQzbk9HMFFRVHd0Y090VjNVZUlwUXlUcHpaQ3kzRkFWeEt5YWNKaUR1Y2Y3?=
 =?utf-8?B?SXdmcUhsTHZEbEdiMUwrT3FPUlg3U2NEMnppYU9zbUlDU0NNNytkOFFKaXMx?=
 =?utf-8?B?V1Q2ZG9TSUpETTJBUGg2U3ZIYmprWDZWam9kMFMwemRjUkhVL0FTYXlMUGcr?=
 =?utf-8?B?S0JXR0gvV2pGbTA1L1N0Z2orQStna3JrdTZsTDZxTkxJamsraWF1U01Cd25T?=
 =?utf-8?B?R3R2L3V2NWIzZ3Y3MTQ4QStCdGFCSTZaa0JlTVp0ZS9zS3hvTlpUcituaE1n?=
 =?utf-8?B?NzduYkVXZHhaREhwOFVKS0Z5VXJ4SDZmWDZTZk9SeVpDd1Ridz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ce41290-f552-4a71-3109-08db562eb329
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 16:57:57.8454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JWWr4FdLqYyxCK80V/zd/DNxjtTsx2Ffq/irLl0R7PIvKf4fxFIS6YFdGe0B6TXxptDefrXF7iclFjLy50Yrjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6313
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-16_09,2023-05-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=700 spamscore=0
 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305160144
X-Proofpoint-GUID: mfhllBBJ8tDhINlsNoSEHdp-wI1xBNoo
X-Proofpoint-ORIG-GUID: mfhllBBJ8tDhINlsNoSEHdp-wI1xBNoo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peter Xu <peterx@redhat.com> [230516 12:35]:
> On Mon, May 15, 2023 at 06:41:35PM -0700, Jeff Xu wrote:
> > + Peter, Lian, Lorenzo
> >=20
> > Is this related to this hotfix ?
> >       mm/mprotect: fix do_mprotect_pkey() return on error
>=20
> Doesn't look like to me, that seems to only avoid replacing an error with
> another error, rather than stop returning error for any case.
>=20
> AFAIU this shouldn't be intentional, but Liam could correct.  Maybe a
> bisection would show at least when it got changed?

I did not intentionally modify the return of mprotect for this case.  As
Peter said, that change shouldn't cause the change in behaviour you are
seeing.

A bisection would help narrow it down, as it could be changes to mm/mmap
vma_merge() and friends.

Thanks,
Liam

>=20
> >=20
> >=20
> > Thanks!
> >=20
> > -Jeff
> >=20
> >=20
> >=20
> >=20
> >=20
> >=20
> > On Mon, May 15, 2023 at 11:00=E2=80=AFAM Jeff Xu <jeffxu@chromium.org> =
wrote:
> > >
> > > Noticed there is a slight change for mprotect between 6.1 and 6.4 RC1
> > >
> > > For example:
> > > Consider the case below:
> > > 1 mmap(0x5000000, PAGE_SIZE,  ...)
> > > 2 mprotect(0x5000000, PAGE_SIZE*4, ...)
> > >
> > > in 6.1 and before, 2 will fail, and in 6.4 RC1, it will pass.
> > >
> > > I know that munmap will accept out-of-bound cases like this (because
> > > memory is freed anyway).
> > >
> > > Is this change intentional ?
> > >
> > > Thanks!
> > > Best regards,
> > > -Jeff
> >=20
>=20
> --=20
> Peter Xu
>=20
>=20