Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 23:14:25 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Tom Rix <trix@redhat.com>
Cc:     peter.ujfalusi@gmail.com, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma: define udma_pm_resume,suspend
 with CONFIG_PM_SLEEP
Message-ID: <ZGPA+V5WqZItfp74@matsya>
References: <20230501025647.2905317-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230501025647.2905317-1-trix@redhat.com>
Precedence: bulk

On 30-04-23, 22:56, Tom Rix wrote:
> gcc reports
> drivers/dma/ti/k3-udma.c:5552:12: error: ‘udma_pm_resume’
>   defined but not used [-Werror=unused-function]
>  5552 | static int udma_pm_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~
> drivers/dma/ti/k3-udma.c:5530:12: error: ‘udma_pm_suspend’
>   defined but not used [-Werror=unused-function]
>  5530 | static int udma_pm_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~
> 
> These functions are used conditionally with CONFIG_PM_SLEEP,
> so they should be likewise defined.

A better way would be to use __maybe_unused. I have sent a patch with
that change

> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/dma/ti/k3-udma.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index fc3a2a05ab7b..f189b0f2e423 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -5527,6 +5527,7 @@ static int udma_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> +#ifdef CONFIG_PM_SLEEP
>  static int udma_pm_suspend(struct device *dev)
>  {
>  	struct udma_dev *ud = dev_get_drvdata(dev);
> @@ -5573,6 +5574,7 @@ static int udma_pm_resume(struct device *dev)
>  
>  	return 0;
>  }
> +#endif
>  
>  static const struct dev_pm_ops udma_pm_ops = {
>  	SET_LATE_SYSTEM_SLEEP_PM_OPS(udma_pm_suspend, udma_pm_resume)
> -- 
> 2.27.0

-- 
~Vinod