Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 19:06:35 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Sean Nyekjaer <sean@geanix.com>
Cc:     robh+dt@kernel.org, Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        pascal Paillet <p.paillet@foss.st.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff
 property
Message-ID: <20230516-footprint-handoff-bcd553ff6146@spud>
References: <20230516132225.3012541-1-sean@geanix.com>
 <20230516132225.3012541-3-sean@geanix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="rd5ceYlXksEiZAx+"
Content-Disposition: inline
In-Reply-To: <20230516132225.3012541-3-sean@geanix.com>
Precedence: bulk


--rd5ceYlXksEiZAx+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Sean,

On Tue, May 16, 2023 at 03:22:24PM +0200, Sean Nyekjaer wrote:
> Document the new optional "fsl,pmic-poweroff" property.
>=20
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Docu=
mentation/devicetree/bindings/mfd/st,stpmic1.yaml
> index 9573e4af949e..5183a7c660d2 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> @@ -26,6 +26,14 @@ properties:
> =20
>    interrupt-controller: true
> =20
> +  st,pmic-poweroff:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |
> +      if present, configure the PMIC to shutdown all power rails when
> +      power off sequence have finished.
> +      Use this option if the SoC should be powered off by external power=
 management
> +      IC (PMIC).

Just reading this description, this is sounding quite like a "software
behaviour" type of property, which are not permitted, rather than
describing some element of the hardware. Clearly you are trying to solve
an actual problem though, so try re-phrasing the description (and
property name) to focus on what exact hardware configuration it is that
you are trying to special-case.
Krzysztof suggested that the samsung,s2mps11-acokb-ground property in
samsung,s2mps11.yaml is addressing a similar problem, so that could be
good to look at.

Also, the dt-binding patch should go before the patch adding the
property to the driver.

Thanks,
Conor.

--rd5ceYlXksEiZAx+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGPGKwAKCRB4tDGHoIJi
0ttYAP4vmjFXsrbhAGKA/cInxDWCIs7qIGH8rMylmv4NU7JE/QD+JKoAFQtxI767
s7vlXlr+/HE9UNGBhgpC3D2EEqFYewE=
=1soC
-----END PGP SIGNATURE-----

--rd5ceYlXksEiZAx+--