Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ace6ad64-75a9-716a-8845-9a2c92820dda@intel.com>
Date:   Tue, 16 May 2023 12:04:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v2] x86/resctrl: Only show tasks' pid in current pid
 namespace
Content-Language: en-US
To:     Shawn Wang <shawnwang@linux.alibaba.com>,
        <reinette.chatre@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>
References: <20230515060448.50446-1-shawnwang@linux.alibaba.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230515060448.50446-1-shawnwang@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVlYSzVub0hGMTBsdElFUTdreTV5QzJjcmtXWlJrVnFsOUMvaXVrU3VMVkM5?=
 =?utf-8?B?SVVmcEpxQ0xnT3dQUDVpamVxSVVRSi9nVDM2eVQ2emNpSkw2TXgxNnQvWUtx?=
 =?utf-8?B?Qy9WTlR5T0s1VU5sQXIxRllySHhXamV2NG9KcDZtUGszS3ZDb0t4cUtUckFr?=
 =?utf-8?B?SmlxVmFEeFZ3QnhLYndmYzJ6L3FIMWFPcGJzc0hBYmhTdVNOOGxJQlR6bUxI?=
 =?utf-8?B?V0JWTjhiOUhzZnVORWFXOVptSFNGLzRiblFMTG1XSno3azNYRER2dHJrRE91?=
 =?utf-8?B?UXdvSXNMVmhFYkdDL0llWnM4K0p0aTFyZUZ0aDQ3U0F4TjBSSEJHdXlqejVJ?=
 =?utf-8?B?bkR0WW1YUlUwWkdZR21hbVV5SG9QVFg3STNYWVJnT1QyR3YyMHJMK1hLSFla?=
 =?utf-8?B?dEZmSVZ1THJmLzZ2d0hkOGFaVUZlRmRkU3JBOWMvRU1xOVpYVnN3R2NKbUdW?=
 =?utf-8?B?T3pYRmpqbkdETW4vWHBBaUhFdmRmZzdvNEtody9SYkhaa25nRzFCSE1ybEdr?=
 =?utf-8?B?ZCtOa1d4SS81K1RyRk80Z3p3ek9Vb3FrNU9wQzBvRThGNklqZW5JbnBpL1Ni?=
 =?utf-8?B?anAyMVN0SEZvck1DUWd1eitucXVTSHJ5bnZDdklqdzJaQU84dW5LczRqRDhp?=
 =?utf-8?B?NVlrVi9INTdtUHIrLzVxOUlUUW5FK1FvS1BiV2FGNFRqY09vSDVHa01PMjEr?=
 =?utf-8?B?eW9NZVJlWnNjbXZnOU1DVmFZdEsybkF1Z1R1eTYxQUVmRm1YR0VSbmp3Y0pq?=
 =?utf-8?B?ME05Z0JmT3lrcTd3SEZWZDhsaE1kMVFCRmpOTTFEUXl0S0lydW5YSnpKVGor?=
 =?utf-8?B?VThMZnRVQ0JqNkpNcy9MRWFSM3hhZ1pWTXpuaUhKQ01EQmdGb01aZml0cEtZ?=
 =?utf-8?B?N0ozM21UNlM1VTZUZVdpLzdzNFg5U3RBV2JEamZFMWd2UlpMcWJqZnNkSkxB?=
 =?utf-8?B?QTRzTG9ncHBQWUNMczJHbm9qRy80MVJzWnZqaVNmcTRUN0xFc2ZvT1d6V2d6?=
 =?utf-8?B?ZjZoOEw5bG9iKzdwYlZ5WG1xNndjZzRleVpoNDdhSzhxREM5N2Q1eTBsaEsv?=
 =?utf-8?B?OEJmL3lIRzZIZHA2a1hyV0ZZeGo5Z2JIeW5BZVJqcFpkdW45VDdvNXR6bm12?=
 =?utf-8?B?Y1hoUy95ejk3U1JGMXRmRGMwWkJadEIwYVVlWUJiL3hkOWtCQm1CT2l5MEFr?=
 =?utf-8?B?MWFLbWJlaElldFdkcCt5RlJtNWgzbHR5ZGpYQjJzMHQ4QnZQNjJtdjFSeVFD?=
 =?utf-8?B?ZGZWem9DVGd6bVBoQklZRkxuQU9GekdoSVY2dmRtc1c0aDJETmcrckl0WmM0?=
 =?utf-8?B?ZXZSRWw1ak1SYTZ3RloramJuWHYwWTRReVhURnNRMjJseStoVGQ2WUYzNXl5?=
 =?utf-8?B?dHM0OGhJQ0lKdWpGVVBFQ1JKZ0NzQ3FQNmMyQy9rR0s3ay9DMXdld3FlTjhM?=
 =?utf-8?B?ODdmL1c3SmZvWlMrZ0ZURVZXeXoyLzZ6VllUcEpwREIzbFh4NkEyTmp5SDln?=
 =?utf-8?B?Ynp2TUtSUTVJaGozNkI4NWhXUHAyVzV2M0MrM1BrYkwwNTBWbm5Rb0ROQTVY?=
 =?utf-8?B?WnNZVWp3TVVFbFl6bXppanRPRnFORStoNDR4WG1TcTRtamhKQkt5bnd0Rmc3?=
 =?utf-8?B?c3lob3JDam1tLzJENEZ3VnVzQS9BUkZiS1Z6UnBjU2hqcXhaSUFUZUQ4NGgz?=
 =?utf-8?B?a3ZCaTUxTmd2dExKRHgveTZabTA1SWN3VHMwUDI4RUpZNUNGK2l3RmVjL3gz?=
 =?utf-8?B?ZzVDMmdNdUtlRHlvbkppUTBWdkhub2I4YjEwMCtHVG9Wc1FxeWVSMXAyNURG?=
 =?utf-8?B?SjF2Tm55RVo1dHdhMlNQUmVNdjh4eHlWNjZJd3lPV1d2ZWpmVmdEL0QwSnl3?=
 =?utf-8?B?ZloxZ24xWXBGWHdGcWVMUW9jb1lmSVZNSlRkTjJOQ0p5SzZTZmZvR1IrYlpN?=
 =?utf-8?B?cXc2ZVNxQ21OVEVjTEZ6WEhOWWVjUnJsdnc2RWRESXJuc0FXcVU2YzJqcGtz?=
 =?utf-8?B?NVVJSUdNN0UyNk5BV3BQYVBPZStNMkJsNE1oc1Z0S3ZVVkJzVGFYVFNiTDdV?=
 =?utf-8?B?Ynh2VG1UdVJVTlRDQ3R4RkF3c29VQ293TER1QmtpOGpERVFTMFBCT3FBajJF?=
 =?utf-8?Q?vHvvHZK1QhDEI06T63K8Vv4gs?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 029c2021-5dde-491d-e5d6-08db56404501
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 19:03:44.1075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2w+3ncdwdQAfFnzTcRZ3T1q/NC83etgUpu0a/JBJufznnnn/YyZ9ZsG/apEPPiybtL4IXzNuFo+je8LNj7tS9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4569
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/14/23 23:04, Shawn Wang wrote:
> When writing a task id to the "tasks" file in an rdtgroup,
> rdtgroup_tasks_write() treats the pid as a number in the current pid
> namespace. But when reading the "tasks" file, rdtgroup_tasks_show() shows
> the list of global pids from the init namespace, which is confusing and
> incorrect.
> 
> To be more robust, let the "tasks" file only show pids in the current pid
> namespace.
> 
> Link: https://lore.kernel.org/all/20230116071246.97717-1-shawnwang@linux.alibaba.com/
> Fixes: e02737d5b826 ("x86/intel_rdt: Add tasks files")
> Signed-off-by: Shawn Wang <shawnwang@linux.alibaba.com>
> Tested-by: Reinette Chatre <reinette.chatre@intel.com>
> Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Acked-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua