Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <bagasdotme@gmail.com>
CC:     <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <saeedm@nvidia.com>, <leon@kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <corbet@lwn.net>, <gal@nvidia.com>, <rrameshbabu@nvidia.com>,
        <msanalla@nvidia.com>, <moshe@nvidia.com>, <tariqt@nvidia.com>,
        <leonro@nvidia.com>
Subject: Re: [PATCH net v2 2/4] Documentation: net/mlx5: Use bullet and
 definition lists for vnic counters description
Thread-Topic: [PATCH net v2 2/4] Documentation: net/mlx5: Use bullet and
 definition lists for vnic counters description
Thread-Index: AQHZgvNeBM0B5kBy/0uDqnMIiNpOuK9dUGkA
Date:   Tue, 16 May 2023 19:18:13 +0000
Message-ID: <ZGPW9BZajS3q33ki@DEN-LT-70577>
References: <20230510035415.16956-1-bagasdotme@gmail.com>
 <20230510035415.16956-3-bagasdotme@gmail.com>
In-Reply-To: <20230510035415.16956-3-bagasdotme@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gIioL5H6Q6aaEZ44O4Q7L4D2SXFSM3TWUqvfIlm1umB8TBqMCGKaWAAcW9TJ?=
 =?us-ascii?Q?BxLE4Zo6sCnMQTJzFjcAPJV4SQRs9GrJ/p+R+YOoLMCSRBSQDnTrqA2De/GO?=
 =?us-ascii?Q?dlUkJOLvIMlgewVmPL/jlr1eAZ9ZsVnIjodzKpjF9FtzeTtRS9T/AaPeVH2W?=
 =?us-ascii?Q?rSqwcTD7iuLzJUrpPe2mL4MIvQby1NYPOb7K1DwohWHccJjhslFmHxJQju5C?=
 =?us-ascii?Q?4a68pmtUUoRa1YwOhs1yANngobY29oHDoZiuhbYddyuNazRAKtT2mLDNyDgF?=
 =?us-ascii?Q?xXGox++vAg2J/Pt68dVvapp9ZFbf4Du1HPMKXcortLZUPEq2SgqO/933g9ZS?=
 =?us-ascii?Q?nKoj4ajnhTZxHBuGIuEaDrOTcVmBPFKZqpS1glO4FkDP4T9sY4/hG7XTo10Z?=
 =?us-ascii?Q?0wGKTphd5s+fXc8FnvcbndHDXZU7n1IG6Fx8Pr+7p93BhBdIGasecssDL5PK?=
 =?us-ascii?Q?xCoeQTNrQnHFf5hjruT1x41ouh2IDxphXmfI5DbqtW4vf3NHTWINk/uCz7tC?=
 =?us-ascii?Q?L9rQaQrz76EdkNQRk2AmeR0G8SX8WSm6EUqnigkUgFcIW0agpqV1j5YDMaIA?=
 =?us-ascii?Q?unbNEysIso84Qh/oKJ4Vq3Rsd9n5z1wcPm644fYERLDhkSImDl0TMmZ9jxOK?=
 =?us-ascii?Q?Xf2O8/5yz2d8gnxX9mVOCOOnwl58sHJM9rb4KLJAqvw0MY1Le9+trff1VZSY?=
 =?us-ascii?Q?PjuXCVckZiMRxDL1RaMRyCbZsEldhQGzCsYwLs29ohOUwvTio6t0Nw8A6KHz?=
 =?us-ascii?Q?3fH+513nODT9tMwQ4lEFR4AUORhSgbQOAWx44f7+Bzd8N7+oFcKxrIX3atNd?=
 =?us-ascii?Q?7bzgfzCE7c0GoQyfIn07euGhlVYhsCxZxg5h4oo8n8HSitqNfy029uPhyu61?=
 =?us-ascii?Q?+AYMsO0zmnkvqySiZPSd2XPlZoaEl3v+eX9tL9bZKMVIR8GudyvQA/niIXGg?=
 =?us-ascii?Q?FWFn9Z3Ud3/8LpfWBL3AvYtZ8VMV6ULmdsFkDbSKhYTJAH3Khy+NrsUuJydn?=
 =?us-ascii?Q?ICI1PXo6+re18Puu9/XKCdX1AtSQ4HJwLVSA0+Ifq4TBu+C8gmkvFlQfgiai?=
 =?us-ascii?Q?ql/6Z8Sy30HuZKds0mSRZOOwLElIl5d7doWSeQ/l5ANco2oYfemdCI0U5/Gu?=
 =?us-ascii?Q?S+CWUeIZ+Ke+WNVY50oN3jk4iM3BptNVUC6ESe+P9+RWateLNLSoc5tQpkJZ?=
 =?us-ascii?Q?cPiq0WxbRS/cNJbI1lB18yzSf8e3Vkmbu64pwap++e1HPI0UoVkcVW9tpEoC?=
 =?us-ascii?Q?6vlK3wf+uNo0ac43bIVm4k6K4c5N0diF7yJDuzDzAeqv3p/FgVveDvkS0mOW?=
 =?us-ascii?Q?XyAKBO0Qdah9D38fWrWBKaCzY2nglUBmKWpwgW+kf6ZdENxK1qGXgskpvttB?=
 =?us-ascii?Q?788nsHYHz3CwA4AxLMMxGfbXRJiOlS1+Uos7iLp/lE3bKRQfdY67Sdq9FHNI?=
 =?us-ascii?Q?YCEle/PbBA/SRNwZ+IEslvvuhf9I/jMeyZyKnwP5dcJFbtOaS4U6Bne4UcRb?=
 =?us-ascii?Q?XBfpEeqSyr2qIBpXftDSd+IyEVcXlYRFN8MpAxb3Ak9bupJ08TjG+lON4aQ0?=
 =?us-ascii?Q?I8RzITHFy6ryI5d2Xq+qSWogWOyPmEcLfeueZxA1QClKfkFHeEf+G+rQwqfz?=
 =?us-ascii?Q?dA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C62D4BF8A6C33B49BDAF921CAD345993@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15ef7bc5-d5f9-4097-6e9f-08db56424b2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 19:18:13.1854
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8ExZX85QLg6OG/jJHPHUOui/a/3pIP1NyIP+CPjMD4u0RaurRWOiYDE/aPEMjEY/CwXXdMe+KaGPnPTiWOdM4r2c1vz2bisb6eh21WZleuw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7076
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  Description of the vnic counters:
> -total_q_under_processor_handle: number of queues in an error state due t=
o
> -an async error or errored command.
> -send_queue_priority_update_flow: number of QP/SQ priority/SL update
> -events.
> -cq_overrun: number of times CQ entered an error state due to an
> -overflow.
> -async_eq_overrun: number of times an EQ mapped to async events was
> -overrun.
> -comp_eq_overrun: number of times an EQ mapped to completion events was
> -overrun.
> -quota_exceeded_command: number of commands issued and failed due to quot=
a
> -exceeded.
> -invalid_command: number of commands issued and failed dues to any reason
> -other than quota exceeded.
> -nic_receive_steering_discard: number of packets that completed RX flow
> -steering but were discarded due to a mismatch in flow table.
> +
> +- total_q_under_processor_handle
> +        number of queues in an error state due to
> +        an async error or errored command.
> +- send_queue_priority_update_flow
> +        number of QP/SQ priority/SL update events.
> +- cq_overrun
> +        number of times CQ entered an error state due to an overflow.
> +- async_eq_overrun
> +        number of times an EQ mapped to async events was overrun.
> +        comp_eq_overrun number of times an EQ mapped to completion event=
s was
> +        overrun.
> +- quota_exceeded_command
> +        number of commands issued and failed due to quota exceeded.
> +- invalid_command
> +        number of commands issued and failed dues to any reason other th=
an quota
> +        exceeded.

Hi Bagas,

nit: I think 'dues' should be 'due' here. Might as well get that in
when touching the code anyway.

Other than that:

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>

> +- nic_receive_steering_discard
> +        number of packets that completed RX flow
> +        steering but were discarded due to a mismatch in flow table.
 =