Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1253181rwd; Tue, 16 May 2023 14:19:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7mCDS1luV/YagstyNhsXPvtO0rRTD4lQg37+t4WGreJTWBf8+Ikl/mf3Ly/kdDn5j5fx1T X-Received: by 2002:a05:6a20:4658:b0:ec:7e0c:5546 with SMTP id eb24-20020a056a20465800b000ec7e0c5546mr40265990pzb.7.1684271941745; Tue, 16 May 2023 14:19:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684271941; cv=none; d=google.com; s=arc-20160816; b=JxwNKnqPLzaqJNuqBwlJ/A85mG5hBDCL/px6NIiqZZTpR8yg+qqO++mARoA/AyUXbT oGjpnno3ah5UFRl+F/CuPKbeD8u22NIJ1cuvAxBs2KCREIv7JGgMDyioUyK9DpGBCbQF Y6IaMonKsT942BFDIy3UhcNGXufcV4lU2htX/Yh8kSG1EKEb4xv2FWC/pqoBT3ByTdZ8 G9UcUDjGsE4sHQWY07cJwXGse2kfaHsXsPzuozdQOw2kbTmrAY4/MvHM0o7SsluiyWHK M97n6DITqNAqC9tTDlVlMUYPwqTXfIz4UjiEG8XJJi5VQNkoeRgq60mOfMI1Ha2B3xC5 t9iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fu2lnL00fajHqv2LZ2ES1j1JxMWNqPvhio4UkF/XWl4=; b=HSYL4YEnKvWhjGuP8XuC/GbNVQ8Iq36U2k/bxaFxzpKexJpJxwnau7kwwI1vbVipU9 6Y4TF6yqpQTo2/iuBN/FP2I/LxNz9MNbKxZRQTEttJ8NbQHzRJ1vlRx9I9Es2v1vv80o Y7+aVkDiN5sfCFG7ulJfL7PpCPCIXlKfRAHAtGLKGtoYoX+NO/cmTsqooM2gBEhJJq5B nz+KJK4Bz6UKb+EM9Fp67pfFb1WXAccKk6YdqDV9R5vIVc31L/zyNqAtpwprgwMG3C1w jWDHzvZSaCKaIXj/RApkICjLmw0D0ng8+RemeiDX28NWuAstOch9gCh/lNwLeheBlTnz VA7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=vh5YLJ8W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bu17-20020a632951000000b005303d78c47asi19241689pgb.726.2023.05.16.14.18.47; Tue, 16 May 2023 14:19:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=vh5YLJ8W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjEPVMu (ORCPT + 99 others); Tue, 16 May 2023 17:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbjEPVMs (ORCPT ); Tue, 16 May 2023 17:12:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D595F5BAB for ; Tue, 16 May 2023 14:12:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 732AD63D3D for ; Tue, 16 May 2023 21:12:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B744C433EF; Tue, 16 May 2023 21:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1684271566; bh=eFhJ5E/uyPdBbrpIyoaIwOP1sjzJ+IF88TEW3wCH5Dk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vh5YLJ8WBQ/6v9t45z6wl0Mu2wiNfyM5sOAw3yBJFzd19PoMsMRS+FdbWpusC5gOL XQAK4mofTchsm0wMyfl7MMGBhSkChZ3MlFSWVAPklW11B3C8Xq1tRt7N/FPGc7dOr2 S18JfVhf6NmaVH+xw8LoVw1LQUjoFYGPW5lgM+qY= Date: Tue, 16 May 2023 14:12:45 -0700 From: Andrew Morton To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Waiman Long , Suren Baghdasaryan , Marco Elver , Andrey Konovalov , Eric Dumazet , Alexander Potapenko Subject: Re: [PATCH v5 0/3] page_owner: print stacks and their counter Message-Id: <20230516141245.356200756ff3750ef4f12094@linux-foundation.org> In-Reply-To: <20230516182537.3139-1-osalvador@suse.de> References: <20230516182537.3139-1-osalvador@suse.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 May 2023 20:25:34 +0200 Oscar Salvador wrote: > > ... > > page_owner is a great debug functionality tool that gets us to know > about all pages that have been allocated/freed and their stacktrace. > This comes very handy when e.g: debugging leaks, as with some scripting > we might be able to see those stacktraces that are allocating pages > but not freeing theme. > > ... > > include/linux/stackdepot.h | 8 +++ > lib/stackdepot.c | 128 ++++++++++++++++++++++++++++++++++--- > mm/page_owner.c | 54 ++++++++++++++++ > 3 files changed, 180 insertions(+), 10 deletions(-) Documentation/mm/page_owner.rst is feeling very sad. I'll toss it in there for some testing for now. The changelogs would benefit from a bit of proofreading, please - quite a few typos and grammaros.