Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 22:20:06 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Li Yang <leoyang.li@nxp.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: gateworks-gsc: remove unnecessary
 fan-controller nodes
Message-ID: <20230516-onslaught-conceded-8e27b4bc7e4a@spud>
References: <20230516153314.453095-1-tharvey@gateworks.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2vYY8xRQ8w2qCcaa"
Content-Disposition: inline
In-Reply-To: <20230516153314.453095-1-tharvey@gateworks.com>
Precedence: bulk


--2vYY8xRQ8w2qCcaa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Tim,

On Tue, May 16, 2023 at 08:33:13AM -0700, Tim Harvey wrote:
> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller.

It'd be nice to mentioned _why_ they are redundant, since the diff
doesn't contain that context.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>=20
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
>  1 file changed, 10 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/D=
ocumentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> index acb9c54942d9..dc379f3ebf24 100644
> --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
> @@ -122,12 +122,6 @@ patternProperties:
>        compatible:
>          const: gw,gsc-fan
> =20
> -      "#address-cells":
> -        const: 1
> -
> -      "#size-cells":
> -        const: 0
> -
>        reg:
>          description: The fan controller base address
>          maxItems: 1
> @@ -135,8 +129,6 @@ patternProperties:
>      required:
>        - compatible
>        - reg
> -      - "#address-cells"
> -      - "#size-cells"
> =20
>  required:
>    - compatible
> @@ -194,8 +186,6 @@ examples:
>              };
> =20
>              fan-controller@2c {
> -                #address-cells =3D <1>;
> -                #size-cells =3D <0>;
>                  compatible =3D "gw,gsc-fan";
>                  reg =3D <0x2c>;
>              };
> --=20
> 2.25.1
>=20

--2vYY8xRQ8w2qCcaa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGPzhQAKCRB4tDGHoIJi
0g7vAQC2xZTO+TZtO8DjPffaL8EfG/QO8jAFJt/LBh6nKxg41wEA5DEofeQH+8lG
P/VdTRctr2g/AN75AOOyEHrBg0UO+QY=
=zC6F
-----END PGP SIGNATURE-----

--2vYY8xRQ8w2qCcaa--