Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1292593rwd; Tue, 16 May 2023 15:03:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4YQxxTDkhPXIyeVsKdAmoHEQ+sYjPHXDcSd068os7HgfNTTxliG6k4nzYCEtQKRCy7vwyr X-Received: by 2002:a17:902:f812:b0:1ae:4c3b:bb0b with SMTP id ix18-20020a170902f81200b001ae4c3bbb0bmr1620986plb.5.1684274617636; Tue, 16 May 2023 15:03:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684274617; cv=none; d=google.com; s=arc-20160816; b=sQaFedU4sXJFveI9bhv8sibh83CmeRnNymgM55RFQAQpoQRmuVxc9yRis1UtuKyA0a EsYquAjnV8gDLuyCmJrDgvP1a54MLHzYdzu4KS7NR8bmbY+KJ03siphpKS83oKWE953J HOfu941HzEISIEf/jWYs8sZrS3YUWTt/N/TJMd0YhmIKQesdZ+Ex0E32QhEODAzIxiA9 eNGgGmqj7AG7kD7CgBxAwHukI0eMlyX0fKlyAJKjUNtWHScgpnc+obaSjjFlLiyHvHcB 9aGcHnR6WJxR0zHJvBxsRmazNchsUvEIjPJ1TfGTfQurBJr1iLs70eqm28fK/X2ppCOC VC3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=iad4KW0Ynj7+nr6qQMYgGnWW5G6cg8fV22lwzFPncog=; b=JAy0zwFpkr9Xlr+CFnjZH/LwuvxRAmXs5hcf2MbTjgX2wS4rmZd/qzs51sD0NTosft NSWsoDOvQB20ZMV4M6QubpAtBdyyel5aLCc5QIDN7Q1gIeWEvCXRUkg6F+O2vrlEql9G L9fbYfWKzjn/4dGo21FQ/OBLtrN429I5jD24Bu+mzbnWMyFpJer8pPFqA0KdON7bHXg3 ppNgDW2Hw4/GP4UaXoOaNHW3RQ1vIjk3Uyb5cyn+Ujxr7A7JkLOtGmyIGsRKj9GD4FPA hYRon6oCmQu+bGwsAm9dkQHVmPz0wwlymr6+aJx2+8FIL3YZHJNTV5eCyPKwQo2YRX5g BXuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=guEHUICM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020a170903018300b001a24efe1f22si20947565plg.64.2023.05.16.15.03.25; Tue, 16 May 2023 15:03:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=guEHUICM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231373AbjEPVw6 (ORCPT + 99 others); Tue, 16 May 2023 17:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231342AbjEPVwX (ORCPT ); Tue, 16 May 2023 17:52:23 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75F9D8A50; Tue, 16 May 2023 14:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iad4KW0Ynj7+nr6qQMYgGnWW5G6cg8fV22lwzFPncog=; b=guEHUICMEIw2mK38zuFeUaa+84 CfKKdYwFMuuGu6SpIcOMnyKBbjk4f//mtZlPJM1vqX4jGnTd28cJG5JOtjWe5Oq0Kz2MohaDY0Ccy M/e3iKnEiCPQKHREjGGSRSEQRXJoqs6EOYWrOEr/270mo09MxqtFvGyZlP0rnKX6/dAEUWNqscl4a xkDM8i0EqWXW6t1h6PMlH6osrzf2kUAw8dU9rmrTQeJm1XOVUWnjAFPewKrDhR/Anm6jGZVPG7hU4 1F5ShgYSWpEoQiZpY5ewsgE/VCDD45W9io5dF6DDXK61kkljGRatDn807jzC15Sw4hQQxIR4DGjrd SJA29XmQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pz2Zt-007E4K-1L; Tue, 16 May 2023 21:51:29 +0000 Date: Tue, 16 May 2023 14:51:29 -0700 From: Luis Chamberlain To: Dan Carpenter Cc: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Cezary Rojewski , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] firmware_loader: Fix a NULL vs IS_ERR() check Message-ID: References: <36ef6042-ce74-4e8e-9e2c-5b5c28940610@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36ef6042-ce74-4e8e-9e2c-5b5c28940610@kili.mountain> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2023 at 11:12:51AM +0300, Dan Carpenter wrote: > The crypto_alloc_shash() function doesn't return NULL, it returns > error pointers. Update the check accordingly. > > Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file") > Signed-off-by: Dan Carpenter Acked-by: Luis Chamberlain Luis