Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1393600rwd; Tue, 16 May 2023 17:00:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vlUNb0O5S3qC5O/QXTiGcuZX5m2qojrcrDemoYNZZf9a2Ez8A2J/1g1eJ8bQIDV8juqgr X-Received: by 2002:a17:902:9a04:b0:1ad:bccc:af78 with SMTP id v4-20020a1709029a0400b001adbcccaf78mr24028748plp.58.1684281650932; Tue, 16 May 2023 17:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684281650; cv=none; d=google.com; s=arc-20160816; b=FzLn6pqWjqOiUAuUPDGCZxrte4iGdtfKvEY+rUc5SJUPRQrLkUNtgTzB4fVExn8EW6 BtvjJXEe+TYsBArMQHev5dtPMkXB3aqx/HFrJXFeEeH35wuSno/aiZ/tjqLB2LWMy/4J 5Dt1z8OzQqmc+0+XaYsbp61/Hqv2LQ9dVlJkKggK9blOEgCcwG+3RElQIG6YPNSJU6hN tmn145HgUsXOm9Vc0mcUaZLYIcLtwtM8LgBq31s2UL1noJVynQZubjLPpJmFYKu+oNP+ JrI8uESvWXDNJsuTL7bNekD1gx6GgPh9XpCx6dogN2G+wwgBrbVATU6Snx07btbYmbc3 Acbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=c91TtAMamdr84bU21XJdh1WC/pxB8oOMbvU4oHXaydM=; b=tcfRSaenCEYd4C7FPpb7mrPzLsR2/YRckuHDDRzdtemF8CqnXV3oHF05Y8x+oi37c2 qJh+TU31cb33rCP8lR16w4t+PnRTzhRHgYcrFj7aGlmM9y6v7oBNM30AUlAGf0jsW7Ax 9XHc3UMZrPsP9cF0ggrCuan31qv7icmEMWVrLg83EY/T5g4TcQnDunlnsrdILtQhF1Ka bwJdjsFyBxBbeor0Y9UuCoWSLkuO44ucoZGtOld0hD3uQd5l797t973/7kdKgToIZp05 byatyAGvlr7F04DeJJ2PMzm7pp18yyoidFdO+fCThF/Q9ODth7Hx0bmAw6xr8hamGxWE eGXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=CsB5WNul; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 3-20020a170902c20300b001a6a3954e0fsi19675942pll.18.2023.05.16.17.00.38; Tue, 16 May 2023 17:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=CsB5WNul; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231197AbjEPXeP (ORCPT + 99 others); Tue, 16 May 2023 19:34:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbjEPXeO (ORCPT ); Tue, 16 May 2023 19:34:14 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED343524C; Tue, 16 May 2023 16:34:13 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6439e53ed82so10662b3a.1; Tue, 16 May 2023 16:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684280053; x=1686872053; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c91TtAMamdr84bU21XJdh1WC/pxB8oOMbvU4oHXaydM=; b=CsB5WNulUh5bzvi0quKPWNNbWSo1UWxF3poeDTxUlUjdL+Ko4PKkQV1bMJG/rh25tC CpPt1VXITQPipJOrVP/bYkz1mo/sg3G01pmCGYMOU7xdEN+hd1gfEfXA3e35x+S/cW+U ez2ZUIqxbS70N2Qb+7i4KHrMq2PAJnjIa4ABZFpMATBa3wu7uwZ5Q1SxI+HxiH2pZvMp PVkJr6zPf2MzrOXbFKP1oP+51mDavvl27eKHlzL21HoSOA0IEHEqzhOSpY1Dfmh6AxZ6 h1VWeqcrMYKpLcUCIrJ6FEXPIzBE1FUl5JImpEQqKiRzzwyMTeaYNfgiDVXA4lWmp7zG XVkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684280053; x=1686872053; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c91TtAMamdr84bU21XJdh1WC/pxB8oOMbvU4oHXaydM=; b=k92usEauSNovtOpkSkSQaoDXB7T2+64Ar/y2FZ3sSgTExO2ggekfmCRAbxKi78cWH0 c8r5xyK6JcAssUmQTC8SOzNDb5c0hdfHjDVAxxoNTA6QCXwJXbOzVE6PmvTL7XhRiWXj bQtest06EvMW8dBlKYKxeSMCsY7BIHOmy3bGZnO8calOLi7Wyryg/PVX5KCUO6QtmFoD ivs8h1VHa+pXKrpjMrfz68jbLBUo90sLeAjmX11JA4OYZsgFWj8xWQBRJDB4T3/JWr9T Bjym9HLD9Qx0/fIuqWHcRo+yV5SP5ZswLpzCsZhts07mYiZ+FptBruflzxqgwCICQWI6 SdQw== X-Gm-Message-State: AC+VfDxXwJSwNwY0iUcXMIpfCDM2piZU7BTd9qB8U9d/Muv3hO/huaZI Ezl1IDkNuBkoOD6ddnC1K6/ZzsTwXMS3c6CYRNE= X-Received: by 2002:a05:6a00:3406:b0:63b:5257:6837 with SMTP id cn6-20020a056a00340600b0063b52576837mr739273pfb.1.1684280053288; Tue, 16 May 2023 16:34:13 -0700 (PDT) MIME-Version: 1.0 References: <20230516153109.514251-1-arnd@kernel.org> <20230516153109.514251-6-arnd@kernel.org> In-Reply-To: <20230516153109.514251-6-arnd@kernel.org> From: Fabio Estevam Date: Tue, 16 May 2023 20:34:01 -0300 Message-ID: Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision() To: Arnd Bergmann , Martin Kaiser Cc: soc@kernel.org, Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Tue, May 16, 2023 at 12:32=E2=80=AFPM Arnd Bergmann wr= ote: > > From: Arnd Bergmann > > This function has no prototype and no callers: > > arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_rev= ision' [-Werror=3Dmissing-prototypes] > > Signed-off-by: Arnd Bergmann Martin Kaiser sent a patch adding a user for this function: https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@kai= ser.cx/ It would be better to apply Martin's patch instead of removing mx25_revisio= n(). Thanks