Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 08:18:46 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        schnelle@linux.ibm.com, linux-s390@vger.kernel.org,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM
Message-ID: <ZGQdZhutT+lUdily@MiWiFi-R3L-srv>
References: <20230506111628.712316-1-bhe@redhat.com>
 <20230506111628.712316-3-bhe@redhat.com>
 <ZGPD1wELeXafPJ/T@matsya>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZGPD1wELeXafPJ/T@matsya>
Precedence: bulk

On 05/16/23 at 11:26pm, Vinod Koul wrote:
> On 06-05-23, 19:16, Baoquan He wrote:
> > On s390 systems (aka mainframes), it has classic channel devices for
> > networking and permanent storage that are currently even more common
> > than PCI devices. Hence it could have a fully functional s390 kernel
> > with CONFIG_PCI=n, then the relevant iomem mapping functions
> > [including ioremap(), devm_ioremap(), etc.] are not available.
> > 
> > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to
> > cause below compiling error if PCI is unset.
> 
> I have 2/2 patch here, where is patch 1 of 2..?

It's here, thanks for check.
https://lore.kernel.org/all/20230506111628.712316-2-bhe@redhat.com/T/#u

I used get_maintainer to get reivewers list, seems your contact is only
put in 2/2 patch. I also sent to lkml, linux-mm and s390 mailing list,
so the whole series can be seen in any of the ML.

Thanks
Baoquan

> 
> > 
> > --------------------------------------------------------
> > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe':
> > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource'
> > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource'
> > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1
> > make: *** [Makefile:1264: vmlinux] Error 2
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: Bjorn Andersson <andersson@kernel.org>
> > Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Cc: dmaengine@vger.kernel.org
> > ---
> >  drivers/dma/qcom/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig
> > index 3f926a653bd8..ace75d7b835a 100644
> > --- a/drivers/dma/qcom/Kconfig
> > +++ b/drivers/dma/qcom/Kconfig
> > @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT
> >  
> >  config QCOM_HIDMA
> >  	tristate "Qualcomm Technologies HIDMA Channel support"
> > +	depends on HAS_IOMEM
> >  	select DMA_ENGINE
> >  	help
> >  	  Enable support for the Qualcomm Technologies HIDMA controller.
> > -- 
> > 2.34.1
> 
> -- 
> ~Vinod
>