Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_84FB1255E5E4157DD418B1DBA0418832AB05@qq.com>
From:   Rong Tao <rtoax@foxmail.com>
To:     rtoax@foxmail.com, dave.hansen@linux.intel.com, hpa@zytor.com,
        tglx@linutronix.de, luto@kernel.org
Cc:     bp@alien8.de, linux-kernel@vger.kernel.org, mingo@redhat.com,
        rongtao@cestc.cn, x86@kernel.org
Subject: Re: [PATCH] x86/vdso: Use non-serializing instruction rdtsc
Date:   Wed, 17 May 2023 08:41:31 +0800
In-Reply-To: <tencent_4DC4468312A1CB2CA34B0215FAD797D11F07@qq.com>
References: <tencent_4DC4468312A1CB2CA34B0215FAD797D11F07@qq.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thank you all very much for your responses, I tested the test code
evil-clock-test[0] provided by Andy, this patch does cause time read errors
and load errors.

    $ ./evil-clock-test.out -c monotonic
    CPU vendor   : GenuineIntel
    CPU model    : Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz
    CPU stepping : 0
    TSC flags    : tsc rdtscp constant_tsc tsc_known_freq tsc_deadline_timer tsc_adjust
    Will test the "CLOCK_MONOTONIC" clock.
    Now test failed  : worst error 255 with 81902816 samples
    Load3 test failed: worst error 384 with 3284297 samples
    Load test passed : margin 32 with 18848374 samples
    Store test failed as expected: worst error 704 with 18213325 samples

Thanks again :)

[0] https://git.kernel.org/pub/scm/linux/kernel/git/luto/misc-tests.git/tree/evil-clock-test.cc