Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 09:05:08 +0800
From:   Philip Li <philip.li@intel.com>
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
CC:     Francesco Dolcini <francesco@dolcini.it>,
        Andy Whitcroft <apw@canonical.com>,
        Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        "David Airlie" <airlied@gmail.com>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        <linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: Reported-by checkpatch warning from v6.4-rc1
Message-ID: <ZGQoRJrSvQkbFbUf@rli9-mobl>
References: <ZGKFV/FGu3oDNMV1@francesco-nb.int.toradex.com>
 <238b5d83-cfb1-ce99-8e1c-b69b8d65ed91@tessares.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <238b5d83-cfb1-ce99-8e1c-b69b8d65ed91@tessares.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LEMbtwsU/7y+QytncjqBVlH6OnoWDepvNTDqMNsOXf8WEHLfmDBJOyI2r/F3?=
 =?us-ascii?Q?0Hr7hCMXhqIjIAU4ro5DAmF497o7giXAitISHYrGVKfxLfPEkcW+0WN3Nb2T?=
 =?us-ascii?Q?fooToYuycI4Wh/Y1rslorx6YbXoHu3BAeSOpMh6ueuLMK6JK3+jyB6/bxv9t?=
 =?us-ascii?Q?2itQs5aIzJXQWauuvLcSpHckbJlHVCiOBZiwYDl0WRf8VyO9E0Dcs/V6KsO3?=
 =?us-ascii?Q?a+s6bB/mi8ZZkuCH/QgnoQHYYOdjTHVt5xKJvcHDcr0ZfTtcRTPEAMsklJ4S?=
 =?us-ascii?Q?aeBx28pfkx6WHjldgQGSCVlel0zV6ZmQCip54OSiDrl+wBm6fWKGUGsxx0Du?=
 =?us-ascii?Q?FtFYDMsKjLskR0nQ3dP5VoB26RRPGCFJaceaWjf5Hvwg8GUR4+kk98D1R1HG?=
 =?us-ascii?Q?BWM2oiashGDc9MJetp/+p5FPukMBDGgfvimJ/UT/vCoFJUiPPvbMmRuo7+GP?=
 =?us-ascii?Q?0yurG4+oVnOvOOVEToPQO2Z+TlpQ6JBqWDFTTTJzZqWcISnJi/1zc7wW95Bi?=
 =?us-ascii?Q?DiFksdMFx7cZM8JGnaRhGMmc8eEV77FEyE8/lxEAEPNVT52w6H9j6V3DBDw4?=
 =?us-ascii?Q?/l0ug9GXnlj/Pm52+WemwQmtZBKHPzuliJSzx9H1tzfwxMlS/cLyC0zdHayJ?=
 =?us-ascii?Q?l12Ze+OiIyu1qoibuXhWfdY4zI3rY6fXiD/lqXHLFZ/cnWOo7TDro0wvmSYi?=
 =?us-ascii?Q?Fb9ozCcEVuz7pw0g+jbBSoS6Gsii/r/ocdwTFtDe7SJxq7+SUSmGhffWbCPP?=
 =?us-ascii?Q?nQQDxksW2kADP1uKhlTbtTqAp2DHL2FA+I10kAebus8yCUm6WwYhJKi0ykCo?=
 =?us-ascii?Q?e4B67qFsTyIVE/hYeM/Kxb0545wUMmPhxRj2izXO+/TCkebhIow+779NSZEK?=
 =?us-ascii?Q?JWyGb/1k3WMrJthiRSYqmTsLAOem9/sG/KKg2L7VuGYLz2NLDzBtHXMIw1w1?=
 =?us-ascii?Q?dzJ9CNDlsDAV72QyoYKg5j8pBey88OKQbQfGnsPDVZclySoRTZpmSGAxFO85?=
 =?us-ascii?Q?vcI6jLNfSQLFaswA0RqYhT5cGwPUxrcwOigyRgYzbD+W7So/O/KHre5jIdKn?=
 =?us-ascii?Q?ZB+hvpXvypG6fbqrHIgVLDEg71PJX+bd4S5SXRM2sVfKmN2L+Ir8lI/yMcR+?=
 =?us-ascii?Q?P0PfMTzPqPMSgJotzqfvcGGOWA/rH7wYSQBdadASlZYC0/jEGZLzrITjMbPT?=
 =?us-ascii?Q?a0kdhPIQqSsZ5ah/4PCsXiVA9pOMVgxpzZnshWEahbImpShXoOSrvhbKRG6T?=
 =?us-ascii?Q?vsV4es9t4rYR2Ei0gxtj73qH85IiSaxYxJaZXVT76lH4S7G2WcSflzOEke4y?=
 =?us-ascii?Q?baQeTrD+nyGMs/ZZku0KYXSFQ7y6dTE+YWIhH3FhHgEqKZF4+/3WnhInzPk+?=
 =?us-ascii?Q?RtK1M29y4rDHHJYPM+lE0MUw3mARvNbs5zuqKj3P56J5n7zVi47OIve+eTex?=
 =?us-ascii?Q?/gD5n+s6teo2Jt+s+V/h+I05bX2ZtgIM74F9/Ew/DtypoM9FYcfR4xpQWwjE?=
 =?us-ascii?Q?xlsXQolzVI/0+KakrVupVtSoIEVFOueisJo7HrbuEveyUwh61BcRZisCJNrN?=
 =?us-ascii?Q?lZUarMvStjoO+2G88GaUQr0D9cMccmdO9ztoBjNC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aa38b0bc-fc6e-47a6-acbd-08db5672c84e
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 01:05:19.3701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aJj5DAZbx/dlpv4uIE75LhXPYH4qMiEoaG9ttPSoFjjigRrHWSzqod0uQe9pl9IG2iHA1md1q9xdeJDQlvpaDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7741
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 16, 2023 at 11:47:45AM +0200, Matthieu Baerts wrote:
> Hi Francesco,
> 
> On 15/05/2023 21:17, Francesco Dolcini wrote:
> > Hello,
> > starting from commit d6ccdd678e45 ("checkpatch: check for misuse of the link tags")
> > any Reported-by: tag not followed by a Closes trigger a warning, even if
> > we have a Link: tag afterward.
> 
> The warning you are mentioning below is likely due to commit
> 44c31888098a ("checkpatch: allow Closes tags with links") instead I think.
> 
> This commit is linked to the modification of the documentation allowing
> the Closes tag, see commit 0d828200ad56 ("docs: process: allow Closes
> tags with links") for more details.
> 
> Initially, the intension was to allow using the Closes tags with links
> to public bugs trackers because in 6.3, checkpatch was displaying
> warnings when it was used while it was fine before. But it turned out
> that this Closes tag can be useful for bots tracking bugs reported on
> public mailing lists. As explained in [1] and [2], various bug trackers
> can use this tag to trigger some actions. It is then helpful to use the
> Closes tag each time a commit fixes a bug reported somewhere.
> 
> [1]
> https://lore.kernel.org/all/20230314-doc-checkpatch-closes-tag-v4-0-d26d1fa66f9f@tessares.net/T/
> [2] https://docs.kernel.org/process/submitting-patches.html
> 
> > Example:
> > 
> > WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> > #8:
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202305152341.oiSjRpv6-lkp@intel.com/
> > total: 0 errors, 1 warnings, 8 lines checked
> The warning is saying to replace the "Link:" tag by a "Closes:" one
> here. Is it an issue to do that here?
> 
> I guess it means that the kernel test robot should then suggest to use
> the "Closes:" tag. I can report an issue on their bugs tracker.

Hi Mat, thanks a lot for the suggestion, use Closes tag is clearer here,
we will update the report info accordingly.

> 
> > From what I can understand it was not in the intention of that patch,
> > and Link: is still fine to be used.
> 
> Note that Checkpatch cannot cover all cases: it gives you
> recommendations but they can be ignored (and documented in the commit
> message) if they don't make sense in your case. Here, it looks like you
> should use the Closes tag but it might be fine to use the Link tag if a
> commit doesn't fully fix the reported issue for example.
> 
> Cheers,
> Matt
> -- 
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net