Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Juergen Gross <jgross@suse.com>
Cc:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1ttwbsoii.fsf@ca-mkp.ca.oracle.com>
References: <20230511123432.5793-1-jgross@suse.com>
Date:   Tue, 16 May 2023 22:06:23 -0400
In-Reply-To: <20230511123432.5793-1-jgross@suse.com> (Juergen Gross's message
        of "Thu, 11 May 2023 14:34:32 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CPXxLOtNqygWc0rZR11ubbWLb11QmANoOUjAvsS6MEUKuafMVftbIBKbod0q?=
 =?us-ascii?Q?uwSQ4bxpGGwgz5HZbBUsPetjr6F4WDyuw9o5SkTwQWh+DIv884mdYu55mbrv?=
 =?us-ascii?Q?qfZx4P2DBaPaFLkhT37F6LedQx6ILFvaGQrOlQmiucRI4T5W6S/06SD+lMI7?=
 =?us-ascii?Q?OLBzYZ+9AA9aFt98ylm7YXku+kpkoiaCG3Ed28/LYz3oZUx/eMTCaceWfCf1?=
 =?us-ascii?Q?hRxtZf2C0pTK+Sfvba9iIRmq9n99bT0GOVg6kky2hFt51VQovzJnukclM6Db?=
 =?us-ascii?Q?GLcK1INz/4AVTO/7dE4TnHUW8xtN7ayUKgu/9DJ1IT6fLvtdKAy871zsvBuQ?=
 =?us-ascii?Q?I5kG3XP1/ouJwHRMSp/fQkzatda3WcSYVxRXL33oKHwl637tFwgEl3g4zMXx?=
 =?us-ascii?Q?5QUB0TYgzzfwse7fgNKcYDfbsn7VwjnVAa/KR2wjZCcbm8WkPmIvASRqjJ8S?=
 =?us-ascii?Q?gvx7tlPLRCWllbtwSWZEoSslFJZGzcTJ0VpHeZk3Hyc3hKne45NFKNhE1SAZ?=
 =?us-ascii?Q?sK0LvvzCxhe+LITy4Hx7J6mSEvAhuVJFgsUwXAwLzZzwvpQLpzBBgChuxhKd?=
 =?us-ascii?Q?+vdqf9MgyWWmmb25EsyQdsu4tYQgP0/eqZmbRwyjUgUoYQXiYSWEQeqLocil?=
 =?us-ascii?Q?LWsR3l+VHGQPraDRQRWsDUP1O1bQqLuJ2spRO8s2BUyZ9MY5DCuOfFowLrIa?=
 =?us-ascii?Q?fqIAT3JKbP5ccjcReFVD6IgU2DXWdstIQKuobgdMqCXCj4pX8GW967QKfXnG?=
 =?us-ascii?Q?IxxKP+4OrsZnX/EyZJFCXVCpb++2llgg3HUgdcv2Cfat87Lal7/Yu8CjOUe8?=
 =?us-ascii?Q?9jy3BVllP6+T61+M39cVE/lQvFYQW3TwCHP+b2urIgbYzh0dJ8Afi3kwvDCd?=
 =?us-ascii?Q?c/Vyuj+IT06sQUYzdNQ8iNKZjLnOUimwOupdr8RfeovF54PpqdjRj5VxzkLg?=
 =?us-ascii?Q?dgfMAsPpZoTrjRURkTB7Dg9rxjAhi2EEKUS43slGhcdFtWxIPe3LUnrPLk18?=
 =?us-ascii?Q?rVuQKTl1XwcjDHlRxg3MRuzS/8zxc5RkrS1nZYtzpUFuRFHGO8CbdtYD0EFQ?=
 =?us-ascii?Q?mME+jOX9V76dxlI4FV0XJd4lUMhGb6FaivU2VoKTLu5kuDYE39CQTnWvFpoU?=
 =?us-ascii?Q?eJfnLil6Rt4aI6pLiDSmn5lVPJjSAY4bN049qGSAGBKRT8fQluPHoWcE3B4a?=
 =?us-ascii?Q?A6P5HoMNMNj+izrFhmeV3y+MS+X48rkje1iKCxEmkQDNvojYuzJKqEtuwmjQ?=
 =?us-ascii?Q?flfua4LpLz9vYivL+WlupiU4GjCpUyH6N7w1gEyJmhPQVf5/G4kUd3yO/4QQ?=
 =?us-ascii?Q?SlLyX5Al37UvVF7LY+wPJu0xZuTHsHoBDCECe0xQVeUSsfaDmSdolXnWYySP?=
 =?us-ascii?Q?uywPm+txFtDligDRi1xRs1PmEqd601vMT4pYT/A6ctZjrFN86vh17d95FGlH?=
 =?us-ascii?Q?fivDacEV10DHtsGEIR8FZjWPjGpTLXUPKOK3CYkagaPB54gp6xxMra7d/tdu?=
 =?us-ascii?Q?OfnW1UR4ISz0E2eQQ66fzbywWnAU4BClmQBkZP4NR/AxkrYisBTZQhZ21mvA?=
 =?us-ascii?Q?Sp8BPNOUqqltQUTf44Q9NPiw9tSqwSZnpd8KD7q8kSDHlMR3YTWjEaWmMIbt?=
 =?us-ascii?Q?Gw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Mh/GsQwz3Mzugdim+z1iUPI+M8jrgtUaBg4QbxxFUahEpj8KcKK8F+WiF2IrTigUckcoBzS9BUFCdm7/SPJPEaJpQg8H/fKQFGByJb5GGdxEQEcva1ymMPSGIXBWPscHhUpcQpbiKdaa82m+2CQxzi2t8AxCpi44S9g9RS7sZG1B7D6oBu+KPvAORn5UBDV5xYVMxE6FNJS4d2YIXCrnUgox7P7IOY1KVE3qoCeYg5rXRfoVH+IzOYPPMxHLEsdppBHExaXRMB+ZFULRRiltrGWbcR2VWQgPqveop2YgVwOmHXkLHnE21ETvBvOkgLotgtMqJqZVoGUTvL7oKPD8QXMir6wvFF5QYNRPnAzm2OCRJyCh7m7UXV+od9rDA2FihxWbFEJWwcytZOBlJevL/ID7tC7ETG9MMJUURnKXnvmFJh0ZL4ohvVyFurE2GyCWFHB7Fg9/mrlqE0Lrdy1wzl6SWdjZDI4dgIOgAn4aZpwnXt7+THxlzh4qOJTTUymi+pcTk6Jr+7lCu3xz/urbQsEBofuubixj2/mNnOq45go+BSUUGaJ7Hyd/fe/EpJPgvTpeIPh7sLSmNV5W2jUDTDrHud4oQ1qQaXY1kN61vQqSCWQUpW5mK6S5mPmq/hkxONOa5FIZFrbKn26WmCHa3ZdOBHN7PiX789u0lJoD/Ggpp1NbVBBniERtSFyY4gLaN95GTTltWxHelQqecMydZ/1QX3w9P9wNZbtSaJJi+upB/avr/YRQeEtfs9tUm01FvfYUmRtAj3nfJnaQ3KOaxRmfAPxKTb9zXAL5RYQo6m6GRoUIXm/s1l4bTE3cb0c5
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3735435f-b0fc-46c1-beeb-08db567b5873
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 02:06:36.9283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oNjGh/WTHGEPi41XJ0riFH4iduSjvGyALGDTwrqN6yT/5b2DZXeWz/cN+KKv4auRr79SqL5GvTTBWu3must9WiZVzJLPck2qAsUlckDCJB8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6279
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 mlxlogscore=687 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305170015
X-Proofpoint-GUID: SN3SD6_FJpzxTsITdVjVnXpxQcep0Rr2
X-Proofpoint-ORIG-GUID: SN3SD6_FJpzxTsITdVjVnXpxQcep0Rr2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Juergen,

> Some callers of scsi_execute_cmd() (like e.g. sd_spinup_disk()) are
> passing an uninitialized struct sshdr and don't look at the return
> value of scsi_execute_cmd() before looking at the contents of that
> struct.

Which callers? sd_spinup_disk() appears to do the right thing...

-- 
Martin K. Petersen	Oracle Linux Engineering