Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Alex Williamson <alex.williamson@redhat.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>
CC:     "jgg@nvidia.com" <jgg@nvidia.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V5 00/11] vfio/pci: Support dynamic allocation of MSI-X
 interrupts
Thread-Topic: [PATCH V5 00/11] vfio/pci: Support dynamic allocation of MSI-X
 interrupts
Thread-Index: AQHZhB+PoaHMIm+N6kmnr0VVXmGkHK9diiwAgAA4KeA=
Date:   Wed, 17 May 2023 02:14:59 +0000
Message-ID: <BN9PR11MB52766D2B3D4EEA58D540FA858C7E9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1683740667.git.reinette.chatre@intel.com>
 <20230516165320.229b4928.alex.williamson@redhat.com>
In-Reply-To: <20230516165320.229b4928.alex.williamson@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7vT/aIxjGhnDUF9Xba1FLXuQxn/K6hIYeHA7IEfHXEcUl4GrnLfa4TFKh6/R?=
 =?us-ascii?Q?SqROyBOoOukq/sAKauWyrCKxjURAA+xlskSAai4ND2mp/NdMBtepQIomRHFt?=
 =?us-ascii?Q?HiKT4bZ4HuK4VbDR04bulsv4ECqQKcGW09VOPDTmEINJXxQY6Fe1YhT0ieTI?=
 =?us-ascii?Q?YbPJFZ/CX/mT3vcX16DBK+Kc3Fqb/0hsO+rubmXhiwdzyO7WYUDYaiHF2SyH?=
 =?us-ascii?Q?BZX1kAAAMLFq3ZOgFcxdUgLy7YuKsfqwiliY/v+pkA0Y5qPMLort0jZFUtaG?=
 =?us-ascii?Q?OU7yGTZuHYDCWSQxOoVNVtgnjAYQjFHOKfp65vXgvwVbtxf1UBmObrWNBr1z?=
 =?us-ascii?Q?4LdMXgdeY+JYr7gb8WkjUmuFWn0mNBqNaoVSPjGsXO0Ps4MbiYBdwS268/vA?=
 =?us-ascii?Q?URpUUoIPTIuBkZMmtCWVgxzOyShM5/scowy/9YvqjZaPpTuKH0Vx6qk1iqIu?=
 =?us-ascii?Q?Le06HXV71rg9NoN1T/9CpshTCAQXtXJbExFMzzXAB/TCzaH2GLeJ1rEGIw/n?=
 =?us-ascii?Q?B6AVAmh0PD0lTNkr4r8aYBm+vaJZALvAATIwx7TMF61/m3MH1qv9ye5kPayr?=
 =?us-ascii?Q?XEsXemekc6zqmxA0SoKEQzaTH4F8m3NPnfAG3Jc2fMs1DaEmop+LSoyipsk0?=
 =?us-ascii?Q?PRgq0m5LCPToZwRhclj8CwrIg9BMfsL/GZJywRcTHc+m2yQScTDiv6ZT3R7Q?=
 =?us-ascii?Q?Gc9d3JPwp3yI1RjW6t1L3fws1xCwwwMbmJXYpdShP58N2hrqMxjzIQUsnBYH?=
 =?us-ascii?Q?NdKEhOruDgbk05llnoC92NEYUg7R9mTcMjbK5WJQYpisFSo8UyWA8OYtY6L2?=
 =?us-ascii?Q?EXQuXsIXSrUHO73MqAPPOn35Pbx3MxK0sWT5EhKzYLpakDxborJmUsBdKk5j?=
 =?us-ascii?Q?U0mvWsyTfnLagG3vzAQTldFTuXJHw24rjuN7eMVsSEf/PSDWHCIfaH6vg5xR?=
 =?us-ascii?Q?/Niyg0G/6ixO4QdpyvOTcEy/g9ssdUT1Ec8EWNlemgB/dmj85wo+uhyqAU13?=
 =?us-ascii?Q?ZCJFYY6+g8RwgdTdggG+cLJ/gNh7mfCvYFhSZrMSJyfbQOMo47IdQX9lwKXh?=
 =?us-ascii?Q?p64secuspL+pCVZ685/P3AV1ZNTW5tias93YzXeFFOCyi+fASqDHbiCiKkkA?=
 =?us-ascii?Q?Yak/fwyKqBLD6glWmDiVD8CJxurRQOsYhE6yGUf0Zv9Yn77brHsQw96OgSd/?=
 =?us-ascii?Q?QEHQJPOJNJLg8ERwkmZoFWJiGKdEcT/hdWFFOJVdH5Ok9yfq5Bjbt6mYQSR1?=
 =?us-ascii?Q?+hGoR7mZGhn+O4cs+WphjUtwJGXs33YAJS7hsxZgk3jxYDffPYXbodInZvxl?=
 =?us-ascii?Q?jo6767BJFIcjpUTBjggdBbWDk6AmrjBuGHVxAYBgzejowGVkIYmYdnVozVwf?=
 =?us-ascii?Q?9ww/axDnyvVIuL0KotQ77mJe+dgxAMuvUMFXr941e521yCqDMdyC02wJptiN?=
 =?us-ascii?Q?dJZd/vUJILlQN3VRlfZKjOw83amEfqKe9Fm52Cw9K5/qv6ujwrrplF1VzmL9?=
 =?us-ascii?Q?0+zg7b9At3s7iwihAIFHlXZqgWzrWWhhLlcI4/FghnVFP3PUmVG1skP96AwS?=
 =?us-ascii?Q?hptscpo2lYyUgRMbZ63bnchTLev49ResobpFsmix?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86fd4f8b-1c13-43f4-d153-08db567c8439
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 02:14:59.7184
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lve8h4UUc9aLw5vlwVm8swvnqfkU6AClFYuzEY9inWTRoaSYEwEki7CJQTv/fPSnQNDTbDtLXv57FwzWrGNChg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8201
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Wednesday, May 17, 2023 6:53 AM
>=20
> On Thu, 11 May 2023 08:44:27 -0700
> Reinette Chatre <reinette.chatre@intel.com> wrote:
>=20
> > Changes since V4:
> > - V4:
> https://lore.kernel.org/lkml/cover.1682615447.git.reinette.chatre@intel.c=
om
> /
> > - Add Kevin's Reviewed-by tag as applicable.
> > - Treat non-existing INTx interrupt context as kernel bug with WARN. Th=
is
> >   exposed an issue in the scenario where INTx mask/unmask may occur
> without
> >   INTx enabled. This is fixed by obtaining the interrupt context later
> >   (right before use) within impacted functions: vfio_pci_intx_mask() an=
d
> >   vfio_pci_intx_unmask_handler(). (Kevin)
> > - Treat pci_irq_vector() returning '0' for a MSI/MSI-X interrupt as a k=
ernel
> >   bug via a WARN instead of ignoring this value. (Kevin)
> > - Improve accuracy of comments. (Kevin)
> > - Please refer to individual patches for local changes.
>=20
> Looks good to me.
>=20
> Kevin, do you want to add any additional reviews or check the changes
> made based on your previous comments?
>=20

Good to me too. I've given the remaining reviewed-by's.