Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
        alexandre.belloni@bootlin.com
Cc:     linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] i3c: master: svc: fix cpu schedule in spin lock
Date:   Wed, 17 May 2023 11:30:29 +0800
Message-Id: <20230517033030.3068085-2-xiaoning.wang@nxp.com>
In-Reply-To: <20230517033030.3068085-1-xiaoning.wang@nxp.com>
References: <20230517033030.3068085-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/3e1X6twGA+D8WWJ6D4bWqc6SwFR/NgNtk5uoGI04F1RPE5RdgWgS5G7Cq9g?=
 =?us-ascii?Q?BEhQU6rrwj5b46fZyUlwdPf6NlqKQcVxA7VvU7urSxI6g7vlMVYRjNSiiWow?=
 =?us-ascii?Q?Gg84qAFpB+che/nS/SmdtQeSAlMJQSELBwNzeIBikl1Vz5Q5uic1S0Qfvb6F?=
 =?us-ascii?Q?i36RdN1CHgOOVEd7ilPc2wI1wWXj9VardJHYcsKhPjoHjyvXQ8SoDmQgfSJJ?=
 =?us-ascii?Q?qYEYGsJAqhJMwFdjAo3VRqUF9WY2YB/DuUCj7z9lIy4jbGSKiO2+8qi7GnQ5?=
 =?us-ascii?Q?uNFxqbQeNd6MOyFq4J0TPCrxATbNw3CpBgvUJ4LQZMqSNY4pFm8Yx4q9yhcz?=
 =?us-ascii?Q?U4d74JGKZlifAwfoAYDwlaoBv/RFL6dy2Oz2Ai7eBhO3QbbKafwJywb8ffZS?=
 =?us-ascii?Q?fRS2RJ/6tQCXRybFiOixHyMop03+o4c9BfvOKb1ok/bRdec5wScgpRNndl8W?=
 =?us-ascii?Q?LngB4Lw7JVN2eeMIDXs0tppMCUt9X8MIlAhsEYAHMs4FOjA6+TdvJrR2nPwP?=
 =?us-ascii?Q?LKK6lmeGyfjujXIfbygeqNr4BF3IqB1FqeuxXPKzEnApLojM2NR3PpnsRItG?=
 =?us-ascii?Q?uo/z7i03JPKdnS0PrR2QDH4yhmxVrGs0ksTx2rKKEIR+yHcMnwwFMgpFWHt1?=
 =?us-ascii?Q?UPJ9VAbbLd1VVqKE+d7fszCOnYLpvNre8R1Y0LQFzBiBL/nutVN8nkxbMLyX?=
 =?us-ascii?Q?AacSN/vt6QGSuZ1Uy4rTaze8SNwfjqYE5e4n+f5MaXMS58q3N4iEgstPxShd?=
 =?us-ascii?Q?wQz0oLaxf95c78AjJxL4hI/9UilL5oRY/waLQ4HM0U0S77416+RGbPYuzRRy?=
 =?us-ascii?Q?r0gWwi8MBRQySt41fkvdcqzco7cgWk+2xsB5Nch4sJT5D/KddYB/mtJVYtq3?=
 =?us-ascii?Q?E/Ohh4GGCPyMwPeLZxtv52VcIMXY79C+xfJ7iYB364GbDpk87/nhzBW9eIIo?=
 =?us-ascii?Q?s3wjoOQGsV1jwktnbX5IuojHrLW1qN9HXLiNXE/+MSVndyhTcqpm6O0ciOO6?=
 =?us-ascii?Q?tM9hWNiJNfTtiQ33qbaWG7vePdddhgOK96e/A8Ss2rGZVyaaGnERSj1Mnx04?=
 =?us-ascii?Q?1Gd3K//TKCv2vW3Bbn3oBivpgScjicag81DQuOD0bdlK8f75txNlUdW3ebjq?=
 =?us-ascii?Q?HGJpQLuI1wmOulhLzqq9d8Gy8iv9/5QN882yagM67Qdwik8uAo3QCkOKaEdE?=
 =?us-ascii?Q?K7lVmOY7O8OuIGGgudGo1Ij/C2FiHdkf2Lr3Td7/F4yrOvgkpZnubcKnpVzl?=
 =?us-ascii?Q?T6aiQB+e1M1+wpwBMbtmHwaC5oOXYZ5TBRe6x+5FWYqgbrfTJ+Tgw7BUpxBb?=
 =?us-ascii?Q?CpZUnnUbEMpYVHpVay0vdNaVCkYDjEje1OcPKhp4XTtWaS92d9ZXMJipmlW9?=
 =?us-ascii?Q?YT2WyFmt4NebVVXs/3Mucq/pfnToqxETygIkDacZUjzsc8T7l+/9WnDm5g0u?=
 =?us-ascii?Q?+RFpmv/5vVi7Qs0UyltaF1MCuU1uPev9cCWSxEO8Cak/Zl/yjJrl5G3AF6Wb?=
 =?us-ascii?Q?LrB2yKx6Z05YWrpf92LFbc6M4S7hClqBrVFX6De5GESwvUJykRf9MQ4hqSVg?=
 =?us-ascii?Q?OMpcQXOZ+vZ9/VUwvKApez6IK044c6HOo6ySVdqT?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f798c88-08a7-48c0-6581-08db56870999
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 03:30:18.6654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0HkL9oSnBKyOjYJX6d5s/UuLbVMDzBhzU537XSdYq/CbexFwsB6epwm6wdjA4UvI7d3DmxBnBuq8R0ZPjhPmTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9243
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

pm_runtime_resume_and_get() may call sleep(). It cannot be used in
svc_i3c_master_start_xfer_locked(), because it is in a spin lock.

Move the pm runtime operations to svc_i3c_master_enqueue_xfer().

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Fixes: 05be23ef78f7 ("i3c: master: svc: add runtime pm support")
---
 drivers/i3c/master/svc-i3c-master.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index bca3a4352ad1..4edf33ed207d 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1096,12 +1096,6 @@ static void svc_i3c_master_start_xfer_locked(struct svc_i3c_master *master)
 	if (!xfer)
 		return;
 
-	ret = pm_runtime_resume_and_get(master->dev);
-	if (ret < 0) {
-		dev_err(master->dev, "<%s> Cannot get runtime PM.\n", __func__);
-		return;
-	}
-
 	svc_i3c_master_clear_merrwarn(master);
 	svc_i3c_master_flush_fifo(master);
 
@@ -1116,9 +1110,6 @@ static void svc_i3c_master_start_xfer_locked(struct svc_i3c_master *master)
 			break;
 	}
 
-	pm_runtime_mark_last_busy(master->dev);
-	pm_runtime_put_autosuspend(master->dev);
-
 	xfer->ret = ret;
 	complete(&xfer->comp);
 
@@ -1139,6 +1130,13 @@ static void svc_i3c_master_enqueue_xfer(struct svc_i3c_master *master,
 					struct svc_i3c_xfer *xfer)
 {
 	unsigned long flags;
+	int ret;
+
+	ret = pm_runtime_resume_and_get(master->dev);
+	if (ret < 0) {
+		dev_err(master->dev, "<%s> Cannot get runtime PM.\n", __func__);
+		return;
+	}
 
 	init_completion(&xfer->comp);
 	spin_lock_irqsave(&master->xferqueue.lock, flags);
@@ -1149,6 +1147,9 @@ static void svc_i3c_master_enqueue_xfer(struct svc_i3c_master *master,
 		svc_i3c_master_start_xfer_locked(master);
 	}
 	spin_unlock_irqrestore(&master->xferqueue.lock, flags);
+
+	pm_runtime_mark_last_busy(master->dev);
+	pm_runtime_put_autosuspend(master->dev);
 }
 
 static bool
-- 
2.34.1