Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cc756d0c-815e-49e7-1f87-93d74eedecfc@oracle.com>
Date:   Wed, 17 May 2023 11:23:51 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] btrfs: fix uninitialized warning in btrfs_log_inode
To:     zhangshida <starzhangzsd@gmail.com>, clm@fb.com,
        josef@toxicpanda.com, dsterba@suse.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhangshida@kylinos.cn, k2ci <kernel-bot@kylinos.cn>
References: <20230516013430.2712449-1-zhangshida@kylinos.cn>
Content-Language: en-US
From:   Anand Jain <anand.jain@oracle.com>
In-Reply-To: <20230516013430.2712449-1-zhangshida@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2JXQ3IzMi94bnVib0Q2Rm51TU4xdThnT1l2YlRNUHQyMExLd1pxYmtTTFBB?=
 =?utf-8?B?R2hwbHNsek5YdnNsdkdvMWc3djFsSEpsMGdnTThFRFFhVWFleFZ3c2htZDho?=
 =?utf-8?B?Z0pHbGkyaG9hRWZEOEJXQ0paM01ZM0g0NTViK2NMZjByaXFKVXNRemtNOGZi?=
 =?utf-8?B?STN2dzZIQzVpYWI0U1NwaDhZQ0doT0RJN0xvZk1NeEd0Uk5GaHBabHJHSGJh?=
 =?utf-8?B?cVVEQ3M0R28yeHlxam5rZ3RheWlIS3NpNEg3K1RHNVU5QVdvQkpyNWU0U1Vu?=
 =?utf-8?B?MVZ2dkZ2TzlaRkFtSXRlYmF6TlZiaFJ0MzJqVFRyd2ZkL0s2SnpETEg0dyty?=
 =?utf-8?B?L0xhSTl1RGZGM3NydGU3SDgyVUhpZkUxYnEzY3dQdERPVzFwaVpuUWw1VStU?=
 =?utf-8?B?NjQ3ZXhFeDIvcTMwb2hPSDJ0eUtjNkdMd0JWcFIrV1M1WXpERVN0R2ROajdY?=
 =?utf-8?B?YXZQMmJNbENvVFkxVldENXMvZGEraWNRdWFCSkZDV0Fid3J1RXd2T1RpNUR5?=
 =?utf-8?B?U1ZnRWpIRXVyekVnZ1ZLVlRyQnNhajZhZHFtU3BVNVlGUGU5a2h3T2RjRUhS?=
 =?utf-8?B?Zzk5ZzBoQ3VqbXdZMG5hZTB2UUtXaFg2QUVMaDBOcUdsUDBVU01LanhtQVIv?=
 =?utf-8?B?eFNBYmpBSkpTLzNXWkNlR1V1QWU5cFFCK1lMNWdIUytldmJuMHNGendFN1V0?=
 =?utf-8?B?OFMrbXlQWnFHNlhOTXJJMCs3emxBMEtiOFVyY05lYm9jeVRocFhNVG14MFM3?=
 =?utf-8?B?eFF1WnlSWVl5QWp4eW9OYVFSazc5WGErK09kZXhLNXdIV3hPWmJSVG1UdkxG?=
 =?utf-8?B?NW1PQm4xZkg3d0xKZk0yODBKd2M2a1FXRnFTeE01MEVlUmJycEtiS241bi9E?=
 =?utf-8?B?cE9sVHpQZG0wL0tQbDh4aTZOWldqUVJ6YWJiZGpoalM2NWU4ZVc2T1hQUmZh?=
 =?utf-8?B?cFl0T0FHdG9ldy9rWmNrUVpGbmM4M2pnR3g2eXZ3WllUd0NVbVk5WE5qOGtr?=
 =?utf-8?B?cXpuWXU2QVlSL2tlQytaMzkra1BkdWFrTUJIT2RHd3IzLzdPa2N3bFFYTTNH?=
 =?utf-8?B?ZHhDOC95ajBPUHVPYng4VVhWWm1oUWI2ZW1IVDh4b05wbURNYldqQXBPTXU4?=
 =?utf-8?B?UFk1VXV3K0hRaTdqN2ZLdDJCVUxoTGJFR3dEem5QOHRFWXY2NERsZGhCakdI?=
 =?utf-8?B?ejI5UGJmT3lXTDdGNWExY3J6dFR6QVpSRnF1ejZlb3VKQ282UUNZY0s4UmVp?=
 =?utf-8?B?bzI2VVdrYzN0K2tnOEt1UTVhOFMyL29YRnhCRWpQZm13dTQwQVB5eERzMUVO?=
 =?utf-8?B?V0xrWlRIWm0vQ3BQN1Ewa0RTV09qNXRFSGJXNnAvV3NLNVlMWnF2MjE2VjdX?=
 =?utf-8?B?NHNMN2hMKzJ0MGdjSTMxcUFHTGRiWTRJaFRyNFFqRkNIZlcvZ3ZvczIwbnBz?=
 =?utf-8?B?N0NZV0ZvL3Yvc2VXSEFiTU1vVEYrTzBjNDBvbWVHVDNhbFJ2enFzbzRiMjNu?=
 =?utf-8?B?ejVVelEvKzVVUVRIcUpZdkFCajZNWWhOS0lqWmlWNFVTYUFablhPSDhicUpM?=
 =?utf-8?B?dHdWSXFVeit2YmJ4VS91MFpIQWRFemZqQlVWVWQzYkp5emVKQlNiOVlwQ04x?=
 =?utf-8?B?VXBBdkJkTWkzWmlyRmt3NG1YQzBXbGR6Sit6NFZnSUZwVmMrbHJDeVhONlVL?=
 =?utf-8?B?c0E3RXJieks2YUVyeHpjbjAxNGRQbUsxZUxKMWg3YXplV0pTcGo5anVDOGF1?=
 =?utf-8?B?OEZ0b25aZjQwY3VNOGwwbVN5Ym51eHhZYm12SmMzUE5kWUd5RUZQUjcxZ1Vn?=
 =?utf-8?B?bGwzRU1ERkEraXRvVE5EaHhPUWh5eXFPYkN1OWczZkZ2MzRpVi95dk8zQWZC?=
 =?utf-8?B?VzRTcVhxVjlJRUhuSjZsdGJSZHRzd0VOTkxCV3dLcWJNQ2NRM1NrTmRUdTRC?=
 =?utf-8?B?ZEg4VDdhbjBNWmh5Ymc1VWk3WFlMTUY1RFFyNW1NOVVsbTdrRmY2VlB0d2F0?=
 =?utf-8?B?aHdQL2JySllUNXgxa2VXMG1waHRBNm56Yk9xMmdPVjFxOVVqTnlMTVNXY3dr?=
 =?utf-8?B?Rm1XQTFSdW12M3BSclFHeTVpMDBDbWsrOHgvd2t0MnVFZkk0dERUYnh4VlAx?=
 =?utf-8?Q?JLRUkqP7nakWtjsi1NFR0P/Dh?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gvxkwrqWuRSaj8GyFnwlyKe7g01wnZxj5E2OxqWW45llkg6+seTQVlISAiqlGTwdRr/VwluuwThcyMA3l2o2aURDGt8BZc5hl7w+WIvim8+p5Pom3gYfsSRuyqj/4hvss0r9oKSpfrmWLpLfVKklYSNOGBGlVpphk3dag5cC4Gcif+fT6sBHRHuFt/qUeXHccLIEXrmxZyxGCsh9u/VvEYSyaW+Wjl5JxB11qiPeOWEf8iwBeUtiFAJIV/+AgYHXNrOM+35vNFmuLsYvmf7Xf2FWJKoLMsk/n6Y4jswasiyrzhGhaENRFf/7zvbSIHTV9LPDsS++K4Cht0SBHMqh7iC45dRcZArl1N0TEBJPQF3Nlw8Lww1mKp5Sv7ZMZAIx6Ybw9vg82avYTBBanIrZSg5tjaWtMHhKEVGtl0wegqQ1+tcq5FcgFh7b0el86VdvtoSMZuw0KoyNMWmEzOym0XtktAPrXw9FaM8yj4461R2Utvuz0zQBaoDbhZtGwz2/g/OZs4VRl32xJIS8HoSvdGQ2uW5EB8aJmCi6UGMMeuj9JzoVYVKytsBX2is6gtZ9eVXYwWNhWage+GyPumpzve+onz0cWiQAXFgiqrbuEp7SCTH8nJHofwwaJSwowYdmBxjLCtJM8Pm7Nchu8WoRDxMZx2CW9GpjAYw4aOmrJL7cX/5T2QKIwfii3BX8VeRnqRQ92SWQwrVYqTsMxqz4yTSNR757khk0R+X6WBT3xqToKzZpSqRmPW9145zJEwJCFYdNmpt0lWus+50ETgu7lNHNQ/Ql1fT0dxgH9w2Jdr25jUU57WHQBcpkXlorBYNLl3nXdRO7qtLf+go0KIc0vdPbyt56vOVxIaljsiljNwB6Q90tg8cyaxcu/0BujjtrkAQe6VODZL4h1/3HI+2n3g==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14d9295c-623d-4d5e-a535-08db56862950
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 03:24:02.4235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a4zCb7WnUND/YQQ5zJbgXeRnLlYrG9/yKmBLlbMxvwSlRKENwPx9LmekqlyAltdjRQuFnYI4g/VML8bnp21dew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7794
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0
 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305170027
X-Proofpoint-GUID: fxYbMyBshnYdGBI98X3lb45Js5iwyhKN
X-Proofpoint-ORIG-GUID: fxYbMyBshnYdGBI98X3lb45Js5iwyhKN
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/5/23 09:34, zhangshida wrote:
> From: Shida Zhang <zhangshida@kylinos.cn>
> 
> From: Shida Zhang <zhangshida@kylinos.cn>
> 
> This fixes the following warning reported by gcc 10 under x86_64:
> 
> ../fs/btrfs/tree-log.c: In function ‘btrfs_log_inode’:
> ../fs/btrfs/tree-log.c:6211:9: error: ‘last_range_start’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>   6211 |   ret = insert_dir_log_key(trans, log, path, key.objectid,
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   6212 |       first_dir_index, last_dir_index);
>        |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../fs/btrfs/tree-log.c:6161:6: note: ‘last_range_start’ was declared here
>   6161 |  u64 last_range_start;
>        |      ^~~~~~~~~~~~~~~~
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
> ---
>   fs/btrfs/tree-log.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 9b212e8c70cc..d2755d5e338b 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -6158,7 +6158,7 @@ static int log_delayed_deletions_incremental(struct btrfs_trans_handle *trans,
>   {
>   	struct btrfs_root *log = inode->root->log_root;
>   	const struct btrfs_delayed_item *curr;
> -	u64 last_range_start;
> +	u64 last_range_start = 0;

  Reviewed-by: Anand Jain <anand.jain@oracle.com>


>   	u64 last_range_end = 0;
>   	struct btrfs_key key;
>