Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 May 2023 20:43:30 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, idosch@idosch.org, petrm@nvidia.com
Subject: Re: [PATCH v3] net: Remove low_thresh in ip defrag
Message-ID: <20230516204330.1443bc7c@kernel.org>
In-Reply-To: <20230517001820.1625-1-angus.chen@jaguarmicro.com>
References: <20230517001820.1625-1-angus.chen@jaguarmicro.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 17 May 2023 08:18:20 +0800 Angus Chen wrote:
> As low_thresh has no work in fragment reassembles,mark it to be unused.
> And Mark it deprecated in sysctl Document.
> 
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>

We need to revert the old patch first, we can't remove the commit from
the git history because it would change all later hashes and break
rebasing.

Why are you renaming the member? Just add the comment and update the
documentation. You said you had a tested complaint, the tester will
only read the docs, right?
-- 
pw-bot: cr