Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@meta.com>
To:     "Li, Xin3" <xin3.li@intel.com>
CC:     Song Liu <song@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <kernel-team@meta.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] watchdog: Prefer use "ref-cycles" for NMI watchdog
Thread-Topic: [PATCH v2] watchdog: Prefer use "ref-cycles" for NMI watchdog
Thread-Index: AQHZiFJQA17dibxJREeMwvRcxvYa+a9dq7iAgAA2jQA=
Date:   Wed, 17 May 2023 04:38:52 +0000
Message-ID: <5DB7DD91-7213-4A30-B89E-FB28AD96F8C5@fb.com>
References: <20230516235817.2323062-1-song@kernel.org>
 <SA1PR11MB6734A17FF1E12FC3AC256C91A87E9@SA1PR11MB6734.namprd11.prod.outlook.com>
In-Reply-To: <SA1PR11MB6734A17FF1E12FC3AC256C91A87E9@SA1PR11MB6734.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1LY5PH4xuhLGWAjuwLbCM0KdsF60HrNptzZt9RcUYklgW7kzTVtrDNtoJ4Yb?=
 =?us-ascii?Q?IzSZN7JadJ2XRvbkKlCGrRbHr74AImJsMAJJMG5wS7gjhOwuSTw49/3t8W4+?=
 =?us-ascii?Q?Ip8VpSoxEVx+1Pfcl/UF5kW+hxIkt+xq2aeszF+9AciTbf5T6B8wSM7gUDKJ?=
 =?us-ascii?Q?sUC3bjgviTrTC7mVbIm1ec+ZpIWKa30lrzq5ZbWS7bcjVhIGPItsF4Qg65/z?=
 =?us-ascii?Q?dsfpv6qvHLrkboiBQtyrqTo/0PPEdaKwR+1usu1gq0FSX4sMB/6F9YXYSfiS?=
 =?us-ascii?Q?peFjk1jl6Z/3CmHVzIUOTY5jUvLw19HtxL/kF6yj27kikes1Ng7I03NEtebb?=
 =?us-ascii?Q?nYsqJ0PDh2I/K690IMKx3N5bsXf6FviwxwX5ioSyIw7L8nS/FOQ7yCN6zuch?=
 =?us-ascii?Q?xVay5SQEXFa+LGMM2IGBttob3oKitrkOQDvXBnuz23FfyFDpGKhuHfn72LHL?=
 =?us-ascii?Q?fdyKSoYDp0rxkck7wJ5x5LjlKj2fXAXBZbvVjkWDsyUs041trEBRf4vuSMk3?=
 =?us-ascii?Q?NOabjJES2aymwzxVOESDkoDH1gfaLILJP1UE9177hBLsWijnbKPdWyK9uDoa?=
 =?us-ascii?Q?W/Ml6nXGzet9uraTWK02lBKX5cTHtqsTr6MAJK410nsQita4IZJPpTc2A4hG?=
 =?us-ascii?Q?2b/KYX4yxiFM0db5Q/haVYYZEaMdkH1Qyn1CvOLYrkJLiKguYteIU9H2pCCh?=
 =?us-ascii?Q?ks2/gbNz/jPp0ASKQJZN8wbTetd63kQAACbWHUgAAZZQKwtalrmKWUQI9l9B?=
 =?us-ascii?Q?NpYRjtN9S8Txr5PTnuHj8+ki5KrTqlYbMOoL2fVJdwWrKB4RX5H2vlsQppiv?=
 =?us-ascii?Q?U5bqoZIPtj0VengYdeBY6KlEWYWF18jBPKOEWhlhAKsyM0v1sFTd7mA09UTt?=
 =?us-ascii?Q?lMiDoMeixagDGEk0dpYp9qJGtn1Fu6DnrqYT37ysXlH/Ti85i5ENBgoNVR1B?=
 =?us-ascii?Q?6OT1aASfaW7/J3QKOz0uXX41bqXzzWLZNn6iF0yEhW6SNnH5dZruMSpVF9ha?=
 =?us-ascii?Q?ptKAKlzPvqwABR4Ib/Fn7U9qVUNTv8GxRFhpU+UKZ1trht+nE9MCW3hsQxJU?=
 =?us-ascii?Q?JVEd2drrtLfiNhdqcx1WMCRi4/n5SaLqv1IsfxmyjQbqHHmJVmancBtK8bqm?=
 =?us-ascii?Q?uLacs03smyoQG3Rw1/3t8QjTDBGVPl/k3wenHKsjC9XQDjQVG9nHZkGIV8+X?=
 =?us-ascii?Q?BP5aEjR/vm+pMo5eN5KsiEAJPpyHaRlzYkull1DGf2WLtv4SFchPWvb9jYJg?=
 =?us-ascii?Q?dm/LFE63PoNbnBKDmtmO7IgK1HPlGz6UBmIcmz2RAYVgQLGo77+JdSdMfBaO?=
 =?us-ascii?Q?X1t8swa2i3+QAL/BmnD6wyffGLlk+tHT+4xpzaMBVR77t1kseETcce4sg4UC?=
 =?us-ascii?Q?ZFQr9qU0I9bp6+rBTwPNc286YeRc1fgPdlBrfqZsnllxxBYu5BMWTimeJMMw?=
 =?us-ascii?Q?tlccfSEs4UWnKMG8sz3t6LXLiAth7X/rVI+O33n9LO6CcsUaKtLKuTgu/un3?=
 =?us-ascii?Q?UJCIIWwU97p+SmFa9Sz2qfgl6KnmWXckhzWCph7yIUM+j+R514csDOB+ZmpV?=
 =?us-ascii?Q?Uf20id1hxQf/HTWSir/PbqfTqWYqFJ3KPPBgQUeP66NYqFm6ie260/+LfzYX?=
 =?us-ascii?Q?7Iz/0dutF1FkCy52+1LXe1g=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D407AAC6C2B0084BB581BB194E5D1364@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d72f8ea-140b-4c01-eac9-08db56909dff
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 04:38:52.9095
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OznY+vQfWWwrFVGS6IWK+/9LiaF8IzQ2ibVEkDBl+NyUtfMiiad/UzdDmkn1Ln7QQSs5hIrHd4q+XxxwyZdqmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB5637
X-Proofpoint-ORIG-GUID: IoZysUmhyRQoZSI4doumkHS-PJ1lih3f
X-Proofpoint-GUID: IoZysUmhyRQoZSI4doumkHS-PJ1lih3f
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 16, 2023, at 6:23 PM, Li, Xin3 <xin3.li@intel.com> wrote:
> 
>> NMI watchdog permanently consumes one hardware counters per CPU on the
>> system. For systems that use many hardware counters, this causes more
>> aggressive time multiplexing of perf events.
>> 
>> OTOH, some CPUs (mostly Intel) support "ref-cycles" event, which is rarely
>> used. Try use "ref-cycles" for the watchdog, so that one more hardware
>> counter is available to the user. If the CPU doesn't support "ref-cycles",
>> fall back to "cycles".
>> 
>> The downside of this change is that users of "ref-cycles" need to disable
>> nmi_watchdog.
> 
> From the discussion in v1, the users don't have to disable the NMI watchdog
> *permanently*, right?

The users need to disable NMI watchdog when using ref-cycles. For example:

    # disable nmi_watchdog
    sysctl kernel.nmi_watchdog=0

    # use ref-cycles
    perf stat/record -e ref-cycles ...

    # reenable nmi_watchdog
    sysctl kernel.nmi_watchdog=1

Thanks,
Song