Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wu Bo <bo.wu@vivo.com>
To:     chao@kernel.org
Cc:     bo.wu@vivo.com, jaegeuk@kernel.org,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, wubo.oduw@gmail.com
Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs: pass I_NEW flag to trace event
Date:   Wed, 17 May 2023 11:59:53 +0800
Message-Id: <20230517035953.47810-1-bo.wu@vivo.com>
In-Reply-To: <45eb63c6-a147-776a-99b5-7ac06848ede8@kernel.org>
References: <45eb63c6-a147-776a-99b5-7ac06848ede8@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uIFjZyV+inuMZMN+BS3KKIm6oYTvj623HNhmSUxenoP2rIq/bIx7+vLp4EcF?=
 =?us-ascii?Q?/aycpkPT349tzjxDJSiXyLbPP+k3WRMfnun7+SPpLQSp7kYlOIGOyd4sfULU?=
 =?us-ascii?Q?1yIWW1s/etzKfcKfNRHwxUGHAgOcrcWnFeqV939vzUvoIuT7224vO0x2NSG9?=
 =?us-ascii?Q?aCWBarNBcQFyR8kKnqoyCFnsEQuB1g7q2fDdwgsthghLB/8fhag7Kwn3bsiD?=
 =?us-ascii?Q?aGju500AdMcYKJH0heXNSct1E/h0TM3pXRV1zR3eCHKLju2F5t2a2iJwlkhP?=
 =?us-ascii?Q?SH4iT8qDGMv9R9tcgDfQCmuhIx4V7rhZBoiT8QZtSTqWhNmsZXVNQJgYRqF8?=
 =?us-ascii?Q?XRZJiNo5IrVSSkXI22SAupYGWcRaQLDbh1Vc5ejiqs2MvBJq0BJpQr4qRouv?=
 =?us-ascii?Q?N9l9OU/wqTDaHBHaIxEwH+//cuANSUqaVbUgA5NUJp+rFde+ovC60bsO7fAl?=
 =?us-ascii?Q?BV2LTBmy8DA3y7LwwMltoARmMacOPizX69YlPdZJjRQa9LmMD+aogble/of1?=
 =?us-ascii?Q?S/Pl9GX63lRPQ7GL2TBLsecGKRdSZBoTSIo5Spyr+vWKDNrteqgaADzCKDW5?=
 =?us-ascii?Q?BEngnQVAA/gTYRO29kswOo+YAjrVni2vh43L0y8YCZraappSAUmwMdveoMdp?=
 =?us-ascii?Q?td3o+533SKCj3uAw4G8+8ddwwYbEHmoNVTiLo7RNwP/VKvC8t3J5XTJk1Mt9?=
 =?us-ascii?Q?OyevEiniMpvnuPXcNCiix8HA5lDR/z1GOGr025mOBuKzf43MK8wc5xgsH3kl?=
 =?us-ascii?Q?7z8+ZdZqYweuS4K49h2feYyzn8SyGSCqcNjofxRHFT1SS1MI36PrjmQrHfB2?=
 =?us-ascii?Q?+pVN7z4b/7+464DONsey2B1EO8jnU+tLZZ4WMWTN8OvbRiRfcQgM+wPNaw1+?=
 =?us-ascii?Q?UQmfcr2f+5V+2vo3HonENAtmOfJONz5+4HX4WoNULTPqTH/pMZZixu9GLJHe?=
 =?us-ascii?Q?ToyJU0G5C4nzRcj/N5bBq8PPE/HsyFJJmVQZe46bU5Hg5EUj+csHNueYtOfV?=
 =?us-ascii?Q?YZZt15f+tsCuKnexU2s/g9DpWprmh1aWUjwFGLbYBa7c8pzptJx7E7tnC5Q6?=
 =?us-ascii?Q?SzzCVJSQ9TTUVSHy1uK4V11BR5kRB02RlPQvGYPn0ZEfrOPrcMr3whvleyeF?=
 =?us-ascii?Q?LOcxHb8+AZk7tHJV1rNCuG6osK2bz893k7W+BLVF7sparRQiWvXW98hMoTTT?=
 =?us-ascii?Q?Xj+GZY2pM9dKU4a3K0QuPaYqMqORY5WK5NWCsL865z7W/aKk7r14eRmbo3Eu?=
 =?us-ascii?Q?u3r1PJP8JWhZyU9X6OBNV72xYtgNqOLiB6hQt3yY2CiV0MtH486u1xHPO2qS?=
 =?us-ascii?Q?BTRUjRSefNU+JJKALYJyuWR4l+Jpzb1ZahK0OyM9r7aX0av7ErabY+D2P8rQ?=
 =?us-ascii?Q?PCrg0HRQnlkSCYmu0sdjQJ+JPTmnyjhFX7pxRZ2QArYDaCakK40jpFsT1TOY?=
 =?us-ascii?Q?6o8tt1AH9pIbXML2mRc2JHBOJLYf9skAWzh6PivFNbu1aYbGbfX+iJDqi+MK?=
 =?us-ascii?Q?h2BczBbNifeulmivQSBZaPGqm6jceD+XUqhWX33KRZct3FAp/vI74GZVO2aJ?=
 =?us-ascii?Q?pfQdihkmuQUXK42xOd63Nm1HPR7uBLdOHBfsoMY9?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b2e720a-6aa6-46cc-b17f-08db568b309a
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3017.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 04:00:02.3044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 05tXIJ/CTyAhCzcvsq22mmvu0VtJao/2LiLwdmnctqfUrVs5vzkhzuWFPliFrnYcT7yf7AxRq00RnmlDJ0z8CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3988
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/5/17 10:44, Chao Yu wrote:
> On 2023/5/16 20:07, Wu Bo wrote:
>> Modify the order between 'trace_f2fs_iget' & 'unlock_new_inode', so the
>> I_NEW can pass to the trace event when the inode initialised.
>
> Why is it needed? And trace_f2fs_iget() won't print inode->i_state?

When connect a trace_probe to f2fs_iget, it will be able to determine whether
the inode is new initialised in order to do different process.

>
> Thanks,
>
>>
>> Signed-off-by: Wu Bo <bo.wu@vivo.com>
>> ---
>>   fs/f2fs/inode.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
>> index cf4327ad106c..caf959289fe7 100644
>> --- a/fs/f2fs/inode.c
>> +++ b/fs/f2fs/inode.c
>> @@ -577,8 +577,8 @@ struct inode *f2fs_iget(struct super_block *sb,
>> unsigned long ino)
>>           file_dont_truncate(inode);
>>       }
>>   -    unlock_new_inode(inode);
>>       trace_f2fs_iget(inode);
>> +    unlock_new_inode(inode);
>>       return inode;
>>     bad_inode:
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>