Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <373ce50d-37ab-5c25-c50b-20e4f6ae6859@ti.com>
Date:   Wed, 17 May 2023 10:06:03 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Remove unneeded syscon
 compatible
Content-Language: en-US
To:     Andrew Davis <afd@ti.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230516184626.154892-1-afd@ti.com>
 <20230516184626.154892-2-afd@ti.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20230516184626.154892-2-afd@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/05/23 00:16, Andrew Davis wrote:
> This node's register space is not accessed by any other node, which
> is the traditional use for the "syscon" hint. 

Unfortunately that's not the case across SoCs. Eg AM65x See  TRM section
Table 5-582. CTRLMMR_EPWM0_CTRL Register Field Descriptions

TB_CLKEN is clubbed with SYNCIN_SEL and ePWM tripzone configuration
signals which may require register to be shared with other drivers in future


> It looks to have been
> added here to make use of a Linux kernel helper syscon_node_to_regmap().
> The Linux driver now uses a more appropriate helper that does not
> require the hint, so let's remove it from the binding.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml     | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> index 66765116aff5..64b8bce5962c 100644
> --- a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> @@ -16,7 +16,6 @@ properties:
>            - ti,am654-ehrpwm-tbclk
>            - ti,am64-epwm-tbclk
>            - ti,am62-epwm-tbclk
> -      - const: syscon
>  
>    "#clock-cells":
>      const: 1
> @@ -33,8 +32,8 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    ehrpwm_tbclk: syscon@4140 {
> -        compatible = "ti,am654-ehrpwm-tbclk", "syscon";
> +    ehrpwm_tbclk: clock@4140 {
> +        compatible = "ti,am654-ehrpwm-tbclk";
>          reg = <0x4140 0x18>;
>          #clock-cells = <1>;
>      };

-- 
Regards
Vignesh