Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: multipart/mixed; boundary="------------6RiRB9aWvOzrHmmlk1Za6Ipu"
Message-ID: <bea72de9-5f97-16a9-6703-05789ed53c1d@nfschina.com>
Date:   Wed, 17 May 2023 13:14:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH net-next] net: bna: bnad: Remove unnecessary (void*)
 conversions
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     rmody@marvell.com, skalluru@marvell.com,
        GR-Linux-NIC-Dev@marvell.com, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
From:   yunchuan <yunchuan@nfschina.com>
In-Reply-To: <20230516201739.21c37850@kernel.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------6RiRB9aWvOzrHmmlk1Za6Ipu
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


在 2023/5/17 11:17, Jakub Kicinski 写道:
> On Wed, 17 May 2023 10:27:05 +0800 wuych wrote:
>> Pointer variables of void * type do not require type cast.
> What tool are you using to find these.
> How many of such patches will it take to clean up the entire tree?


I use the scripts I found on the  kernel Newbies to find these.

website: https://kernelnewbies.org/KernelJanitors/Todo/VoidPointerConvs


--------------6RiRB9aWvOzrHmmlk1Za6Ipu
Content-Type: application/x-perl; name="type-convs.pl"
Content-Disposition: attachment; filename="type-convs.pl"
Content-Transfer-Encoding: 7bit

#!/usr/bin/perl
# This scripts goes through the kernel sources and
# prints assignments of (void*) functions that
# get type-changed:
#   type *x = (type*) function().
# The first argument is the kernel source directory, additional 
# arguments override the embedded function name list.


$kernel_dir=shift || die "Need a directory argument (kernel sources),\n" .
"and optionally function names.\n" .
"If none are given, a default list is taken.\n";

# Get source files
@ARGV=split(/\0/, `find "$kernel_dir" -type f -iname "*.c" -print0`);
die "No sources found.\n" unless @ARGV;

# Read whole files, and look for such assignments.
$/=undef;
while (<>)
{
	$changes=0;
#		- struct netdev_private *np = (struct netdev_private *)dev->priv;
#		+ struct netdev_private *np = dev->priv;
#	or just
#	   lp = (struct i596_private *) dev->priv;
	$changes++ while 
		s{ 
			( (?: struct \s+ \w+ \s* \* \s*)? \w+ \s+ = ) \s* 
				\( [\w\s\*]+ \* \s* \) \s* 
				( \w+ \s* -> \s* priv(?:ate)? \s* ; )
		}{$1 $2}xgo;

	if ($changes)
	{
		open(DIFF, qq(| diff -up --label "$ARGV" "$ARGV" --label "$ARGV" -)) 
		|| die "Cannot start diff program: $!\n";
		print DIFF $_;
		close DIFF;
	}
}

--------------6RiRB9aWvOzrHmmlk1Za6Ipu--