Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i494840e7:Fastmail
Date:   Wed, 17 May 2023 09:00:37 +0300
From:   Ido Schimmel <idosch@idosch.org>
To:     Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        netdev@vger.kernel.org, dsahern@gmail.com, shuah@kernel.org,
        pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
        davem@davemloft.net
Subject: Re: [PATCH] selftests: fib_tests: mute cleanup error message
Message-ID: <ZGRthdt5u88zs6xy@shredder>
References: <20230517041119.202072-1-po-hsu.lin@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230517041119.202072-1-po-hsu.lin@canonical.com>
Precedence: bulk

On Wed, May 17, 2023 at 12:11:19PM +0800, Po-Hsu Lin wrote:
> In the end of the test, there will be an error message induced by the
> `ip netns del ns1` command in cleanup()
> 
>   Tests passed: 201
>   Tests failed:   0
>   Cannot remove namespace file "/run/netns/ns1": No such file or directory
> 
> Redirect the error message to /dev/null to mute it.
> 
> Fixes: a0e11da78f48 ("fib_tests: Add tests for metrics on routes")

I don't think this tag is correct. More likely that this is caused by
commit b60417a9f2b8 ("selftest: fib_tests: Always cleanup before exit").

You can even reproduce it with '-h':

# ./fib_tests.sh -h
usage: fib_tests.sh OPTS
[...]
Cannot remove namespace file "/var/run/netns/ns1": No such file or directory

Reverting the commit I mentioned makes it go away.

Also, please use "PATCH net" prefix:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#tl-dr