Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1706035rwd; Tue, 16 May 2023 23:30:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4W3YF6Ekv70fhS0fdP8m9fzDP52B2E1FEDUbQwiueir39rNbydcoSvIuehykacuN7PpY9C X-Received: by 2002:a17:902:d2c9:b0:1ac:61ad:d6bd with SMTP id n9-20020a170902d2c900b001ac61add6bdmr43197630plc.65.1684305034469; Tue, 16 May 2023 23:30:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684305034; cv=none; d=google.com; s=arc-20160816; b=RTT+igHDaqJ0jS/fAWwhL8nxrc7A2UiEYw6AQ+rnGv+8T3pD/iZQMkIpFyf6coSD5M /AYiy54hFjTdrEswq3LWn0hGZ1J7ShapdvFz4ltvTSRh2Mx/NCt0WIZR3nXyX1q9TDaP /8TokdX3p+Eg8egCfVSTYH8Ucgaz9pd5FgpdzLElrsbJZvBfu8fGujN35qyw7IC59nRw rQ8YdzmlktcjfobKGDAOnlMahIOzrE/+GsOR1UL2NlBB0c/3tTSmmphZolzOWqqU+eK2 p6zCk14AskfPQU7eb1QGQQyMHCDwNNTuD0UuoQVyrV3aChVT65K9udehuRskxAHoDoq4 5XIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CG6yKkcSAXmTuFHjKJxYYVG+vMb17/IxBz/Znck1z2k=; b=sBcJtjbIaEGr80Yu2WCNmLAuV4ud/dBrDIQjQpeXA/85UsoSIKDvFGa/T5apjbK3dk KhLKdyUIVndUyLXLqqBAMu+H0hrl6ByC8VIhCMmSW7sSnCMMrU+ccpI9BUfEHbqNiEA0 Qhwr0un7pamsel2Wj5f8cWyHsuLcr6o8mdqaZY77UaAnbDyprbskcG26Lrc6Ls1oNsCt g7Cped00KoA7VHLwJfsD7BmmoUabzL9cXQak0UKdaZr0yxl2Q1YdF2npyGTDCOpIIQ6a GYTTzFbm3VNtuTNn50Nmb//KqQ+RGgxH/3HdStxuaMrptphm1kkkMxwKEBVlaxu8r7vJ GS0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=y7xtAHQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o18-20020a170902779200b001a99941abbfsi19982914pll.338.2023.05.16.23.30.21; Tue, 16 May 2023 23:30:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=y7xtAHQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232291AbjEQGS6 (ORCPT + 99 others); Wed, 17 May 2023 02:18:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbjEQGSx (ORCPT ); Wed, 17 May 2023 02:18:53 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A04F52735 for ; Tue, 16 May 2023 23:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CG6yKkcSAXmTuFHjKJxYYVG+vMb17/IxBz/Znck1z2k=; b=y7xtAHQVU4tkYSmSVfuwQ0Jnrs iPGaJm5VeifNYA5qMSu3pYT1HSgqq/ztIxbl7aayvuqu52zUcZIk1CjPNlAbv8tkr7TreZYy2YlV3 f/D6z0pM94aTlNkwPKalADYYdsZAGP0inNu6uV1delhWWc7NzZAMQSnQABk6rnUZ8Ojo9ySSNTTg7 ZRJpngPiWbzeTcTM7k9uVqUdoW5CIMWMIsNYBGkDEaIl+XEqPdUSL0JsENdFwz8WP3EuAbYzetMY6 Iprh1KwSO2y5Vl0ILl+2jw/1Jac79IYg6HelJ6X7eTNS4wKBXvWByYtXX0O8ogv+NAb/0RY63dpQY GH37AvaA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAUi-008OgF-1J; Wed, 17 May 2023 06:18:40 +0000 Date: Tue, 16 May 2023 23:18:40 -0700 From: Christoph Hellwig To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev Subject: Re: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code Message-ID: References: <20230511132113.80196-1-ryan.roberts@arm.com> <20230511132113.80196-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230511132113.80196-2-ryan.roberts@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2023 at 02:21:09PM +0100, Ryan Roberts wrote: > It is bad practice to directly set pte entries within a pte table. > Instead all modifications must go through arch-provided helpers such as > set_pte_at() to give the arch code visibility and allow it to validate > (and potentially modify) the operation. Looks good: Reviewed-by: Christoph Hellwig