Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1724940rwd; Tue, 16 May 2023 23:54:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7XxuIxUpyE1KSSqOH1w3j9JR2uKyoS4mZMzqhgWovR0uh1ZLWxz6wiyyfFdYptVFqeUmKL X-Received: by 2002:a17:90b:4c8c:b0:252:8910:db42 with SMTP id my12-20020a17090b4c8c00b002528910db42mr21400301pjb.1.1684306443283; Tue, 16 May 2023 23:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684306443; cv=none; d=google.com; s=arc-20160816; b=uellpXiIWwKvkN8KReZqFiQ4nnVflzN6yTl/xIU1aWUd1Z4j51K57Q/flJGJ0TSvFv XtGeeBqSIDIwjsi8tw9HceS5W8NvdZL/2HcIQUNXMkp5AiO2an+6aj4m2LkywWB10NLv XGmVjdHyEG6SWdOL1eVX5dmtrcdfxFEAtVJwMCIIe8B1WLl2dep3Gk1Aip3dTn53CZw7 EBm/fzU1mj2nk6vAm5MXLO+J52hsZZrHFzUo9CYiSm+K2XyOAzq6bONpILwHtiNsspTd NL18NGQcvR99Fd+E4+tkzwa+UWqifQTQsOCOaSiPoVRk577eqKiO8jS+QmKfIl5klt2P ee5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mxkdlDqyUpwq2T00umhrhBcnqh9XBG0TKSm9fXSA9Sc=; b=oNpz650ofOSMUTao8GC2oibYfJ2aVG32x8tKoPDnRl2Qkvb/xVxMaTVIzA5z512JIH LtD0clkFfUTKnPqgQZFcAbd6Xk8g6854lPgTGrgAsa1NWaFsh0chbuAspOk1yuj1jlFy niMH7l+CAntSTYqHbm0/bDUnutavQj2lkJ2VbEaiWPUseV+BszK+bNjQqcs03ygy/dq2 2afff+344Qn8jg5IU2TBa7VsQyGUBkroWLb7f+QSQRgoGob8PIy6D9xLHuHcsAGpkR9z OUCQ4CzbOtqYkkUtR60nFKVB6V8iUaWwMxP7htn5xevCu1YTRcqetOE1V/+Nso6K3OWR WqlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Izlvxhjb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020a170902e54500b001a8173f468fsi22367289plf.314.2023.05.16.23.53.48; Tue, 16 May 2023 23:54:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Izlvxhjb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232646AbjEQGdL (ORCPT + 99 others); Wed, 17 May 2023 02:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232499AbjEQGdI (ORCPT ); Wed, 17 May 2023 02:33:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26440359E; Tue, 16 May 2023 23:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mxkdlDqyUpwq2T00umhrhBcnqh9XBG0TKSm9fXSA9Sc=; b=IzlvxhjbxQwrfiXgp7vofG8iRA 3rSVv47naGjy5yBlsCXmBFo0P9BGl4m1f0VVw4LUzJnErB+de4aK+BFgWRpTGgdC4pfm/uFJU4Dlh 0Hu2ZymcFCRd9WHxlZ9qMDbIkfui0s2xxNNgaMTvS1EOChnS3j0ixKLfKexwHyMQbwk2/PSpSYaFw dauSVuDbeVqiWqwt085XxovPwY4LfcOIsv/SzWhAet5ERSxhPfBArznjMkhzGygvFOtQ0pFWACOPi ZLXtnKcURHR5uJ9LY1DjW4ebmWgvjd2dqeHyU5e4JsXgDfiPBeE8OfnOOqPJnq68B3CqfQtNEiZVQ JSzI/lOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAig-008Tw8-0Q; Wed, 17 May 2023 06:33:06 +0000 Date: Tue, 16 May 2023 23:33:06 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, linux-ia64@vger.kernel.org Subject: Re: [PATCH v5 RESEND 08/17] ia64: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-9-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-9-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#define ioremap_prot ioremap_prot > +#define ioremap_cache ioremap > #define ioremap_uc ioremap_uc > #define iounmap iounmap Same comment about the placement here, I'm not going to repeat it if it shows up in more patches. Otherwise looks good: Reviewed-by: Christoph Hellwig