Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <424735804fa1cfabf3b1d76b4b3dd9162f4338a8.camel@maquefel.me>
Subject: Re: [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Arnd Bergmann <arnd@kernel.org>, Linus Walleij <linusw@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 17 May 2023 12:29:21 +0300
In-Reply-To: <20230517061355.5o2ksfkpupsbpuha@pengutronix.de>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230424123522.18302-37-nikita.shubin@maquefel.me>
         <20230515143222.dlhxcze5254773r4@pengutronix.de>
         <f43addc54fd6bafca831d2f2802cc09c4e5baef9.camel@maquefel.me>
         <20230517061355.5o2ksfkpupsbpuha@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

Hello Uwe!

On Wed, 2023-05-17 at 08:13 +0200, Uwe Kleine-K=C3=B6nig wrote:
> Hello Nikita,
>=20
> On Tue, May 16, 2023 at 01:43:27PM +0300, Nikita Shubin wrote:
> > On Mon, 2023-05-15 at 16:32 +0200, Uwe Kleine-K=C3=B6nig wrote:
> > > On Mon, Apr 24, 2023 at 03:34:52PM +0300, Nikita Shubin wrote:
> > > > diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-
> > > > ep93xx.c
> > > > index 8bfe6cfbb3db..657adb011aeb 100644
> > > > --- a/drivers/pwm/pwm-ep93xx.c
> > > > +++ b/drivers/pwm/pwm-ep93xx.c
> > > > @@ -45,20 +45,6 @@ static inline struct ep93xx_pwm
> > > > *to_ep93xx_pwm(struct pwm_chip *chip)
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return container_of=
(chip, struct ep93xx_pwm, chip);
> > > > =C2=A0}
> > > > =C2=A0
> > > > -static int ep93xx_pwm_request(struct pwm_chip *chip, struct
> > > > pwm_device *pwm)
> > > > -{
> > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct platform_device *=
pdev =3D to_platform_device(chip-
> > > > > dev);
> > > > -
> > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return ep93xx_pwm_acquir=
e_gpio(pdev);
> > >=20
> > > I didn't get the whole series and didn't spot a relevant followup
> > > change
> >=20
> > https://lore.kernel.org/all/20230424123522.18302-1-nikita.shubin@maquef=
el.me/
>=20
> Yeah, I looked there, but didn't find it. Applied the whole series
> now
> and found "ARM: ep93xx: soc: drop defines". A few things I noticed
> while
> doing so:
>=20
> =C2=A0- git am warns about new blank lines at EOF in several patches.
>=20
> =C2=A0- b4 am 20230424123522.18302-1-nikita.shubin@maquefel.me
> =C2=A0=C2=A0 warns about broken DKIM signatures. The copy I got directly =
via Cc
> is
> =C2=A0=C2=A0 OK though. The relevant problem is that your To: header is e=
mpty
> but
> =C2=A0=C2=A0 part of the signed payload + the copy I got via vger.kernel.=
org
> had
> =C2=A0=C2=A0 the To header mangled to
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To:=C2=A0=C2=A0=C2=A0=C2=
=A0 unlisted-recipients:; (no To-header on input)=20
>=20
> =C2=A0=C2=A0 This results in:
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$ curl -s
> https://lore.kernel.org/lkml/20230424123522.18302-37-nikita.shubin@maquef=
el.me/raw
> =C2=A0| dkimverify
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0signature verification fa=
iled
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$ curl -s
> https://lore.kernel.org/lkml/20230424123522.18302-37-nikita.shubin@maquef=
el.me/raw
> =C2=A0| sed 's/^To:.*/To:/' | dkimverify=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0signature ok
>=20
> =C2=A0=C2=A0 I don't know who is to blame here (i.e. is an empty To allow=
ed?)
> but
> =C2=A0=C2=A0 I'd recommend to put the people you want to merge the patche=
s into
> =C2=A0=C2=A0 the To header anyhow.
>=20
> > > on lore.k.o, so: I assume ep93xx_pwm_acquire_gpio() and
> > > ep93xx_pwm_release_gpio() will be unused in the end? Do you drop
> > > them?
> > >=20
> > > I assume this series target to be taken via arm-soc (once the
> > > review
> > > feedback is positive)?
>=20
> You didn't reply to that one. Still assuming this to be true, I'll
> mark
> this patch as handled-elsewhere in the PWM patchwork.

Oh sorry about that, yes the current plan is taking the whole series at
once, when acked by.

>=20
> > > I wonder if this change breaks non-dt machine support?
> >=20
> > The aim for the whole series is fully converting to dt, this means
> > platform files will be dropped.
> >=20
> > The v1 series tries not to break anything until platform removal
> > commit, before this commit non-dt version should be compilable and
> > fully functional.
>=20
> OK, the pwm patch looks fine to me,
>=20
> Acked-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> Best regards and thanks for your efforts,
> Uwe
>=20