Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1729233rwd; Wed, 17 May 2023 00:00:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bdNnk0cQ72Tv0gqQaXl0mFYBe1Hrf5BKgujlBcxa5hFWk5ikyKzr+3Kf9esR8u2OoOzq/ X-Received: by 2002:a05:6a20:2587:b0:109:1310:958b with SMTP id k7-20020a056a20258700b001091310958bmr183999pzd.37.1684306811065; Wed, 17 May 2023 00:00:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684306811; cv=none; d=google.com; s=arc-20160816; b=tTlhKOoqud/PSvmtO+/4Ml1dxaN3S9h+5S9Uy0NXqpIaa9Zj0RJkxvGPg3eNVocmbS Ey3EvIFC85oyenFNuszFZxZ4uOB9ZsYXg4E135EFiCh+UhgZAlPLQVL3Vm4zMjs6vPAu OEAIH7pOHciAsP2qtdktvfvhOUuEYYOgFepXPTgalxWbwCLmWPIpULfp91FQk7S4ft3/ oER6OUh3ji0yzeKjiTeHdOzXMsWcaOqGthDecMQamNHhnQ0lXelATmNtSMyRG9UHPxfn cLJKbEUIq2yJQLThidEb2dqfal5rxXbsp5hRAHFvuqubWZjzfZ8iABXwgh3CYrcrDEMD EdkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=R+bia8kNOnh/zzckPz9KIXCK6j55WEZoqDL73kF/+sg=; b=Aa/pZsGw4HQm9T0+VnaqhVIu11/RfgNgcyM8V1K6n+hH6hlSW2Ni9VTdS4j/g3D0dK Fb2jKkudR8E0ItyydaGYNHg2TEt6CudAa/HQJIDQGt2rumolbonr/Rh7SSkiwGY6sLji iV6I4kgb/0z+IFIIyvJUVDSDLYfTyGYtK8eb5z2GyJ0HmBRVrHYBJlXIYkvMx8mdw+/0 GSHG2neuDUPWApsyrtl/lu6KjpKVGeh5k++AQB1tJYvFAwO1dZq3YDWuHOwyboDYxgmL 8WpQ5QYg1R4igBPJ+lxH6v6CtGFZKxnfPRxF+S+R2vWMWKZRU0RXMEFhfiq0ikBQ/tHW qnGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="cFu/rKWG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e63-20020a636942000000b0052132a8e4e3si18729649pgc.510.2023.05.16.23.59.58; Wed, 17 May 2023 00:00:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="cFu/rKWG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232533AbjEQGb4 (ORCPT + 99 others); Wed, 17 May 2023 02:31:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbjEQGbz (ORCPT ); Wed, 17 May 2023 02:31:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7987435A0; Tue, 16 May 2023 23:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R+bia8kNOnh/zzckPz9KIXCK6j55WEZoqDL73kF/+sg=; b=cFu/rKWG4aO9DRAq9O4fdaCYuJ lC1p/EPe09ZjM+Kwuh3kG/tHsPA7KpSfPG3f/ETB71jX81whefhm7MjZT7HQgppLozACG7eNAmAGs UZdqpa3pypr03b69y93R0MdXcjh1CefbD5hNoFMnCiHruzxM7YvO23QVu/wvLFglpzr0w/Yzdxa1c O8t74JrYxS+8eY2MeeeIBL6rMJhHT2crq8FAe9CsAeqB5YTnBPdIqfRlKXpb3nPSNqN2qZwhk9c+W BOuIGzvDfvMISQnfs5Z7NJJGdkCP4ATb7xmSbESVAb4ncjEXyiZdbkkVU0AvizH30Kx8Cc7UId3fT c4LcH0Fg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAhS-008ThE-2J; Wed, 17 May 2023 06:31:50 +0000 Date: Tue, 16 May 2023 23:31:50 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Vineet Gupta , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-8-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#define ioremap ioremap > +#define ioremap_prot ioremap_prot > +#define iounmap iounmap Nit: I think it's cleaner to have these #defines right next to the function declaration. Otherwise looks good: Reviewed-by: Christoph Hellwig