Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230516200516.554663-1-arnd@kernel.org>
In-Reply-To: <20230516200516.554663-1-arnd@kernel.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 17 May 2023 09:06:10 +0200
Message-ID: <CACRpkdZvizr_gFHjAPzzmAtjugu4_gO_g53-BurG4+2j8cwfYQ@mail.gmail.com>
Subject: Re: [PATCH 1/5] irqchip: ftintc010: mark all function static
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 16, 2023 at 10:05=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wr=
ote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> Two functions were always global but never had any callers
> outside of this file:
>
> drivers/irqchip/irq-ftintc010.c:128:39: error: no previous prototype for =
'ft010_irqchip_handle_irq'
> drivers/irqchip/irq-ftintc010.c:165:12: error: no previous prototype for =
'ft010_of_init_irq'
>
> Fixes: b4d3053c8ce9 ("irqchip: Add a driver for Cortina Gemini")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

It's a leftover from when this was called from boardfile code.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij