Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3ab922a4-255a-5aef-86ba-d906819f0f3a@linaro.org>
Date:   Wed, 17 May 2023 08:10:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] MTD SPI-NOR: BUG FIX of divide by zero in new n_banks
 value
Content-Language: en-US
To:     Todd Brandt <todd.e.brandt@intel.com>, miquel.raynal@bootlin.com,
        linux-kernel@vger.kernel.org
Cc:     todd.e.brandt@linux.intel.com, pratyush@kernel.org,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
References: <20230516225108.29194-1-todd.e.brandt@intel.com>
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
In-Reply-To: <20230516225108.29194-1-todd.e.brandt@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi, Todd,

On 5/16/23 23:51, Todd Brandt wrote:
> While testing 6.4-rc1 on our Lenovo Thinkpad X1 I discovered
> that freeze, suspend, and shutdown, all hang the system. I bisected
> it to an addition made to the MTD spi-nor code.
> 
> The new "n_banks" value is being divided into without a proper check..
> Thus on certain systems this causes a divide by zero hang.
> 
> Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217448
> Fixes: 9d6c5d64f028 ("mtd: spi-nor: Introduce the concept of bank")
> Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> ---
>  drivers/mtd/spi-nor/core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 0bb0ad14a2fc..084117959be4 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2921,7 +2921,10 @@ static void spi_nor_late_init_params(struct spi_nor *nor)
>  	if (nor->flags & SNOR_F_HAS_LOCK && !nor->params->locking_ops)
>  		spi_nor_init_default_locking_ops(nor);
>  
> -	nor->params->bank_size = div64_u64(nor->params->size, nor->info->n_banks);
> +	if (nor->info->n_banks > 0)
> +		nor->params->bank_size = div64_u64(nor->params->size, nor->info->n_banks);
> +	else
> +		nor->params->bank_size = 0;
>  }
>  
>  /**

Indeed, thanks for the report and patch. You probably use the
spi-nor-generic driver, don't you?

Can you try the following change instead?

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
                      index 0bb0ad14a2fc..37f750bd7bfb 100644
--- a/drivers/mtd/spi-nor/core.cdrivers/mtd/spi-nor/core.h
+++ b/drivers/mtd/spi-nor/core.cdrivers/mtd/spi-nor/core.c
@@ -2018,6 +2018,7 @@ static const struct spi_nor_manufacturer
*manufacturers[] = {

 static const struct flash_info spi_nor_generic_flash = {
        .name = "spi-nor-generic",
+       .n_banks = 1,
        /*
         * JESD216 rev A doesn't specify the page size, therefore we need a
         * sane default.