Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1773156rwd; Wed, 17 May 2023 00:50:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ72jcGU9aeyibznas52NVc0KN+OWFjhQDjkMnaxY2un7S+ulxb4fr95KCTXBoIZyz0XbrGY X-Received: by 2002:a17:90a:2a47:b0:253:3118:1ba0 with SMTP id d7-20020a17090a2a4700b0025331181ba0mr3570961pjg.11.1684309823115; Wed, 17 May 2023 00:50:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684309823; cv=none; d=google.com; s=arc-20160816; b=YLEfzzElEmhq0T60ei15SUEJMfaBIVLEDPCQrUrV3PGJk/k4rbdEqPJ1E8EZIHMpsa Bhm7lhatqsJ7mmtrRXcOgGG2/hxpj2txBSdPqzHxYz/YEH74vcEalsE+gCXFfrzOzi3p uHbk5Olk6PFEKB2d4NIQkWi97JcBiS/5aMJG5Ttq4VcqCl5RZFeuWMjWlS5476QL0yxC Q/dXx1uxSVjI68hTn/TkNm3L/7rjfB+wwlWnRGNNXEXO+9weslh6bSuIqTX35ZFdvoCL mMkFZ/OdQLzK+85biaAK8WTXDmTDrDCfkTxV9nDmDPFk0NAgJsfXnbKk3CJMWxSkzlNf ef8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BXLZ+yEa82RxkW3QXxkSn4CuUde79k4TvT+xYUt2yR0=; b=1GmVqxq8cKFGZwWTTAYa5rIGxcHunH3nCiw436l2qAVZrx0oOIodC6ezAyRnpp0Ug7 0k2Q4DUIrhMFyZJRrRo6WFPV7/mhGs8TTVPGvNyjOtglHp8DSCXmndQmzy2O4uT9II7t dagjOZt8be5SZSM8BYS8Uvj9p7GYJMc8BW7bGnj6WKEal+0j+kzhGq61mHuhpqMn6nv/ jCuyF6KhVXKTSZDS5zQoj1xFdpuihh6cYyDd0ABjWIdA+CcgTKom5bHCyQ3D8MzKfgAA UBLw43nbLO7xxtCQWcAbQhbDoF0Cr8rfblQkTaXA4D77+tb1HwQmjdsEGLVOdZcy/3Ng vBHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="j8Oc/5Af"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020a17090a868a00b002505f319c27si1151106pjn.100.2023.05.17.00.50.08; Wed, 17 May 2023 00:50:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="j8Oc/5Af"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbjEQHjk (ORCPT + 99 others); Wed, 17 May 2023 03:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbjEQHjj (ORCPT ); Wed, 17 May 2023 03:39:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADFB2DA for ; Wed, 17 May 2023 00:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BXLZ+yEa82RxkW3QXxkSn4CuUde79k4TvT+xYUt2yR0=; b=j8Oc/5AfxoC4ZTxrm8OxtCPW89 AGSE8ZI/sITlQVr3lH/MGL+wGFdkBbVkgxdzJ0SN09+8RXlto0WaU/tdqa9qfwmcFrq5nmSmhU5mA 3xTrWuRO8IQ9rZFUFxzv9fP0H9fxAPQODjDNvWZd7oFhsZ5rTviRzIFpk1juA38sdWRID68YhEJUV W5ph04GCfXSLlEjH6FNTVeQs4+IBnLFqRmoQw4B9sH5DCtqTblh/k6m0y4PFLzxzJ2AE7Vbx3r1rx NRaLxkgtltk9/yf5rfYQGndxwT/GFIRF0jsjdpQqg5DVuXFd0jxfU5MgBmvT0o6T1rVAdVNxLkc+D Z4JmZD5w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzBkp-008hYG-1F; Wed, 17 May 2023 07:39:23 +0000 Date: Wed, 17 May 2023 00:39:23 -0700 From: Christoph Hellwig To: zhenwei pi Cc: stefanha@redhat.com, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] virtio: abstract virtqueue related methods Message-ID: References: <20230517025424.601141-1-pizhenwei@bytedance.com> <20230517025424.601141-2-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517025424.601141-2-pizhenwei@bytedance.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2023 at 10:54:23AM +0800, zhenwei pi wrote: > All the vring based virtqueue methods could be abstratct in theory, > MST suggested that add/get bufs and kick functions are quite perfmance > sensitive, so export these functions from virtio_ring.ko, drivers > still call them in a fast path. Who is going to use this? And why do you think every virtio users would want to pay for indirect calls just for your shiny new feature? This seems like an amazingly bad idea to me.