Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <723b9f11-d427-6c5d-5d99-969550244129@gmail.com>
Date:   Wed, 17 May 2023 14:43:30 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] EDAC: Expose node link in sysfs if CONFIG_NUMA
Content-Language: en-US
To:     Yajun Deng <yajun.deng@linux.dev>, bp@alien8.de,
        tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
        rric@kernel.org, corbet@lwn.net
Cc:     linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        linux-doc@vger.kernel.org
References: <20230516080748.3155788-1-yajun.deng@linux.dev>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20230516080748.3155788-1-yajun.deng@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/16/23 15:07, Yajun Deng wrote:
> +
> +What:		/sys/devices/system/edac/mc/mc*/node*
> +Date:		May 2023
> +Contact:	Yajun Deng <yajun.deng@linux.dev>
> +		linux-edac@vger.kernel.org
> +Description:	When CONFIG_NUMA is enabled, a symbolic link that points to the
> +		corresponding NUMA node directory.
> +
> +		For example, the following symbolic link is created for node0 on mc0
> +		and mc1:
> +

"For example, on node0 with two memory control directories mc0 and mc1
the symlinks are::" (I prefer using literal code block here).

> +		/sys/devices/system/edac/mc/mc0/node0 -> ../../../node/node0
> +		/sys/devices/system/edac/mc/mc1/node0 -> ../../../node/node0

Or bullet lists should better fit listing above?

> +
> +What:		/sys/devices/system/node/node*/mc*
> +Date:		May 2023
> +Contact:	Yajun Deng <yajun.deng@linux.dev>
> +		linux-edac@vger.kernel.org
> +Description:	When CONFIG_NUMA is enabled, a symbolic link that points to the
> +		corresponding memory control directory.
> +
> +		For example, the following symbolic link is created for mc0 and mc1
> +		on node0:
> +
> +		/sys/devices/system/node/node0/mc0 -> ../../edac/mc/mc0
> +		/sys/devices/system/node/node0/mc1 -> ../../edac/mc/mc1

Similar as my review above.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara