Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1816546rwd; Wed, 17 May 2023 01:35:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7z2Ql20prNMl5tvaM70IFAq9h58g+A9n0/vB7jw8/1z70Y78JvL5rD3WavOFVKPwVIGHHI X-Received: by 2002:a05:6a00:14d0:b0:63d:2f13:1f3 with SMTP id w16-20020a056a0014d000b0063d2f1301f3mr54929911pfu.33.1684312527169; Wed, 17 May 2023 01:35:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684312527; cv=none; d=google.com; s=arc-20160816; b=ySSwB857LRkIy/U/JfLHjgaSyl2D996zkuxFVBPL/CEEpq4UpApVWpSReZDZrONf5B pIUWik+d1ShjvAT82805+8fEpZVPhmNdjTgkZV9Z9iqbKkjezD+7vEDlmazDkc9hVlxU iUFflGEzblJ1TAtA9R4NjXgqcN2aeBbmf1aOkHvICFFvb3kQSf0Y2Lu9jPhiB18kmuWI d4vBO/cF8eRHZduSYmNnI/3EtLITHwE3gqL9Ly3ZiOUAyk2sRGswfalxWLDHO4qclL1d 5uSZ93d0NoqV5SGQJGHvxSBEv46WpytdsZmFBQsZvDcWQWql+WNX4GabvzqadIGvwl6M OcnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MYYEfQ7vzuqCApSKZNujoQFgvRYxeJUWWx069C/3rJE=; b=bc2sO56W0LsqzW3nIu+04zknSQsYUcvfh995fWoGE4QEZ/NzuSSCYfMqkoi2GM05/C fqAzm7KapducXHvsIxF4iIgxjJWNAEVf+2nBbdB4j26Ay65LW0wsfdkYG0VeJ9boXOYU eGFxI72H6ydv3m5D09XSQ2cYtL8/PH6ilmgXHXljg3Yyq7XVJNPYxC0UP4UzyrMOa5cc j/t5l5VE5BIeaL2qTUSrIsNYnJIvgsUmVbCXhkKteSXRYue2oxXZAfdLmh+HbYC9mATj /7mDH1iBmAzkEWGwIlbNxR1Xgyx0/ZovLeXc46UrCqrvS/BEz6EuQMVvtJbFG7S70tW6 pJKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FnoH+cpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n28-20020aa7985c000000b00647514cfd36si20097041pfq.242.2023.05.17.01.35.15; Wed, 17 May 2023 01:35:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FnoH+cpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229608AbjEQIIZ (ORCPT + 99 others); Wed, 17 May 2023 04:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjEQIIT (ORCPT ); Wed, 17 May 2023 04:08:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D54CD10C3; Wed, 17 May 2023 01:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MYYEfQ7vzuqCApSKZNujoQFgvRYxeJUWWx069C/3rJE=; b=FnoH+cpgQsF1pchwLsW21vr4yq rfGG5f0tyOZwvmSMI5RyYHyRKIcn/5VvaTBInEHEdxo/1FxUq81ni93lqeXYeDx+qq7x0a01FVAPo 0ozgqxiGnypQ6GkAoTaTosBZHVJMymNQLhfGSekd/hn+aRYYFGfqZ54Qr4XgmuetWL2h0F9zGpRX+ Xhm57JDouW8VZbNg8g1f8K02HbDsqBpIazBHMHWWQykH3UsM+JutLWQ1QWyeaNOdFH0HUGi6R9KZ6 4iBmFAZeNfFYiQA8b1rQU/Jk2ehGWyS5GcZACHZmquFPcEM9I1wTlTTGv3mePU8PxuvW7s+YwkIIR D+aGP5pw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzCCi-008nDb-0c; Wed, 17 May 2023 08:08:12 +0000 Date: Wed, 17 May 2023 01:08:12 -0700 From: Christoph Hellwig To: Niklas Schnelle Cc: Christoph Hellwig , Baoquan He , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v5 RESEND 10/17] s390: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-11-bhe@redhat.com> <6a6f5552fac1427eafbca1288fe5d5cb0cb6a333.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a6f5552fac1427eafbca1288fe5d5cb0cb6a333.camel@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2023 at 09:58:26AM +0200, Niklas Schnelle wrote: > > and just define this to ioremap_wc. Note that defining _wt to _wc is > > very odd and seems wrong, but comes from the existing code. Maybe the > > s390 maintainers can chime on on the background and we can add a comment > > while we're at it. > > I'm a bit confused where you see ioremap_wt() defined to ioremap_wc() > in the existing code? Our current definitions are: No, it's me wo is confused. They clearly are different. But the same comment about just moving ioremap_wc applies to ioremap_wt based on how pgprot_writethrough is implemented then.