Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e650812-d484-12d7-bdf2-7cbe00d53e25@redhat.com>
Date:   Wed, 17 May 2023 11:07:47 +0200
MIME-Version: 1.0
To:     Xia Fukun <xiafukun@huawei.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
References: <20230516123719.117137-1-xiafukun@huawei.com>
 <24c413e6-75a5-254c-b776-1459da83f86f@redhat.com>
 <484d25eb-bcc3-f64f-1182-ff50fb4aca9a@huawei.com>
Content-Language: en-MW
From:   Peter Rajnoha <prajnoha@redhat.com>
Subject: Re: [PATCH v5] kobject: Fix global-out-of-bounds in
 kobject_action_type()
In-Reply-To: <484d25eb-bcc3-f64f-1182-ff50fb4aca9a@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/17/23 10:54, Xia Fukun wrote:
> 在 2023/5/16 22:02, Peter Rajnoha wrote:
>> On 5/16/23 14:37, Xia Fukun wrote:
> 
>>> ---
>>> v4 -> v5:
>>> - Fixed build errors and warnings, and retested the patch.
>>>
>>
>> Please, also check this is still working:
>> https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-uevent
>>
>> When I try passing the example line "add
>> fe4d7c9d-b8c6-4a70-9ef1-3d8a58d18eed A=1 B=abc", it doesn't recognize
>> such input anymore and it incorrectly considers it as erroneous.
>>
> 
> Why did I receive the following error message when passing the example
> line "add fe4d7c9d-b8c6-4a70-9ef1-3d8a58d18eed A=1 B=abc" using the
> original mainline code?
> 
> synth uevent: /devices/virtual/block/ram12: incorrect uevent action arguments
> block ram12: uevent: failed to send synthetic uevent: -22
> 
> Is there a problem with my test case, or is the original code unable
> to successfully parse the sample?
> 

That works for me, I'm testing on kernel 6.2.15:

# echo "add fe4d7c9d-b8c6-4a70-9ef1-3d8a58d18eed A=1 B=abc" >
/sys/block/ram0/uevent

# udevadm monitor --kernel --env
monitor will print the received events for:
KERNEL - the kernel uevent

KERNEL[189.376386] add      /devices/virtual/block/ram0 (block)
ACTION=add
DEVPATH=/devices/virtual/block/ram0
SUBSYSTEM=block
SYNTH_UUID=fe4d7c9d-b8c6-4a70-9ef1-3d8a58d18eed
SYNTH_ARG_A=1
SYNTH_ARG_B=abc
DEVNAME=/dev/ram0
DEVTYPE=disk
DISKSEQ=14
SEQNUM=3781
MAJOR=1
MINOR=0


-- 
Peter