Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 11:35:10 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Dan Carpenter <dan.carpenter@linaro.org>,
        wuych <yunchuan@nfschina.com>, dchickles@marvell.com,
        sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: liquidio: lio_core: Remove unnecessary
 (void*) conversions
Message-ID: <ZGSfzrWHpNf7PbmZ@corigine.com>
References: <20230515084906.61491-1-yunchuan@nfschina.com>
 <61522ef5-7c7a-4bee-bcf6-6905a3290e76@kili.mountain>
 <2c8a5e3f-965e-422a-b347-741bcc7d33ce@kili.mountain>
 <ZGKT01kLOQNRqx9I@corigine.com>
 <20230516202059.09aab4d0@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230516202059.09aab4d0@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s0WFeE3IjHF9kL3jjKtCln/f18QDLMlJOragrcyq+cp3bMsM3Q0/IcZeRYRO?=
 =?us-ascii?Q?jwisuC8yQ6m+uxHDCOpyNyoXjpKAK3U2Y1zjWLCkXpvuLp98vyVRZ+sdYUHD?=
 =?us-ascii?Q?47+neGa0PONUgopDj9FqaBGKdLe/SqY1Krsix3RbMXCrGPmI+Fnu9HCMgYHp?=
 =?us-ascii?Q?UMY3WdRdg8ssyDAKniybCsY64ke7/Pk4KAwKC9h83v4BsCUt5rj/X8LFpQot?=
 =?us-ascii?Q?JuOgwuMmZooYdIhem0knFEXovJV+3cS1Xiq7NGZFih6X7lZ+S4+WEEAWKzFV?=
 =?us-ascii?Q?uAE0TxfCM5huLXuH3IYWWStLAJi6Ez59PLiU1eJYV107VKKh9wvHhcqsQFIc?=
 =?us-ascii?Q?iNm7OlIeAN3jkCCTDTS7ENZ/2srz9bO2hFdrIj6LA+kdgQARduXJn9RE8loG?=
 =?us-ascii?Q?qVi9QZln+pV+vI2dCRHVVxcdtc0qEwugl/xx62jinQ1StwNufrXdTxUeGZ/7?=
 =?us-ascii?Q?jivMYIYR7cYZfPo0E9VZrvTIE0gPki0L0Eovi+KtGlDO03i3D/oYf2zzzIBC?=
 =?us-ascii?Q?U/cosh9oGiXmBlFZk1Wo/KZ73A28zssynVFxIF6PJypMkB5YXVxQ6oRMnsdY?=
 =?us-ascii?Q?wNZuYevD5W5XX1U6Qp0puHi03flOIYZlYl9CwCPIQrUNI+v0Nm6wgnwagTtB?=
 =?us-ascii?Q?5P6P7dFiaZgdMaZVh+ZwTB050VAjCiwVlzB8PItL1c91L6K/rCVDYNgxzdgG?=
 =?us-ascii?Q?0T1zqj9Bssh2ZFyIKajTr0bC0M3GPt+b6Y0EV9YkwKuakTfCi50YLc497IgE?=
 =?us-ascii?Q?ipwme4DhkQTyo4EK1UHOoOf+1yLHGv/Cbpdia9hkiLPTREj1EU3yCSvEzV6v?=
 =?us-ascii?Q?g9VTQ42K/sm3pKgsmufB4zIpFk5d5ueaWx3O+4crTsUq8KNF2jrbkgwLI56H?=
 =?us-ascii?Q?hNXtIkfR8n89miw1MQggJZs04C5QmZY+WIdSE1oxVciPNF41YO7hzovfxm1F?=
 =?us-ascii?Q?m7qmwMVCXurMsEU+ZJjKlbhXdp1C52Sj3pkLIEdQoVvNIFx2SFiuh34jTmoe?=
 =?us-ascii?Q?MgKzszdHcySp5u23kWifxmgxLmGqzLTLBL41ZLY47koizV3aZnFWvak1V0Qo?=
 =?us-ascii?Q?1/dme3esOsTOZKR7dysOrFCjo1mHxbDWYoe5EL7yqVMRZvPy2NnYvq2J5oI6?=
 =?us-ascii?Q?HdX0flHLEFhwlH6tn+7J/ik562mD6jgA4hLAgqCeWjYIkIWE/oH7bsV+lp02?=
 =?us-ascii?Q?D2+XO/Thf0clkdGj+6kRxulnfhj5S3agk1g7zPuJZNbhJUmVdUU0rTNBvkjr?=
 =?us-ascii?Q?FbPrZ6eNw2e7WCPUc85jkG+H3Pz2XzHG4Q1Q3iw5k4+T1mxKEbtsooHoNJxk?=
 =?us-ascii?Q?3gnX+eUDxzBD/z7OfZFX7EfaLAl1gUW/tbqaXKOXaZzzL91IqmGJ6AmY2g4O?=
 =?us-ascii?Q?Wq+Mv52/fFgvSWFsX2LO/TAXSH5FIB/XC9cyD8sXE6HD/V7SExAinRT0HSWD?=
 =?us-ascii?Q?0zFu45jJNpN/YCu7nFnywm0ccB8jqoSwYIo8h1ux3/473507WSEsORCS2uk9?=
 =?us-ascii?Q?lszV362YYN8Hvu7ZI8mY7a5P6blK4yeQOCv7bQaQQsj61MUUzsbve0cyW/66?=
 =?us-ascii?Q?wJjd82jSo+0i06qOD1/7Vkxg41up5QeDKGx3T9sCODFoXNReXKNw4iX0qTG0?=
 =?us-ascii?Q?qgQFZsCamnP/rh7wajqPiZrzrI60UCQb320QWQ4k8iyp0GEZi5uIkR/C99/h?=
 =?us-ascii?Q?+1yqpg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0491d8a-5607-4d14-3dbf-08db56ba06af
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 09:35:18.0699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: krrS+b1z6AQiPOdKdXaNqOi+S3UBYMxrx1uU/XS04BtxzuchWaJkWv7GkX/E4YBWiNzbImEJPgu0xpKOfux2dcBX2UgqhmSIfSZDM3g1iyc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3632
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 16, 2023 at 08:20:59PM -0700, Jakub Kicinski wrote:
> On Mon, 15 May 2023 22:19:31 +0200 Simon Horman wrote:
> > On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote:
> > > On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote:  
> > > > Networking code needs to be in Reverse Christmas Tree order.  Longest
> > > > lines first.  This code wasn't really in Reverse Christmas Tree order
> > > > to begine with but now it's more obvious.  
> > > 
> > > Oh, duh.  This obviously can't be reversed because it depends on the
> > > first declaration.  Sorry for the noise.  
> > 
> > FWIIW, I think the preferred approach for such cases is to
> > separate the declaration and initialisation. Something like:
> > 
> > 	struct octeon_device *oct = droq->oct_dev;
> > 	struct octeon_device_priv *oct_priv;
> > 
> > 	oct_priv = oct->priv;
> 
> I don't think these changes are worth bothering with at all, TBH.

Understood.