Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <579da980fa02682522e7e4ada5be36fc972ea838.camel@kernel.org>
Subject: Re: A pass-through support for NFSv4 style ACL
From:   Jeff Layton <jlayton@kernel.org>
To:     Christian Brauner <brauner@kernel.org>
Cc:     Ondrej Valousek <ondrej.valousek.xm@renesas.com>,
        "trondmy@hammerspace.com" <trondmy@hammerspace.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andreas Gruenbacher <agruenba@redhat.com>
Date:   Wed, 17 May 2023 05:58:37 -0400
In-Reply-To: <20230517-herstellen-zitat-21eeccd36558@brauner>
References: <20230516124655.82283-1-jlayton@kernel.org>
         <20230516-notorisch-geblickt-6b591fbd77c1@brauner>
         <TYXPR01MB18549D3A5B0BE777D7F6B284D9799@TYXPR01MB1854.jpnprd01.prod.outlook.com>
         <cc4317d9cb8f10aa0b3750bdb6db8b4e77ff26f8.camel@kernel.org>
         <20230517-herstellen-zitat-21eeccd36558@brauner>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-05-17 at 09:42 +0200, Christian Brauner wrote:
> On Tue, May 16, 2023 at 05:22:30PM -0400, Jeff Layton wrote:
> > On Tue, 2023-05-16 at 20:50 +0000, Ondrej Valousek wrote:
> > >=20
> > > Hi Christian,
> > >=20
> > > Would it be possible to patch kernel the way it accepts native (i.e n=
o
> > > conversion to Posix ACL) NFSv4 style ACLs for filesystems that can
> > > support them?
> > > I.E. OpenZFS, NTFS, could be also interesting for Microsofts WSL2=A0 =
or
> > > Samba right?
> > >=20
> > > I mean, I am not trying to push richacl again knowing they have been
> > > rejected, but just NFS4 style Acls as they are so similar to Windows
> > > ACLs.
> > >=20
> >=20
> > Erm, except you kind of are if you want to do this. I don't see how thi=
s
> > idea works unless you resurrect RichACLs or something like them.
>=20
> I have no idea about the original flame war that ended RichACLs in
> additition to having no clear clue what RichACLs are supposed to
> achieve. My current knowledge extends to "Christoph didn't like them".
>=20
> >=20
> > > The idea here would be that we could
> > > - mount NTFS/ZFS filesystem and inspect ACLs using existing tools
> > > (nfs4_getacl)
> > > - share with NFSv4 in a pass through mode
> > > - in Windows WSL2 we could inspect local filesystem ACLs using the
> > > same tools
> > >=20
> > > Does it make any sense or it would require lot of changes to VFS
> > > subsystem or its a nonsense altogether?
>=20
> Yes, very likely.
>=20
> We'd either have to change the current inode operations for getting and
> setting acls to take a new struct acl that can contain either posix acls
> or rich acls or add new ones just for these new fangled ones.
>=20
> Choosing the first - more sensible - of these two options will mean
> updating each filesystem's acl inode operations. Might turn out to not
> be invasive code as it might boil down to struct posix_acl *acl =3D
> acl->posix at the beginning of each method but still.
>=20
> Then we'd probably also need to:
>=20
> * handle permission checking (see Jeff's comment below)
> * change/update the ACL caching layer
> * if the past hast taught me anything then overlayfs would probably need
>   some additional logic as well
>=20

Yeah, it's a significant project.

> > >=20
> >=20
> > Eventually you have to actually enforce the ACL. Do NTFS/ZFS already
> > have code to do this? If not then someone would need to write it.
> >=20
> > Also windows and nfs acls do have some differences, so you'll need a
> > translation layer too.
>=20
> Jeff, I know you have some knowledge in this area you probably are
> better equipped to judge the sanity and feasibility of this.

I know a bit, but Andreas (cc'ed) is the undisputed expert. If you're
looking to resurrect this effort, then you should definitely loop him
in.

--=20
Jeff Layton <jlayton@kernel.org>