Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 May 2023 13:55:52 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Hongyu Xie <xiehongyu1@kylinos.cn>
Cc:     linux@armlinux.org.uk, jirislaby@kernel.org,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        xy521521@gmail.com
Subject: Re: [RFC PATCH -next] tty: serial: add panic serial helper
Message-ID: <2023051700-applied-briskly-61f1@gregkh>
References: <20230517101403.232594-1-xiehongyu1@kylinos.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230517101403.232594-1-xiehongyu1@kylinos.cn>
Precedence: bulk

On Wed, May 17, 2023 at 06:14:03PM +0800, Hongyu Xie wrote:
> +config PANIC_SERIAL_HELPER
> +	tristate "debug through uart when panic"
> +	depends on PANIC_TIMEOUT=0
> +	select CONSOLE_POLL
> +	default m

No need to set this default, unless it is required to boot/run properly
with this value.

> +	help
> +	    Debug through uart when kernel panic happens.
> +	    This module helps you to get full kernel message through uart.
> +	    Say Y if you want add this to built-in kernel.
> +	    Say M if you want add this as a module driver.

What will the module name be?

And you need a lot more description here to explain what this is and why
anyone would want it and how it is to be used.

thanks,

greg k-h