Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2048165rwd; Wed, 17 May 2023 05:11:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ405iGRQbb39NnQWOq2ItQifziDU8SwHgTCuh8cpDUITYUPtojbpx/oevHXxx/fVEvJU99r X-Received: by 2002:a05:6a20:7352:b0:f0:b6e3:90c9 with SMTP id v18-20020a056a20735200b000f0b6e390c9mr45664697pzc.4.1684325489829; Wed, 17 May 2023 05:11:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684325489; cv=none; d=google.com; s=arc-20160816; b=WgbljXqpXxB8FKG6wYxlBHzzCdrakT61j6NWpAirAzJbTPEz0nFdmmHeIEi+1DNTlX rP98l1AYwvE/sSbXZQFs5Qapcto8MoTYH1ZdI2QM07Z+gbwuchSMCyOnbtA/sgnQ/DrW OW5qhKaXHUecViEkwZrtvwHrZCFVLHzbk3R+SGI1FT2Bex3Rzt46V+ds/JLQJpipEWDV 6g76+75UaUoXA6Kh8Dl0dPU21sf9xaEc+08X3q/loMfrrUzAL+Gu8bJ81spE/Lhf4ImV HqQNDofafmBlKtyhsA/NieFk1Nd06WwMTIu7hHDlrdMbZBjy7JL3Oab4ihgZfQb6Jw+t 2y8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2yg5dulfXCIZ4ZKB358Eid67ZN4o7nDbGJVhWhZT5Wg=; b=M7tIQ4Zp+hQkKpDnjM7P9csBY5xyGZHN+G7DMLYPpLS8kIZUITRF8gsEAFb+T46a12 lDV1y1fbgNwbjHxJR8D0dCK+aS3gXN8AXRWXfgAMM3jrE5+XiYvYv1AKN5nu2VDImAhY HOupaza+pfgP7bIpq2dmsImaQzuvTdOVp20hI1XR7O9AKyitekPqKeYpjj9dsftg9uj1 OhIMX8wpqYuIcUf/WCcJARy3qgJqmWpZHKBr2rfhyWwhHLXLPX0hPkNnPd90UnnBUzo3 CWWMSkHAN8Dhe8riv7NgwNiILQEPoRluH1Y0Qf6kG6TQ7c/CdRDzqIfjPELIXgX4u+44 TWpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xlKIH9bN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m64-20020a633f43000000b00520861f7c0csi20398942pga.501.2023.05.17.05.11.15; Wed, 17 May 2023 05:11:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xlKIH9bN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231414AbjEQL6D (ORCPT + 99 others); Wed, 17 May 2023 07:58:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbjEQL6B (ORCPT ); Wed, 17 May 2023 07:58:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36BCF5FEB; Wed, 17 May 2023 04:58:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B972F64608; Wed, 17 May 2023 11:57:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCF55C433D2; Wed, 17 May 2023 11:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684324679; bh=2yg5dulfXCIZ4ZKB358Eid67ZN4o7nDbGJVhWhZT5Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xlKIH9bNuIM8nx6vlJhuRP/iHRzPPbdsawJQ+njinxjyPkSVhS+0oq4EtDCn3mWX2 1iDKfP0ioycYNT/W+PNFBE+7g3M2EML6FGFs3pzhQsjCwHhfHwRqGkK59UsghAiHgd R3cdRMIYRVUw5Mv25bYqcBhn5kHTCWlbE2HoR+LQ= Date: Wed, 17 May 2023 13:57:56 +0200 From: Greg KH To: Hongyu Xie Cc: linux@armlinux.org.uk, jirislaby@kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, xy521521@gmail.com Subject: Re: [RFC PATCH -next] tty: serial: add panic serial helper Message-ID: <2023051739-ouch-pound-7b1c@gregkh> References: <20230517101403.232594-1-xiehongyu1@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517101403.232594-1-xiehongyu1@kylinos.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2023 at 06:14:03PM +0800, Hongyu Xie wrote: > --- /dev/null > +++ b/drivers/tty/serial/panic_serial_helper.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL > + * > + * panic_serial_helper.h Debug through uart when panic. > + * > + * Copyright (C) 2023 Xie Hongyu > + * > + * Inspired by kgdboc. > + */ > +#ifndef __PANIC_SERIAL_HELPER_H > +#define __PANIC_SERIAL_HELPER_H > +/*TODO*/ > +#endif /* __PANIC_SERIAL_HELPER_H */ A whole file that does nothing? confused, greg k-h