Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2123328rwd; Wed, 17 May 2023 06:09:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5q8+mbiSekYIJ/LeX/Ikm+pQ6UAJdLMEddYd6aPXkpM11v93BU2PRMTCtNY7Xo7CvoD19J X-Received: by 2002:a17:903:120f:b0:1ac:6d4c:c265 with SMTP id l15-20020a170903120f00b001ac6d4cc265mr43215515plh.28.1684328999515; Wed, 17 May 2023 06:09:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684328999; cv=none; d=google.com; s=arc-20160816; b=QUFETjlmpaz/cV/Jy2vFFlswdRCpdzIj/jzzTPp8SKlAy6XEJIFdoEA7iPM+g2ZxdN Sn/uhFSn/VDmFiNh/jYtbOTg0e9/D/6BqrTu4EO9Xa22bsCzQFAjLmEfAxJq39WjRQtz 7YUnEcHHEUGZHRZ8LW95gSmLS2VhRdgc2EmLNAv72+wFde/v7zN/l+nWQNxiL9lAKGiv zyT7imA/K3wWv0d+6sqjjubaOP1fYLFJUgYyhODWxu8CnPRinEn2O5uUqHLBj015UGWx XUqbU/6vNhOMReke/rOjqa+5n+uxldxUpY0rRy9Lx8bv0vEoS7/QT+QZVjIFpqtTeRFH Hasw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=gNevE736BEsxBU0FmwLJIhGqBiG7yoAC/t6/uUIBMdY=; b=BE4ieyZFsvznumRrkqYv0EustV7hH10Mj8FNqnRhKg5m67mpYLpMtyZjTqxvX+jijq 9VLlsaHm5y9Zc+y5+LpQomp8B052sVnJiH4mQOAKiIq3sJMeXGsfzmBL8dx912LVkdvM 6tNML8amx6N38guxhwJeXmDtvwyQfNj5xxo4axX1EeNxjebzmRiRjcDrLG2GL6M6hL9k Cuh8EDJyT4K9bXl6AIjImSMPFXbWQafnK9jha0LhOEGgW8c6Y797Shk9RbciDIeGyFzk D/1pXetp0qZUirqGbS9dYrHiW6Edc7J+wAHXqZuL7n0GlRL3iHPHHvSV9HCYnd+wykIV QdoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FMlLS0aE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d7-20020a170902aa8700b001a994803b1csi20234205plr.19.2023.05.17.06.09.45; Wed, 17 May 2023 06:09:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FMlLS0aE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231294AbjEQMoK (ORCPT + 99 others); Wed, 17 May 2023 08:44:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbjEQMoJ (ORCPT ); Wed, 17 May 2023 08:44:09 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51BE2D4E for ; Wed, 17 May 2023 05:44:06 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-ba82d82bd39so923578276.2 for ; Wed, 17 May 2023 05:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684327446; x=1686919446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gNevE736BEsxBU0FmwLJIhGqBiG7yoAC/t6/uUIBMdY=; b=FMlLS0aECYmfOvG19PTRQ4JzQVOPvgp3keEl4q4lBIcarONNex1FSS2aSSOrdLjxfE OYiPfSd3p8dfD1QItx7D8wl2cvYk/x1+YjFMYiLcupDwHagK7bMFjrihVjrw89h1isK/ BL8m4dOesp9dOvFJIsPhRXwRJJZw0WXMjrRaZLCGs1aGyZghu3sRXCSFqAbHEbi4bEe9 sb34beQApq2PcsJ82bacmFQQUt6j72BaQNjANrnbsGmWxQJeZKXoqvssjMl8KTkBxSm2 hNmUL8hfNmz56/sTiGz6zGIXfLgQdcu9zLtf9Q3wfq58AlUNYHc4mTp5/+V36z6r3Z0n 03CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684327446; x=1686919446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gNevE736BEsxBU0FmwLJIhGqBiG7yoAC/t6/uUIBMdY=; b=afKyr4HemXBl06NWXBFj8PyM/v1pB/GH1way0m0NrBB6fVbmxJ6c9ZDzQTHLZjxNlk dKGqQBNmaEzfMriQ1e++8jyqiXbFL8zg1ZMW6L1DX6NpAK/fosYLt5FKnHL8eVY/8rBS VDzdlb3+PGPQpI9YHOJyOevWXWG2oJ4IHTXbeGFCMrDDIZy8LgW2BSriafk14jTh6+Qi 2vHKLQNoSFe/NH+bgR5yYZCP9O8GvSXYGA59H0M+Bu+/QQOdxKxYJY/cazzUWsT1gJny DZlKxXgX68DmWpyNicPhOgkCgZ4K/UojWbBc5Q46j1ybQSJ5TWtvaFLgenSShIraYKpQ DQug== X-Gm-Message-State: AC+VfDx7DrBMXGawsGYcQcWsJu3ZiRZTy2afhP6W2OHL0ptSKwP2DWu7 Gf4ODIPGJ90Oeg9dX76tw6+BkfgKZtiGgybfQIn6cg== X-Received: by 2002:a25:1504:0:b0:ba7:382f:6380 with SMTP id 4-20020a251504000000b00ba7382f6380mr12543280ybv.24.1684327445737; Wed, 17 May 2023 05:44:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Wed, 17 May 2023 14:43:54 +0200 Message-ID: Subject: Re: [PATCH v4 0/7] fix fwnode_irq_get[_byname()] returnvalue To: Matti Vaittinen Cc: Matti Vaittinen , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Paul Cercueil , Wolfram Sang , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2023 at 9:12=E2=80=AFAM Matti Vaittinen wrote: > The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned > zero if mapping the IRQ fails. This contradicts the > fwnode_irq_get_byname() documentation. Furthermore, returning zero or > errno on error is unepected and can easily lead to problems > like: Also, zero is not really a valid IRQ, it means NO_IRQ: https://lwn.net/Articles/470820/ I'll apply the pinctrl patches. Yours, Linus Walleij