Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd2abfae-b8d8-2416-57aa-49da7a9915dd@talpey.com>
Date:   Wed, 17 May 2023 10:01:04 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 06/12] cifs: Pass a pointer to virt_to_page() in cifsglob
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Vineet Gupta <vgupta@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Russell King <linux@armlinux.org.uk>,
        Greg Ungerer <gerg@linux-m68k.org>
Cc:     linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
        linux-snps-arc@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org
References: <20230503-virt-to-pfn-v6-4-rc1-v1-0-6c4698dcf9c8@linaro.org>
 <20230503-virt-to-pfn-v6-4-rc1-v1-6-6c4698dcf9c8@linaro.org>
From:   Tom Talpey <tom@talpey.com>
In-Reply-To: <20230503-virt-to-pfn-v6-4-rc1-v1-6-6c4698dcf9c8@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1dtbE5IM1BxdFFMaDFLWmc3YXQ4b0tzUzhUU0N5S2dwdmRCN2lWR216R1hW?=
 =?utf-8?B?TU44WUlvVWVtYVFCWk5XUHdyVHZ4RFJ6ZTRtMloxbmQwREEwcE13UzRGb2NT?=
 =?utf-8?B?QmNzUkpxaWVxSWMxUDFMaVozZXUxQ0gzUUV3UFpXK0FJZkluU0lrRTZmQ0E2?=
 =?utf-8?B?eHpEM1h6bWhDVjA4dE5QTWViOGtFL0NsNktDQUZGTmo4R1RtU3VmUVBwYWdS?=
 =?utf-8?B?RmJBT2dwMHhIbmRiNE5pUnNNSy9JNGNxY1dsT096TlVrbytnclhjSGZGdFlH?=
 =?utf-8?B?MUYybFN6K3dmUXYvUUdmOTdVY2wzSm44RlNXQlVORTliUGpRaEVOdTQ2dzZJ?=
 =?utf-8?B?UkZIOGZkb01hYUoxdXBlclZFWDBwNHE2ckRObmdMTDkxYTF3dDdEU3d4OXBO?=
 =?utf-8?B?djJQMmh1emI3RGM2ZFZMbGJVT2tPNFpHdHVJLzhWai9mYUovek1KcHAwQ3Nt?=
 =?utf-8?B?aUtpaGx2K3NnWnQ5c2ZCelVYS3haK2pWNmpKNmI4cmg1QmhvN1J3NjFXV1F2?=
 =?utf-8?B?ZEw5YTRldWVhNktNRGZsd0FCd3ZzK3pVc0hiaElOUlpWdkd0cWp5b2VGNzlY?=
 =?utf-8?B?VTlFMzRwM0dYSEhVbWxuMTIza3Z6T2ZUZU5pZkFKSlBSdkc0TFkyVXNnMVNB?=
 =?utf-8?B?RDl6MFFuK2FDdm12SzBPT1BXaE9Xd2RFdlFUdUwvb2JGbzdPblg0QU5hSERh?=
 =?utf-8?B?blh6WDJyS0RsV1Q3enNtWVczMTVNZWtXdFZnRWMrbjRlTnA4Q2hFMnB0UGln?=
 =?utf-8?B?WnA3cUtWSkoxSURiSmJaZnJKait5bno5MWZpb1ptaDJibkt3YkZoSnlOR2x4?=
 =?utf-8?B?ekNMUEk4akdWMTh4U081ZDhkK1JtMi96VG1UaW96UUh6ZytTSGI5NXpCLy8v?=
 =?utf-8?B?RnZIZGFONU5FVk9oZ0pWYUxtczJjcmszSm5CejQwMGl1RkxZWEpFWGFvUnRs?=
 =?utf-8?B?dGdvdThEVm5qNUMxZGg1ZkJaNENTdlVQYWtVN2FKSVB6WHFHMmRkbFExVUFL?=
 =?utf-8?B?VGVMVzNPSDBhNEdlOVo3NTBiOTF1RFpUSUtESC9FbjllMkpkTkQ2TkMrSmw4?=
 =?utf-8?B?bC9Ud3VvSmdmUTQzemE5L3VFbkNRekg1dm1SSDRjU1ZaOUFNNGlqYWJOR3Rm?=
 =?utf-8?B?UFFiRHluQjZkL29mMmYyY3ZlSXFyTi9oam4zclRQbDEyTHpSRHlPSjhCaFkv?=
 =?utf-8?B?SXR1OFFPT2VTWjZxTFpyY1hmUlBYam9DQnNNbnRFNlRnd1FJY05tSnNxeTVo?=
 =?utf-8?B?N0c0OXVnd3RWV1paUXAwRXRDbW0zSS9nS1g2UEQ1MEFqRzZpMmE2VEZpT3ph?=
 =?utf-8?B?TFIrcHZmM0JjaW8wOTdhMFByclpxTnd5Z1FKbGZyV29tSkNKcHM4QUZKVWFK?=
 =?utf-8?B?c0RycE5renpicDFsSC9VQnhFVHBQVEJ6YXBKT3hMb3BUVGMzak9NZ2lNS1Jt?=
 =?utf-8?B?ZFphc0Y4SFFqNEpDU2tTK2VFaklLZDFuRzV0YzIzZ0tFSXR1RGpQeDZjT2wy?=
 =?utf-8?B?Z2EvcWFmemZXUDZDNjFMTnB3VkVtc2dTMll1WWQrOXNJK3hJS01NaTZEcTUx?=
 =?utf-8?B?RVgxVmNsMk5Yb2RuVzlsZW50ckN5eEhBUUlMT0w2Y1Y4Rm44QkQrQnZoSnV1?=
 =?utf-8?B?RDh2c0NET3dMUi93WVI2bWFpamNlbC9LUy9DSUVteVJEUVkvb0QzbENYSTNa?=
 =?utf-8?B?a3hFWjFIVEp4Q3VTUEVUM0Y3WWE0U1V0ZzJQaEs1TGlRelp1enY5a3ZNRC9B?=
 =?utf-8?B?NXVIYzUrRTgyNTRwdDhNSmdZVnFwU1FRMVJmd0ZGR2hGdU1wUEpHdXEzSjAr?=
 =?utf-8?B?dzRaYStpNXJ6YWJEZVExY2FvdENUcXArQTdiMHJBREFDNHNYSTRneW00cG9L?=
 =?utf-8?B?S0lvcGpicTlpZ2NaaUh0SUc1ZFhrWUFtWGxHald1U09menRPL3luVC9uRytR?=
 =?utf-8?B?blFVRlZjN0pJRXRlcWxVVTV2T0l0WG0wc05USUNoMmhORmZaKzVxMUNEZkNv?=
 =?utf-8?B?V3V0b1BSMVdOMnphUnFPMWl1cVFpYkoyYWNQREhDL1lLcVU5cmVVTlV6SVYw?=
 =?utf-8?B?MHdtQTZ5ekFOc1JKbzhuNG1ETFVSYThBeGdvbWdJMTRidUYwTnlZbys5YTRQ?=
 =?utf-8?Q?27qoJ/xFefoZTgyFxSv3pKhis?=
X-OriginatorOrg: talpey.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1966ef6f-3422-49e4-2146-08db56df2926
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4445.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 14:01:07.2578
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2b2dcae7-2555-4add-bc80-48756da031d5
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DstVk89vSlDEmosLCcRivC/WkwdUgfAvpfm3CORTspDeG0t8KZC7NKjQUXLLFY2H
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR01MB3794
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/11/2023 7:59 AM, Linus Walleij wrote:
> Like the other calls in this function virt_to_page() expects
> a pointer, not an integer.
> 
> However since many architectures implement virt_to_pfn() as
> a macro, this function becomes polymorphic and accepts both a
> (unsigned long) and a (void *).
> 
> Fix this up with an explicit cast.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


For fs/cifs:

Acked-by: Tom Talpey <tom@talpey.com>

> ---
>   fs/cifs/cifsglob.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 414685c5d530..3d29a4bbbc40 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -2218,7 +2218,7 @@ static inline void cifs_sg_set_buf(struct sg_table *sgtable,
>   		} while (buflen);
>   	} else {
>   		sg_set_page(&sgtable->sgl[sgtable->nents++],
> -			    virt_to_page(addr), buflen, off);
> +			    virt_to_page((void *)addr), buflen, off);
>   	}
>   }
>   
>